Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: remove dead code
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13496
To
Liron Ar has posted comments on this change.
Change subject: core: Remove not used powerDownVDSCommand.
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/vdsbr
Daniel Erez has posted comments on this change.
Change subject: core: searchbackend - sort VMs by host name
..
Patch Set 2:
The name of the columns is "Host". We do allow sort by all columns - 'host'
just been left out...
--
Roy Golan has posted comments on this change.
Change subject: core: searchbackend - sort VMs by host name
..
Patch Set 2:
sortby HOST is OK but could be better I feel.
Whats the name of the column in the VM grid?
general Q - wh
Sandro Bonazzola has posted comments on this change.
Change subject: make validateFQDN case insensitive
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13539
To unsubscr
Mike Kolesnik has posted comments on this change.
Change subject: core: Added validation for bond name format
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13480
To unsubscribe, visit http
Mike Kolesnik has posted comments on this change.
Change subject: core: Added validation for host NIC name length
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13479
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: Format string should use %n rather than \n
..
Patch Set 1:
Merge?
--
To view, visit http://gerrit.ovirt.org/13513
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: Found reliance on default encoding
..
Patch Set 1:
Merge?
--
To view, visit http://gerrit.ovirt.org/13512
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 1:
Ofer, can we get this into ovirt 3.2 as well?
--
To view, visit http://gerrit.ovirt.org/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removed unused Roles queries
..
Patch Set 1:
I need to rethink about this, might need to use some of the code here... can
you please rebase and put it la
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove unused IsUserPowerUserOrAboveQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13443
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove GetVdsByHostQuery leftovers
..
Patch Set 1: Looks good to me, approved
Fix the typo
--
To view, visit http://gerrit.ovirt.org/13444
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove GetVdsByTypeQuery leftovers
..
Patch Set 1:
Approved, but fix the typo mentioned by Omer before merge
--
To view, visit http://gerrit.ovirt.org/13
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove GetVdsByTypeQuery leftovers
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13445
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove the unused GetNonOperationalVdsQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13446
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove unused GetUsersByVmidQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13447
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 2: (2 inline comments)
.
Yair Zaslavsky has posted comments on this change.
Change subject: core:Power Management or fence errors are not...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13510
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: pki: cleanup: Found reliance on default encoding
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13512
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: pki: cleanup: Format string should use %n rather than \n
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13513
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing CustomLogField annotation
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13527
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: core: Java7 Engine build
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13519
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice [wip]
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13531
To uns
Mark Huth has posted comments on this change.
Change subject: ensure restored engine db objects are owned by engine user
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13377
To unsubscribe, visit http://gerr
Mark Huth has posted comments on this change.
Change subject: make validateFQDN case insensitive
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13539
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Mark Huth has uploaded a new change for review.
Change subject: make validateFQDN case insensitive
..
make validateFQDN case insensitive
If the specified FQDN to rhevm-setup is a different case to that
returned by the DNS PTR re
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: introducing German (de) - part 2
..
Patch Set 2: Verified
rebased, re-pulled updated German .properties files from Zanata, verified.
@Derez
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: introducing German (de) - part 1
..
Patch Set 2: Verified
rebased, conformed to pom.xml changes (i.e. "all-langs" moved to parent
pom.xml),
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: configure mod_deflate apache
..
Patch Set 1: Verified
Build RPMs from source and then installed them on a F18 machine succesfully.
The YS
Alexander Wels has uploaded a new change for review.
Change subject: userportal, webadmin: configure mod_deflate apache
..
userportal, webadmin: configure mod_deflate apache
- Configured mod_deflate on install. The module was
in
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Adding Volume ID to volume general tab
..
webadmin: Adding Volume ID to volume general tab
Volume ID field is added to volume's general subtab,
it will
Maor Lipchuk has uploaded a new change for review.
Change subject: core[WIP]: Remove not used ExtendVolume.
..
core[WIP]: Remove not used ExtendVolume.
Removed ExtendVolumneVDSCommand, there is no use of it in the engine
code.
V
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Remove not used PollVdsCommand.
..
core: Remove not used PollVdsCommand.
Removed PollVdsCommand, there is no use of it in the engine code.
Change-Id: Ie2f
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: remove default constructor from DbUser
..
engine: remove default constructor from DbUser
Only the default constructor is left, it is not needed
Change
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remove DBUser.desktopDevice [wip]
..
Patch Set 1:
not quite tested yet, just a quick fix. unit tests pass of course.
--
To view, visit http://gerrit.ov
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: remove DBUser.desktopDevice [wip]
..
engine: remove DBUser.desktopDevice [wip]
desktopDevice property was completely unused, so now it is removed
Chan
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13530
To unsubscribe, visit http://gerrit.ovirt.org/se
Daniel Erez has posted comments on this change.
Change subject: webadmin: search bar - sort VMs by host name
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13526
To unsubscribe, visit http://gerrit.ovirt.org
Alissa Bonas has posted comments on this change.
Change subject: core: add the db-upgrade maven profile
..
Patch Set 1:
It needs to specify the dbuser, otherwise it doesn't run with postgres user.
--
To view, visit http://gerr
Michael Kublin has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 2:
"why getAllTaskstatuses is used as HSM and SPM command in engine side
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added NFS advanced options in Storage general sub tab
..
webadmin: Added NFS advanced options in Storage general sub tab
The Storage general sub tab now d
Michael Kublin has posted comments on this change.
Change subject: engine: Removing CustomLogField annotation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13527
To unsubscribe, visit http://gerrit.ovirt.or
Alissa Bonas has posted comments on this change.
Change subject: webadmin: Disable destroy on Storage Domain when active
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing CustomLogField annotation
..
engine: Removing CustomLogField annotation
The following annotation is not required, the uses of this annotation
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: search bar - sort VMs by host name
..
webadmin: search bar - sort VMs by host name
Adding support for sorting VMs by host name
(using search - 'Vms: sor
Alexander Wels has uploaded a new change for review.
Change subject: userportal, webadmin: i18n refresh 'sec'
..
userportal, webadmin: i18n refresh 'sec'
- Fixed 'sec' not being i18ned on the refresh panel
drop down.
- Renamed M
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added POSIX VFS validation & hint on storage create
..
Patch Set 1: (1 inline comment)
File
fronten
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added POSIX options in Storage general sub tab
..
Patch Set 1: (2 inline comments)
File
frontend/we
Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 2:
"why getAllTaskstatuses is used as HSM and SPM command in engine side
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disable destroy on Storage Domain when active
..
Patch Set 1: Looks good to me, approved
When the relevant UI infra is introduced, should add a tool-tip
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: use python daemon instead of own
implementation
..
Patch Set 3: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/13435
To un
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: add options for wrappers
..
Patch Set 4: Verified
Clear pid file if cannot be deleted.
--
To view, visit http://gerrit.ovirt.org/13418
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: rework start pid file handling
..
Patch Set 5: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/13415
To unsubscribe, visit h
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: set default service mode to
foreground
..
Patch Set 3: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/13497
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove dead code
..
Patch Set 3: Verified
Rebase
--
To view, visit http://gerrit.ovirt.org/13496
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13495
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: remove limits.d file
..
Patch Set 3:
Rebase.
--
To view, visit http://gerrit.ovirt.org/13495
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: downstream infrastructure usage
..
Patch Set 5: Verified
1. console log will go to console.
2. exit wait by exception, I hope context
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: rework start pid file handling
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-service: allow service user customization
..
Patch Set 4: Verified
rebase
--
To view, visit http://gerrit.ovirt.org/13485
To unsubscribe, visit
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Disable destroy on Storage Domain when active
..
webadmin: Disable destroy on Storage Domain when active
When a Storage Domain is in active status the des
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Add an alert when adding a Domain to uninitialized
pool
..
webadmin: Add an alert when adding a Domain to uninitialized pool
When trying to add a Storage
Federico Simoncelli has uploaded a new change for review.
Change subject: core: add the db-upgrade maven profile
..
core: add the db-upgrade maven profile
Change-Id: I4a7c88cf8599226d565d5334af28b1b8bda2617e
Signed-off-by: Feder
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added POSIX VFS validation & hint on storage create
..
webadmin: Added POSIX VFS validation & hint on storage create
Added a validation of special charact
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added POSIX options in Storage general sub tab
..
webadmin: Added POSIX options in Storage general sub tab
The Storage general sub tab now displays the pa
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: Format string should use %n rather than \n
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13513
To unsubscribe, visit http://ger
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Extract code of network role columns
..
webadmin: Extract code of network role columns
NetworkRoleColumnHelper is introduced to re-use the cons
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Extract code of network role columns
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13256
To unsubscrib
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: adding migration role to a network.
..
webadmin: adding migration role to a network.
Just one network in a cluster can have this role.
The eff
Alona Kaplan has posted comments on this change.
Change subject: webadmin: adding migration role to a network.
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12976
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: pki: cleanup: Found reliance on default encoding
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13512
To unsubscribe, visit http://gerrit.ovir
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: add copy of migration property to NetworkCluster
cloner.
..
webadmin: add copy of migration property to NetworkCluster cloner.
"migration" is
Alona Kaplan has posted comments on this change.
Change subject: webadmin: add copy of migration property to NetworkCluster
cloner.
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Extending migrate verb with an additional parameter-
"dstqemu"
..
engine: Extending migrate verb with an additional parameter- "dstqemu"
The dst
Alona Kaplan has posted comments on this change.
Change subject: engine: Extending migrate verb with an additional parameter-
"dstqemu"
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: adding "migration" property to NetworkCluster
..
engine: adding "migration" property to NetworkCluster
Updating the business entity and the relat
Alona Kaplan has posted comments on this change.
Change subject: engine: adding "migration" property to NetworkCluster
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12962
To uns
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options.
..
engine: adding "NetworkMigrationEnabled" to vdc_options.
Migration network is 3.3 feature.
Ea
Einav Cohen has posted comments on this change.
Change subject: webadmin: Stay in the same tab if possible
..
Patch Set 1: Looks good to me, but someone else must approve
I cannot review the code, but I like the concept.
Addin
Alona Kaplan has posted comments on this change.
Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options.
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13369
To u
Alona Kaplan has posted comments on this change.
Change subject: webadmin: add copy of migration property to NetworkCluster
cloner.
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
Alona Kaplan has posted comments on this change.
Change subject: engine: Extending migrate verb with an additional parameter-
"dstqemu"
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Alona Kaplan has posted comments on this change.
Change subject: engine: adding "migration" property to NetworkCluster
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12962
To uns
Alona Kaplan has posted comments on this change.
Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13369
To u
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/739/
Build Number: 739
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/3669/
Build Number: 3669
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: Fix brick validation during create volume
..
engine: Fix brick validation during create volume
while creating a volume, the bricks will be vali
Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix brick validation during create volume
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13239
To unsubs
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: Unit test cases for create gluster volume command
..
engine: Unit test cases for create gluster volume command
Unit test cases are added for cr
Shireesh Anjal has posted comments on this change.
Change subject: engine: Unit test cases for create gluster volume command
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13238
T
Daniel Erez has posted comments on this change.
Change subject: webadmin: error in custom properties sheet
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/
Laszlo Hornyak has posted comments on this change.
Change subject: core: Java7 Engine build
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13519
To unsubscribe, visit h
Michael Kublin has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 2:
"Vdsm doesn't have SPM and HSM command, all API does not depend on th
Alon Bar-Lev has posted comments on this change.
Change subject: core: Java7 Engine build
..
Patch Set 1: Looks good to me, but someone else must approve
I am for whatever makes us closer to java-1.7 :)
--
To view, visit http:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: 'for min' label width is too short
..
Patch Set 2: Verified
We can schedule a meeting to discuss the issues you've mentioned, anyway it
will be submit
Allon Mureinik has posted comments on this change.
Change subject: core: Java7 Engine build
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Hello Alissa Bonas,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13519
to review the following change.
Change subject: core: Java7 Engine build
..
core: Java7 Engine build
Since Java 6 is reachi
Yaniv Bronhaim has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
..
Patch Set 2:
Vdsm doesn't have SPM and HSM command, all API does not depend on the
1 - 100 of 227 matches
Mail list logo
