Daniel Erez has posted comments on this change.
Change subject: webadmin: error in custom properties sheet
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
Line 152: if (returnValue != null) {
Line 153: model.setCustomPropertiesKeysList(new
HashMap<Version, ArrayList<String>>());
Line 154: HashMap<Version, String> dictionary =
(HashMap<Version, String>) returnValue;
Line 155: for (Map.Entry<Version, String>
keyValuePair : dictionary.entrySet()) {
Line 156: String[] split =
keyValuePair.getValue().split("[;]", -1); //$NON-NLS-1$
* I've meant that you should add an OptionBehaviourAttribute annotation to the
relevant ConfigValue instead of splitting in the UI - can be done later on a
separate patch.
* Can you please extract the new duplicate code (splitting logic) -
PoolListModel and VmListModel
Line 157: if (split.length == 1 &&
(split[0] == null || split[0].isEmpty())) {
Line 158:
model.getCustomPropertiesKeysList().put(keyValuePair.getKey(),
Line 159: null);
Line 160: } else {
--
To view, visit http://gerrit.ovirt.org/13304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
