Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Adding Volume ID to volume general tab ......................................................................
webadmin: Adding Volume ID to volume general tab Volume ID field is added to volume's general subtab, it will display the UUID of the selected volume. Change-Id: If571171963d36669b436d24fced633b34afaaf81 Bug-Url: https://bugzilla.redhat.com/887806 Signed-off-by: Kanagaraj M <kmayi...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java 3 files changed, 20 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/13535/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java index 9019df9..4d2512e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java @@ -7,6 +7,7 @@ public class VolumeGeneralModel extends EntityModel { private String name; + private String volumeId; private String volumeType; private String replicaCount; private String stripeCount; @@ -20,6 +21,14 @@ public void setName(String name) { this.name = name; + } + + public String getVolumeId() { + return volumeId; + } + + public void setVolumeId(String volumeId) { + this.volumeId = volumeId; } public String getVolumeType() { @@ -92,6 +101,7 @@ } GlusterVolumeEntity entity = (GlusterVolumeEntity) getEntity(); setName(entity.getName()); + setVolumeId(entity.getId().toString()); setVolumeType(entity.getVolumeType().toString()); setReplicaCount(Integer.toString(entity.getReplicaCount())); setStripeCount(Integer.toString(entity.getStripeCount())); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java index 1a60cb0..6289649 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java @@ -2200,6 +2200,9 @@ @DefaultStringValue("Cluster") String clusterVolume(); + @DefaultStringValue("Volume ID") + String volumeIdVolume(); + @DefaultStringValue("Volume Type") String volumeTypeVolume(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java index 6a60e81..608141b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java @@ -40,6 +40,7 @@ GeneralFormPanel formPanel; TextBoxLabel name = new TextBoxLabel(); + TextBoxLabel volumeId = new TextBoxLabel(); TextBoxLabel volumeType = new TextBoxLabel(); TextBoxLabel replicaCount = new TextBoxLabel(); TextBoxLabel stripeCount = new TextBoxLabel(); @@ -66,17 +67,18 @@ driver.initialize(this); // Build a form using the FormBuilder - formBuilder = new FormBuilder(formPanel, 1, 4); + formBuilder = new FormBuilder(formPanel, 1, 5); formBuilder.addFormItem(new FormItem(constants.NameVolume(), name, 0, 0)); - formBuilder.addFormItem(new FormItem(constants.volumeTypeVolume(), volumeType, 1, 0)); + formBuilder.addFormItem(new FormItem(constants.volumeIdVolume(), volumeId, 1, 0)); + formBuilder.addFormItem(new FormItem(constants.volumeTypeVolume(), volumeType, 2, 0)); - replicaFormItem = new FormItem(constants.replicaCountVolume(), replicaCount, 2, 0); + replicaFormItem = new FormItem(constants.replicaCountVolume(), replicaCount, 3, 0); formBuilder.addFormItem(replicaFormItem); - stripeFormItem = new FormItem(constants.stripeCountVolume(), stripeCount, 2, 0); + stripeFormItem = new FormItem(constants.stripeCountVolume(), stripeCount, 3, 0); formBuilder.addFormItem(stripeFormItem); - formBuilder.addFormItem(new FormItem(constants.numberOfBricksVolume(), numOfBricks, 3, 0)); + formBuilder.addFormItem(new FormItem(constants.numberOfBricksVolume(), numOfBricks, 4, 0)); getDetailModel().getPropertyChangedEvent().addListener(new IEventListener() { -- To view, visit http://gerrit.ovirt.org/13535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If571171963d36669b436d24fced633b34afaaf81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
