Michael Kublin has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM ......................................................................
Patch Set 2: "Vdsm doesn't have SPM and HSM command, all API does not depend on the host's status. The api request for getAllTasksList needs to include the spUUID to retrieve SPM tasks (otherwise vdsm can't validate the spm status) And the way to pass more parameters to the request is by adding to VdsServerProxy.getAllTasksList. " - it is not related to what I said, we have two proxies in order to distinguish between SPM and HSM, that's why you also should divide it. "This solution is part of vdsm part and this patch adds the sp id to the request. It's not a workaround in engine side, its a change in the API for SPM requests to allow vdsm to do validation for spm status and handling the request for tasks in the same bit. " - I will be more clear, your wrote a code that look like a workaround. Please, distinguish between commands. "We don't want new API or validation in engine side, we want to keep the request as is, and if the spUUID is passed engine should get back exception if the host is not spm." - I did not understand what this means and to what remark it is related. Not answered question: why getAllTaskstatuses is used as HSM and SPM command in engine side -- To view, visit http://gerrit.ovirt.org/13450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
