Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: allow client to define the HTTP session TTL #921013
..
restapi: allow client to define the HTTP session TTL #921013
Session TTL can be expl
Michael Pasternak has posted comments on this change.
Change subject: restapi: allow client to define the HTTP session TTL #921013
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Michael Pasternak has posted comments on this change.
Change subject: restapi: allow client to define the HTTP session TTL #921013
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Shireesh Anjal has posted comments on this change.
Change subject: gluster: added cluster level check
..
Patch Set 5: (1 inline comment)
Response to Omer's comment in-line.
Sahina Bose has posted comments on this change.
Change subject: gluster: Added ports in gluster iptables config
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12974
To
Alon Bar-Lev has posted comments on this change.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
build: spec: gettext-devel is not required if gettext is embedded
Change-Id: I8df67
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
build: spec: gettext-devel is not required if gettext is embedded
Change-Id: I8df67f285dc15
Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: update .gitignore
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: update .gitignore
..
cleanup: update .gitignore
Change-Id: If42ce8d6e2106c529576aa6171a0f57364e14869
Signed-off-by: Alon Bar-Lev
---
M .gitignore
1 fil
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it externally
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it externally
Alon Bar-Lev has posted comments on this change.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
..
Patch Set 4:
http://gerrit.ovirt.org/#/c/13080/
--
To view, visit http://gerrit.ovirt.org/12719
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: Partial Revert "engine: unit test for
VdsDeploy.getEngineSSHPublicKey"
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13080
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: engine: VdsDeploy cleanup 1
..
Patch Set 3:
http://gerrit.ovirt.org/#/c/13079/
--
To view, visit http://gerrit.ovirt.org/12972
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: Revert "engine: VdsDeploy cleanup 1"
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13079
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has uploaded a new change for review.
Change subject: Revert "engine: VdsDeploy cleanup 1"
..
Revert "engine: VdsDeploy cleanup 1"
This reverts commit ee531b788e880e60cae87d82c3553239f2eb7778.
Change-Id: I1f964a047
Alon Bar-Lev has uploaded a new change for review.
Change subject: Partial Revert "engine: unit test for
VdsDeploy.getEngineSSHPublicKey"
..
Partial Revert "engine: unit test for VdsDeploy.getEngineSSHPublicKey"
This reverts co
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it externally
Alon Bar-Lev has posted comments on this change.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
..
Patch Set 4:
guys, how come you don't CC module owner? You cannot just go ahead and commit
stuff for som
Alon Bar-Lev has posted comments on this change.
Change subject: engine: VdsDeploy cleanup 1
..
Patch Set 3:
guys, how come you don't CC module owner? You cannot just go ahead and commit
stuff for something you don't own.
PLE
Alon Bar-Lev has posted comments on this change.
Change subject: engine: VdsDeploy cleanup 2
..
Patch Set 3:
guys, how come you don't CC module owner? You cannot just go ahead and commit
stuff for something you don't own.
--
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13077
To unsubscribe, visit http://gerr
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
Change-Id: I54f5a254a3a4669ab7f8b363fa81dbe0266f5cc7
Signed-off-by: Alon Bar-Lev
---
M .gitig
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
Change-Id: I54f5a254a3a4669ab7f8b363fa81dbe0266f5cc7
Signed-off-by: Alon Bar-Lev
---
M .gitignore
M M
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
build: spec: gettext-devel is not required if gettext is embedded
Change-Id: I8df67
Alon Bar-Lev has posted comments on this change.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: spec: gettext-devel is not required if gettext is
embedded
..
build: spec: gettext-devel is not required if gettext is embedded
Change-Id: I8df67f285dc15
Alexander Wels has posted comments on this change.
Change subject: webadmin: remove hide popup feature.
..
Patch Set 3: Verified
Rebase to latest patches.
--
To view, visit http://gerrit.ovirt.org/12023
To unsubscribe, visit h
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
packaging: post ovirt-host-deploy-1.0.1
Change-Id: I6c859e739bacdc7a8cb54f7cf057c576dfdc8734
Signed-off-by: Al
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13075
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13074
To unsubscribe, visit http
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
packaging: ovirt-host-deploy-1.0.1
Change-Id: I22b1df5505bfa6d3075bc3d52def7bb8cf2dc79a
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
The difference between environments is so large that
best to provide gettext within tarball.
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13073
To unsubscribe, visit http://gerr
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
packaging: post ovirt-host-deploy-1.0.1
Change-Id: I6c859e739bacdc7a8cb54f7cf057c576dfdc8734
Signed-off-by: Alon Bar-L
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
The difference between environments is so large that
best to provide gettext within tarball.
Change-I
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
packaging: ovirt-host-deploy-1.0.1
Change-Id: I22b1df5505bfa6d3075bc3d52def7bb8cf2dc79a
Signed-off-by: Alon Bar-Lev
---
M
Alexander Wels has posted comments on this change.
Change subject: webadmin: grids jump to last selected entity
..
Patch Set 2: Verified
Addressed the concerns of the previous patch.
--
To view, visit http://gerrit.ovirt.org/1
Einav Cohen has posted comments on this change.
Change subject: webadmin: remove hide popup feature.
..
Patch Set 2:
Alex - please rebase (to eliminate outdated dependency)
Vojtech - any reason for not giving this patch "+2"?
Alexander Wels has posted comments on this change.
Change subject: webadmin: grids jump to last selected entity
..
Patch Set 1: (2 inline comments)
File
frontend/webadmin/mo
Einav Cohen has posted comments on this change.
Change subject: core: provided cleared frontend logging
..
Patch Set 5:
Yair - patch is pending only on your re-review. thanks.
--
To view, visit http://gerrit.ovirt.org/12559
To
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 8:
Vojtech, no that statement actually was never relevant. I mistook the entities
that were ma
Alexander Wels has posted comments on this change.
Change subject: webadmin: Application continue polling after logout
..
Patch Set 7: (2 inline comments)
File
frontend/weba
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
The difference between environments is so large that
best to provide gettext within tarball.
Alon Bar-Lev has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13072
To unsubscribe, visit http://gerr
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use embedded gettext
..
build: use embedded gettext
The difference between environments is so large that
best to provide gettext within tarball.
Change-I
Alexander Wels has posted comments on this change.
Change subject: webadmin: enable gzip compression
..
Patch Set 9: Verified
Fixed merge conflict.
--
To view, visit http://gerrit.ovirt.org/10911
To unsubscribe, visit http://g
Einav Cohen has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2:
Vojtech/Alex - what do you think? Derez has raised an interesting point here:
The patches seem to do pretty m
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
packaging: post ovirt-host-deploy-1.0.1
Change-Id: I044a8741f29e4fadd3f79e4552b61e74fab2b6ad
Signed-off-by: Al
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13071
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13070
To unsubscribe, visit http
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
packaging: ovirt-host-deploy-1.0.1
Change-Id: I7b50425f76087c880f364779f538b05e93a45bd1
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: ovirt-host-deploy-1.0.1
..
packaging: ovirt-host-deploy-1.0.1
Change-Id: I7b50425f76087c880f364779f538b05e93a45bd1
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post ovirt-host-deploy-1.0.1
..
packaging: post ovirt-host-deploy-1.0.1
Change-Id: I044a8741f29e4fadd3f79e4552b61e74fab2b6ad
Signed-off-by: Alon Bar-L
Einav Cohen has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
..
Patch Set 4:
Thanks Vojtech.
Alona - would be great if you can re-review the updated patch. Thanks.
--
Einav Cohen has posted comments on this change.
Change subject: webadmin: enable gzip compression
..
Patch Set 8:
Alex: Due to some changes introduced by http://gerrit.ovirt.org/#/c/12411/, the
patch is not rebasing smoothly (
Federico Simoncelli has posted comments on this change.
Change subject: core: unify the GetAllImagesList queries
..
Patch Set 1:
> Should we call it GetImagesList instead of GetAllImagesList?
Yes, I'll take care of it.
--
To
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: pki: update environment documentation
..
doc: pki: update environment documentation
Change-Id: Id7c8fde4165ec85940d2f05ea53570f63813f011
Signed-off-
Alon Bar-Lev has posted comments on this change.
Change subject: doc: pki: update environment documentation
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13069
To unsubscribe, vi
Alon Bar-Lev has uploaded a new change for review.
Change subject: doc: pki: update environment documentation
..
doc: pki: update environment documentation
Change-Id: Id7c8fde4165ec85940d2f05ea53570f63813f011
Signed-off-by: Alon
Alon Bar-Lev has posted comments on this change.
Change subject: build: use older gettext-0.17
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13068
To unsubscribe, visit http://ge
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: use older gettext-0.17
..
build: use older gettext-0.17
For old rhel/centos hosts
Change-Id: I0c90c34450961e4388b760982ddc002cca040359
Signed-off
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use older gettext-0.17
..
build: use older gettext-0.17
For old rhel/centos hosts
Change-Id: I0c90c34450961e4388b760982ddc002cca040359
Signed-off-by: Alo
Ravi Nori has posted comments on this change.
Change subject: core: unify the GetAllImagesList queries
..
Patch Set 1: No score
Should we call it GetImagesList instead of GetAllImagesList?
--
To view, visit http://gerrit.ovirt
Ravi Nori has posted comments on this change.
Change subject: core: rename FileTypeExtension to ImageType
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13067
To unsubs
Ravi Nori has posted comments on this change.
Change subject: core: unify the GetAllImagesList queries
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13066
To unsubscri
Federico Simoncelli has uploaded a new change for review.
Change subject: core: rename FileTypeExtension to ImageType
..
core: rename FileTypeExtension to ImageType
Moving into the direction of supporting image storage domain th
Federico Simoncelli has uploaded a new change for review.
Change subject: core: unify the GetAllImagesList queries
..
core: unify the GetAllImagesList queries
This patch unifies and consolidates the queries to retrieve the list
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added checking DB state before upgrade
..
Patch Set 5: I would prefer that you didn't submit this
To make it clear, I put here -1.
The dba should mana
Liron Ar has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/bll/
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: use older gettext-0.17
..
build: use older gettext-0.17
For old rhel/centos hosts
Change-Id: I0c90c34450961e4388b760982ddc002cca040359
Signed-off
Alon Bar-Lev has posted comments on this change.
Change subject: build: use older gettext-0.17
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13065
To unsubscribe, visit http://ge
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: use older gettext-0.17
..
build: use older gettext-0.17
For old rhel/centos hosts
Change-Id: I0c90c34450961e4388b760982ddc002cca040359
Signed-off-by: Alo
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: VdsDeploy cleanup 2
..
engine: VdsDeploy cleanup 2
- Added type parameter to generic types to get rid of warning.
Change-Id: Ibfb00c823d42d3a7
Laszlo Hornyak has posted comments on this change.
Change subject: engine: VdsDeploy cleanup 2
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12973
To unsubscribe, visit http://ge
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: VdsDeploy cleanup 1
..
engine: VdsDeploy cleanup 1
- removed hunngarian notation from method names
Change-Id: I8aedeef3aa6a614881ad3a9b7dc46b9
Laszlo Hornyak has posted comments on this change.
Change subject: engine: VdsDeploy cleanup 1
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12972
To unsubscribe, visit http://ge
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: VmDynamic cleanup 1
..
engine: VmDynamic cleanup 1
- cleanup in fields, removed hungarian notation, and underscores
Change-Id: I9558be538ad585
Laszlo Hornyak has posted comments on this change.
Change subject: engine: VmDynamic cleanup 1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12975
To unsubscribe, visit http://ge
Alona Kaplan has uploaded a new change for review.
Change subject: engine: Extending migrate verb with an additional parameter-
"dstqemo"
..
engine: Extending migrate verb with an additional parameter- "dstqemo"
The dstqemo wil
Liron Ar has posted comments on this change.
Change subject: core: add the image block alignment scan
..
Patch Set 6: (5 inline comments)
File
backend/manager/modules/bll/sr
Keith Robertson has submitted this change and it was merged.
Change subject: Fixing format_ssh_command
..
Fixing format_ssh_command
format_ssh_command failed setting the Identity file
causing an error like no such file or direc
Keith Robertson has posted comments on this change.
Change subject: Fixing format_ssh_command
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13055
To unsubscribe, visit http://gerrit.ovirt.
Tomas Jelinek has posted comments on this change.
Change subject: tools: Setting ClientConsoleModeDefault
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13002
To unsubs
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 5:
Verify it and I'll push it.
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscrib
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Moti Asayag has posted comments on this change.
Change subject: engine: Added ValidationResult matchers
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13061
To unsubscr
Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 6: (16 inline comments)
File
backend/manager/module
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Added checking DB state before upgrade
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Show migrating VM on destination host
..
Patch Set 2: (2 inline comments)
File
frontend/webadmin/
Liron Ar has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
..
Patch Set 6: (2 inline comments)
File
backend/manager/modules/bll
Alona Kaplan has posted comments on this change.
Change subject: core: Added generic message that name is used
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12361
To u
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
..
engine: unit test for VdsDeploy.getEngineSSHPublicKey
- removed the _ prefix from method name
Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
..
Patch Set 4: Verified; Looks good to me, approved
thx
--
To view, visit http://gerrit.ovirt.org/12719
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Added ValidationResult matchers
..
engine: Added ValidationResult matchers
The matchers can be used for testing that validation result complies
with a g
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Network validator tests use assertThat
..
engine: Network validator tests use assertThat
Refactored the network validator's tests to use assertThat synt
1 - 100 of 335 matches
Mail list logo
