Liron Ar has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java
Line 29: }
Line 30:
Line 31: @Override
Line 32: protected Map<String, Pair<String, String>> getExclusiveLocks() {
Line 33: return
Collections.singletonMap(getStorageDomain().getId().toString(),
LockMessagesMatchUtil.STORAGE);
why lock the storage domain? if you want to lock anything (though not sure it's
even needed here) - it's the connection.
Line 34: }
Line 35:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 92: return isEditable;
Line 93: }
Line 94:
Line 95: @Override
Line 96: protected void executeCommand() {
just a reminder about the db lock for better user experience so we can see more
opinions about that
Line 97: //connect to the new path
Line 98: boolean hasConnectStorageSucceeded = connectToStorage();
Line 99:
Line 100: //update info such as free space - because we switched to a
different server
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
