Einav Cohen has posted comments on this change. Change subject: webadmin: load image refreshing data ......................................................................
Patch Set 2: Vojtech/Alex - what do you think? Derez has raised an interesting point here: The patches seem to do pretty much the same, just with a different implementation/design: [I could be wrong with everything that I have written below, as I am not familiar with the exact technical details - please correct me if I am wrong] (1) in this patch, the loading-progress is represented by the "squares"-animation which is triggered on the relevant tab-related events (onReveal, onRefresh/ManualRefresh, etc.). (2) in http://gerrit.ovirt.org/#/c/7493/, the loading-progress is represented by "a small text box shown in top center of the screen" which is triggered by the "LockInteraction" event, fired when "the application is transitioning from one place to another". IIUC, in (2), the loading-text-box will show up upon any transitioning event in the application. It just so happens that today, the only transitioning events that we have in the applications are ones that are associated with moving between tabs... One difference that I can think of between (1) and (2) [and I could be wrong] is that upon manual refresh, the loading-indication in (1) will be triggered, but not the loading-indication in (2). Also: I expect the loading-text-box (2) to potentially appear in more places (e.g. clicking on a button that doesn't open a dialog, or, in general, any call that will involve a call to the server) - it is a more "generic" indication than the animated-squares (which were designed to fit only in the tabs/sub-tabs context). Having said that: Although theoretically the loading-text-box (2) can be a sufficient indication for moving between tabs, I think that the animated-squares are a really nice addition to it, and I prefer to have it in, rather than just showing a blank grid during loading. So I agree with Derez on this one - we should probably consider both patches to be eventually introduced. Thoughts/Comments are welcome. -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8be80df57eafc4244c57029f8260d4d67c47b3f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
