Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1180
Selvasundaram has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 8:
Entity & SQLs are Modified
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visit http://gerrit.o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: notifier: resource leak using all available db connections
..
notifier: resource leak using all available db connections
Only initialize the data sourc
Yair Zaslavsky has posted comments on this change.
Change subject: notifier: resource leak using all available db connections
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11555
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 2:
Alon,
There are conflicts every time I try to rebase,
This is something that I think the patch se
Yair Zaslavsky has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11558
To unsubscribe, visit
Aravinda VK has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 1: (1 inline comment)
Updated cherry-pick message.
..
Federico Simoncelli has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 1: (5 inline comments)
File
Moti Asayag has posted comments on this change.
Change subject: engine: Add validator for NetworkCluster
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/
Moti Asayag has posted comments on this change.
Change subject: engine: Fix ValidationResult
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11834
To unsubscribe, visit http://gerrit.ovirt.o
Moti Asayag has posted comments on this change.
Change subject: engine: Improved error message when unassigning network used by
VMs
..
Patch Set 1: (3 inline comments)
File
Moti Asayag has posted comments on this change.
Change subject: engine: Added NetworkHelper class
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/bll/src/ma
Tal Nisan has posted comments on this change.
Change subject: core: Removed the ResXResourceReader class
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/dal/
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
engine: Empty SetupNetworksCommand isn't sent to VDSM
Changed the SetupNetworksCommand so that if
Moti Asayag has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11750
To unsubscribe, vi
Maor Lipchuk has posted comments on this change.
Change subject: core: Removed the ResXResourceReader class
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/d
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fix import gluster hosts popup layout
..
webadmin: Fix import gluster hosts popup layout
When the hostname is too big, the table width
goes outside of t
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Hide host virt details in gluster mode
..
webadmin: Hide host virt details in gluster mode
When the application is running in gluster only mode,
Virtuli
Lior Vernia has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11750
To unsubscribe, visit http://gerrit.
Lior Vernia has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
Patch Set 1: (1 inline comment)
File
backend/manager
Eli Mesika has posted comments on this change.
Change subject: core:Cannot add external event if flood rate is...
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11847
To unsubscribe, visit http://gerrit.ovir
Eli Mesika has posted comments on this change.
Change subject: core: Custom Materialized Views should be...
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11669
To unsubscribe, visit http://gerrit.ovirt.org
Moti Asayag has posted comments on this change.
Change subject: core: Remove Mac Addresses When DC Removed
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bl
Greg Padgett has posted comments on this change.
Change subject: tools, backend: better error logging for notifier
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11554
Keith Robertson has submitted this change and it was merged.
Change subject: packaging: Updated fetching db params from pgpass
..
packaging: Updated fetching db params from pgpass
Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11826
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (1 inline comment)
File
backend/man
Tal Nisan has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 1: (1 inline comment)
File
backend/m
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2: (1 inline comment)
File src/__main__.py
Line
Chris Morrissey has posted comments on this change.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
Patch Set 1: (7 inline comments)
Added responses to inline comments. Working on next patch set
Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (1 inline comment)
File
backend/m
Maor Lipchuk has restored this change.
Change subject: core: Add storage space validation to removeSnapshot
..
Patch Set 2: Restored
fixed
--
To view, visit http://gerrit.ovirt.org/11849
To unsubscribe, visit http://gerrit.ovi
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2:
OK, I missed the "encrypted" nuance.
In any case, I'm fine with this patch so long as Alouri
Maor Lipchuk has abandoned this change.
Change subject: core: Add storage space validation to removeSnapshot
..
Patch Set 2: Abandoned
Adding a fix I just saw.
--
To view, visit http://gerrit.ovirt.org/11849
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2:
Much to solve, I am fighting the important wars first...
--
To view, visit http://gerrit.ovirt.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2:
I know, this is why I wrote "encrypted" with quotes.
--
To view, visit http://gerrit.ovirt.org/
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2:
Alon,
I am glad to hear that we are changing. However, I would like to point out
that we ar
Mike Kolesnik has posted comments on this change.
Change subject: core: Remove Mac Addresses When DC Removed
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2:
You are correct, we recently discussed that, I don't like the pgpass usage as
well.
But it sho
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add storage space validation to removeSnapshot
..
core: Add storage space validation to removeSnapshot
Today there is not validation in RemoveSnapshotComma
Omer Frenkel has posted comments on this change.
Change subject: webdmin: Restrict destination host parameter for administrator
only
..
Patch Set 2:
looks good, but i am not sure if this should be in this command or in
RunVmC
Keith Robertson has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2: (1 inline comment)
IMO, the use of .pgpass by oVirt is completely wrongheaded and is the sour
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (1 inline comment)
File
backend/man
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: added branded tab icon
..
reports: added branded tab icon
Change-Id: Ib6596a6bb244529c199de831851566e66b640b14
Signed-off-by: Yaniv Dary
---
A se
Yaniv Dary has posted comments on this change.
Change subject: reports: added branded tab icon
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11848
To unsubscribe, visit http://ge
Yaniv Dary has uploaded a new change for review.
Change subject: reports: added branded tab icon
..
reports: added branded tab icon
Change-Id: Ib6596a6bb244529c199de831851566e66b640b14
Signed-off-by: Yaniv Dary
---
A server-cus
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (1 inline comment)
File
backend/man
Ravi Nori has posted comments on this change.
Change subject: restapi : Add Role with wrong permit id leads to 500
error(#908392)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11824
To unsubscribe, visit h
Eli Mesika has uploaded a new change for review.
Change subject: core:Cannot add external event if flood rate is...
..
core:Cannot add external event if flood rate is...
Cannot add external event if flood rate is not passed expl
Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (1 inline comment)
File
backend/m
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
..
Patch Set 7: (3 inline comments)
File
backend/manage
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
..
Patch Set 6: (4 inline comments)
File
backend/manage
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 2:
Someone can merge this? without any bureaucracy... just merge.
--
To view, visit http://gerrit.ovi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
..
Patch Set 2: (1 inline comment)
File src/__main__.py
Lin
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 2: (6 inline comments)
File
backend/ma
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow importing existing ISO domain on setup
..
Patch Set 4: Verified
Rebased, verified.
--
To view, visit http://gerrit.ovirt.org/11556
To unsubs
Ravi Nori has posted comments on this change.
Change subject: restapi : Add Role with wrong permit id leads to 500
error(#908392)
..
Patch Set 1: No score
org.ovirt.engine.api.restapi.resource.validation.PermitValidator alread
Michael Pasternak has posted comments on this change.
Change subject: restapi : Multiple events in the UI about logged in user.
..
Patch Set 1: Do not submit
(1 inline comment)
in this scenario login should be always validated
Michael Pasternak has posted comments on this change.
Change subject: restapi : version values for hosts are wrong for libvirt
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
.
Michael Pasternak has posted comments on this change.
Change subject: restapi : Add Role with wrong permit id leads to 500
error(#908392)
..
Patch Set 1:
i can't see any code adding "X is not a valid permit ID.",
did you forgo
Bala.FA has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 1: (1 inline comment)
File packaging/fedora/setup/bas
Laszlo Hornyak has abandoned this change.
Change subject: Send http 400 when mapping error
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/11059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10:
what's next with this patch?
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: cleanup Vds
..
Patch Set 4: Verified
RemoveBondCommand undeleted
--
To view, visit http://gerrit.ovirt.org/11351
To unsubscribe, visit http://gerrit.ov
Moti Asayag has submitted this change and it was merged.
Change subject: engine: slave interfaces are being overridden
..
engine: slave interfaces are being overridden
When the client provides a bond with its slaves, the slaves
Moti Asayag has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe,
Mike Kolesnik has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit ht
Moti Asayag has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has submitted this change and it was merged.
Change subject: core: align luns volume_group_id
..
core: align luns volume_group_id
LUNs that were previously persisted using REST might have a null volume group id
w
Allon Mureinik has posted comments on this change.
Change subject: core: align luns volume_group_id
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11807
To unsubscribe, visit http://gerrit.
Muli Salem has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 6: Looks good to me, approved
(1 inline comment)
Other than the minor comment - +2.
...
Liron Aravot has posted comments on this change.
Change subject: core: align luns volume_group_id
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Arik Hadas has posted comments on this change.
Change subject: webadmin: fix typo in ExistingPoolNameLengthValidationTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11844
To unsubscribe, visit http://ger
Arik Hadas has posted comments on this change.
Change subject: webadmin: making RegexValidation testable
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11843
To unsubscribe, visit http://gerrit.ovirt.org/set
Michael Pasternak has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11671
Moti Asayag has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/11671
To unsubscribe, visit http://gerrit.ovirt.or
Daniel Erez has submitted this change and it was merged.
Change subject: core,ui: fix test duplicate keys
..
core,ui: fix test duplicate keys
Fix path of DuplicateKeysTest so it will work properly in
Windows environment too.
C
Daniel Erez has posted comments on this change.
Change subject: core,ui: fix test duplicate keys
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11842
To unsubscribe, visit http://
Daniel Erez has posted comments on this change.
Change subject: core,ui: fix test duplicate keys
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11842
To unsubscribe, visit http://gerrit.ovi
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: fix typo in ExistingPoolNameLengthValidationTest
..
webadmin: fix typo in ExistingPoolNameLengthValidationTest
The method getPoolName_noVmsAlloved was re
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: making RegexValidation testable
..
webadmin: making RegexValidation testable
This patch change the call to Regex#IsMatch(String,String,RegexOptions)
with
Alissa Bonas has posted comments on this change.
Change subject: core,ui: fix test duplicate keys
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alissa Bonas has uploaded a new change for review.
Change subject: core,ui: fix test duplicate keys
..
core,ui: fix test duplicate keys
Fix path of DuplicateKeysTest so it will work properly in
Windows environment too.
Change-I
Daniel Erez has submitted this change and it was merged.
Change subject: core: MoveDisksCommands - disk id for perm subject
..
core: MoveDisksCommands - disk id for perm subject
Passing diskId instead of imageId for permission
Daniel Erez has posted comments on this change.
Change subject: core: MoveDisksCommands - disk id for perm subject
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/11838
To
Allon Mureinik has posted comments on this change.
Change subject: core: Custom Materialized Views should be...
..
Patch Set 5: Looks good to me, but someone else must approve
(2 inline comments)
See inline
.
Allon Mureinik has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11558
T
Allon Mureinik has posted comments on this change.
Change subject: core: MoveDisksCommands - disk id for perm subject
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11838
To unsubscribe, vi
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 1: (1 inline comment)
Commit Message
Line 23
Laszlo Hornyak has abandoned this change.
Change subject: engine: cleanup Vds
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/11841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Alex Lourie has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
..
Patch Set 7: Verified
Rebased and verified.
--
To view, visit http://gerrit.ovirt.or
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
..
Patch Set 6: (1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 1:
In the past we had definitions of modules that replaced the definitions of the
same modules incl
Sahina Bose has uploaded a new change for review.
Change subject: engine: Support for gluster asynchronous tasks(WIP)
..
engine: Support for gluster asynchronous tasks(WIP)
Gluster commands like rebalance volume, replace bricks
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
core: Remove VdcActionParameterBase.httpSessionId
httpSessionId in VdcActionParameterBase is a pri
Allon Mureinik has posted comments on this change.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
+2 by Michael, +1 by Tal and Ma
Allon Mureinik has posted comments on this change.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
Patch Set 1: (1 inline comment)
File
backend/manager/
Laszlo Hornyak has posted comments on this change.
Change subject: engine: cleanup Vds
..
Patch Set 3:
well, the removal of RemoveBondCommand is accidental, but what is using it?
git grep RemoveBondCommand returns nothing
--
T
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Hooks - conflict resolution popup
..
webadmin: Gluster Hooks - conflict resolution popup
New Action 'Resolve Conflicts' is added to gluster hook
1 - 100 of 170 matches
Mail list logo
