Mike Kolesnik has posted comments on this change.
Change subject: core: Remove Mac Addresses When DC Removed
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 84:
Line 85: getStoragePoolDAO().remove(getStoragePool().getId());
Line 86: setSucceeded(true);
Line 87:
Line 88: if (macsToRemove != null && !macsToRemove.isEmpty()) {
I don't see what's the point..
The list won't be null since the DAO guarantees that.
The list might be empty, in that case no mac will be freed anyway but the
method accepts that
Line 89: MacPoolManager.getInstance().freeMacs(macsToRemove);
Line 90: }
Line 91: }
Line 92:
--
To view, visit http://gerrit.ovirt.org/11796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6d473b4921de12fbd68bdaf2fc058662ed3a06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
