Alon Bar-Lev has posted comments on this change. Change subject: packaging: Updated fetching db params from pgpass ......................................................................
Patch Set 2: You are correct, we recently discussed that, I don't like the pgpass usage as well. But it should not be in the engine sysconf as well, due to world readable file, there we store "encrypted" password. We need a different file at /etc/ovirt-engine to hold database credentials, I hope we can make it to 3.3. But for now, in order to support older engines we should do <something>. -- To view, visit http://gerrit.ovirt.org/11826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab80e36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
