Tal Nisan has posted comments on this change. Change subject: core: Removed the ResXResourceReader class ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java Line 723: AuditLogType type = AuditLogType.valueOf(message.getKey()); Line 724: if (!mMessages.containsKey(type)) { Line 725: mMessages.put(type, message.getValue()); Line 726: } else { Line 727: log.errorFormat("The type {0} appears more then once in audit log messages bundle with the values '{0}' and '{1}'", Yeah, should be {1} and {2}, good catch thanks, probably never worked before Line 728: mMessages.get(type), Line 729: message.getValue()); Line 730: } Line 731: } catch (Exception e) { -- To view, visit http://gerrit.ovirt.org/11827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches