Allon Mureinik has posted comments on this change.
Change subject: core: Remove checkVmDown from PerformImagesChecks
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11018
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: MoveVm vmDown validation
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11017
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: ExportVm vmDown validation
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11016
To unsubscribe, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: TrybackToAllSnapshots vmDown validation
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11015
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11014
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Consolidate VM down check when removing disk
..
Patch Set 5: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11013
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 5: Verified
Rebased, fixed according to Tal's review.
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveDiskCommand lazy getters
..
Patch Set 3: Verified
Rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/11162
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 5: Verified
Rebased, no code changes.
Answered both of Tal's comments on the previous patch - both are
Allon Mureinik has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 4: (1 inline comment)
Re inline comment - will fix.
Re vm not down test - added in the next pat
Allon Mureinik has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 4: (2 inline comments)
File
backend/manager/modul
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-config: Adding man page
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11176
To unsubscribe, visit http://gerrit.ovirt.or
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine-config: Adding man page
..
engine-config: Adding man page
Adding engine-config.8
Change-Id: I546d90550ddf53707bc667c18e8c0d44e909593f
Bug-U
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-manage-domains: Adding man page
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11175
To unsubscribe, visit http://gerrit.
Einav Cohen has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
Patch Set 1:
[Alon/Gilad - your feedback is needed here]
[Alex - please hold off any changes to this
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine-manage-domains: Adding man page
..
engine-manage-domains: Adding man page
Adding engine-manage-domains.8
Change-Id: I26e69ce1410ce1ffd0c8ce
Einav Cohen has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
Patch Set 1: (1 inline comment)
File
frontend/weba
Alexander Wels has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
Patch Set 1: (1 inline comment)
File
frontend/w
Einav Cohen has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
Patch Set 1: (1 inline comment)
File
frontend/weba
Alexander Wels has posted comments on this change.
Change subject: restapi: default version to 'general'
..
Patch Set 3: Verified
remove the 'unrelated' changes.
--
To view, visit http://gerrit.ovirt.org/11173
To unsubscribe,
Alexander Wels has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11174
To unsubscribe, visit http://ge
Alexander Wels has uploaded a new change for review.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
..
webadmin: Use ConfigCommon version in AsyncDataProvider
- Cleaned up code to use the configuration v
Einav Cohen has posted comments on this change.
Change subject: restapi: default version to 'general'
..
Patch Set 2:
Alex, please separate the GetConfigurationValueParameters.java and
GetConfigurationValueParametersTest.java
Alexander Wels has posted comments on this change.
Change subject: restapi: default version to 'general'
..
Patch Set 2: Verified
Updated code to match what the real intent of this patch was.
--
To view, visit http://gerrit.ov
Vojtech Szocs has submitted this change and it was merged.
Change subject: Introducing ShellBox UI plugin
..
Introducing ShellBox UI plugin
ShellBox UI plugin - provides SSH connection to a host using
shellinabox - a Web based
Vojtech Szocs has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
..
Patch Set 1: Verified
We can merge this patch now and update the UI plugin later on.
Again, thanks for submitting this UI plug
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't change identity if no ENGINE_USER
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11161
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add install_devel target
..
Patch Set 4: (3 inline comments)
File backend/manager/conf/engine.conf
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Change to / before starting upgrade
..
Patch Set 1: Looks good to me, but someone else must approve
engine-cleanup as well?
--
To view, visit http://g
Kanagaraj M has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 5:
Also add the new entities to Common.gwt.xml
--
To view, visit http://gerrit.ovirt.org/10650
To unsubscribe, visit
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Fetch brick statuses only for UP volumes
..
Patch Set 1:
Thanks Kanagaraj, will send another patch-set incorporating your suggestion.
--
To view, visi
Shireesh Anjal has uploaded a new change for review.
Change subject: gluster: Wrapper method for updating volume status
..
gluster: Wrapper method for updating volume status
Introduced a new wrapper method GlusterUtils#updateVol
Kanagaraj M has posted comments on this change.
Change subject: engine: Get gluster hooks query
..
Patch Set 5: (4 inline comments)
File
backend/manager/modules/common/src/m
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Export ENGINE_DEFAULTS and ENGINE_VARS
..
packaging: Export ENGINE_DEFAULTS and ENGINE_VARS
The start scripts for the engine and for the too
Vojtech Szocs has posted comments on this change.
Change subject: engine: Define the right GWT version in root pom
..
Patch Set 1:
Maybe we can also remove "gwt.version" property in UserPortal, WebAdmin,
GwtCommon and GwtExten
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't change identity if no ENGINE_USER
..
Patch Set 1:
I don't do things for fun.
The engineUid and engineGid are needed because they are used to c
Vojtech Szocs has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 1:
Hi, I just noticed UserPortal and WebAdmin pom.xml defines its own GWT Maven
plugin version, i
Juan Hernandez has posted comments on this change.
Change subject: packaging: Export ENGINE_DEFAULTS and ENGINE_VARS
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11160
To unsubscribe, vis
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't change identity if no ENGINE_USER
..
Patch Set 3: Verified
Change the identity of the process only if it is different to the current
identity.
Kanagaraj M has posted comments on this change.
Change subject: gluster: Wrapper method for updating volume status
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11167
Juan Hernandez has posted comments on this change.
Change subject: packaging: Add install_devel target
..
Patch Set 4: (3 inline comments)
File backend/manager/conf/engine.co
Tal Nisan has posted comments on this change.
Change subject: core: VM is down check when adding template
..
Patch Set 4: Looks good to me, approved
(2 inline comments)
File
Vojtech Szocs has posted comments on this change.
Change subject: engine: Define the right GWT version in root pom
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10243
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
..
Patch Set 4: (1 inline comment)
In addition it might be a good idea to add a VM not down test
Vojtech Szocs has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 1:
The above comments are just ideas that we can do now or later, the patch looks
good to me.
--
Vojtech Szocs has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 1:
Another idea, since root pom.xml defines GWT Maven plugin version within
section, maybe we ca
Vojtech Szocs has posted comments on this change.
Change subject: engine: Switched to the official GWT maven plugin
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10247
To unsubscribe, visi
Kanagaraj M has posted comments on this change.
Change subject: gluster: Fetch brick statuses only for UP volumes
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11156
T
Vojtech Szocs has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
..
Patch Set 1: Looks good to me, approved
(2 inline comments)
Great plugin, nice and simple.
Thanks for contributing this UI pl
Alissa Bonas has posted comments on this change.
Change subject: engine: VmDeviceUtils cleanup 2
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11158
To unsubscribe, vi
Tal Nisan has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11014
To unsubscribe, visit http://gerrit
Itamar Heim has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
..
Patch Set 1:
this shouldn't prevent pushing this, but i think each UI plugin should come
with an RPM to make its deployment triv
Aravinda VK has posted comments on this change.
Change subject: packaging: Application Mode option in installer
..
Patch Set 8:
Updated logic to hide the non gluster related questions from user when gluster
APPLICATION_MODE is
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Fetch brick statuses only for UP volumes
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/11156
To unsubscribe, visit http://gerrit.o
Itamar Heim has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
..
Patch Set 1:
while at it, why only for hosts and not for guests as well (at least linux
ones, if their IP is known)?
--
To view
Juan Hernandez has uploaded a new change for review.
Change subject: webadmin, restapi: Don't require path tweak in Eclipse
..
webadmin, restapi: Don't require path tweak in Eclipse
Currently we need to do some adjustments to th
Shireesh Anjal has uploaded a new change for review.
Change subject: gluster: Modify calls to fnSplitterUuid
..
gluster: Modify calls to fnSplitterUuid
Patch http://gerrit.ovirt.org/9825 changed the definition of the SP
fnSplitt
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Wrapper method for updating volume status
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11167
To unsubscribe, visit http://gerrit.
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Modify calls to fnSplitterUuid
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11169
To unsubscribe, visit http://gerrit.ovirt.org/s
Alexander Wels has posted comments on this change.
Change subject: restapi: default version to 'general'
..
Patch Set 1: Verified
Made sure that GetConfigurationValueParameters version will never be null, if
it would be null,
Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
..
Patch Set 8: (1 inline comment)
File
backend/man
Juan Hernandez has posted comments on this change.
Change subject: webadmin, restapi: Don't require path tweak in Eclipse
..
Patch Set 1: Verified
Verified with the version of Eclipse inside Fedora 18. Need to verify with
Ecli
Alexander Wels has uploaded a new change for review.
Change subject: restapi: default version to 'general'
..
restapi: default version to 'general'
- Fixed warning where a restapi call would not send
a version into GetConfigurat
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Change to / before starting upgrade
..
packaging: Change to / before starting upgrade
If the upgrade runs for a directory that is deleted by the upg
Shireesh Anjal has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 3: (1 inline comment)
File
backend/manager/module
65 matches
Mail list logo
