Einav Cohen has posted comments on this change. Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider ......................................................................
Patch Set 1: [Alon/Gilad - your feedback is needed here] [Alex - please hold off any changes to this patch until feedback from Alon/Gilad is received] I didn't look into the details very thoroughly, but it seems that the GetDefaultConfigurationVersion Query (added in http://gerrit.ovirt.org/#/c/10330/ and changed in http://gerrit.ovirt.org/#/c/10263/) is there on purpose, although at first sight - it seems like this query is not needed (since it returns "ConfigCommon.defaultConfigurationVersion" which is accessible to both client and core)? [1] If so - then I guess that the getDefaultConfigurationValue() method in AsyncDataProvider which, in my last inline comment, I instructed Alex to remove (or at least alter to not include the call to the core's GetDefaultConfigurationVersion query) should actually remain intact (i.e. the call to the core's GetDefaultConfigurationVersion query should not be removed)? If you have any additional feedback/info to provide - please share. thanks. [1] IIUC, all of this was done as part of a general effort to decouple the backend/frontend? -- To view, visit http://gerrit.ovirt.org/11174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9213aee9182d3bb27fbba04f7163b502438a3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
