Alexander Wels has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 154: Frontend.RunQuery(VdcQueryType.GetDefaultConfigurationVersion,
Line 155: new VdcQueryParametersBase(),
Line 156: callback);
Line 157: }
Line 158:
I tried that, and then realized that there were other side effects (From some
event presumably) that initialized other things as well. When I removed this,
those side effects did not happen and some values were left uninitialized and I
was unable to log in.
Line 159: public static void initCache(LoginModel loginModel) {
Line 160: AsyncDataProvider.CacheConfigValues(new
AsyncQuery(loginModel, new INewAsyncCallback() {
Line 161: @Override
Line 162: public void OnSuccess(Object target, Object returnValue) {
--
To view, visit http://gerrit.ovirt.org/11174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9213aee9182d3bb27fbba04f7163b502438a3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
