Alon Bar-Lev has posted comments on this change. Change subject: packaging: Add install_devel target ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/conf/engine.conf.devel Line 8: # group (values are empty on purpose, that means that the service script Line 9: # will not change the identity before starting the engine): Line 10: # Line 11: ENGINE_USER= Line 12: ENGINE_GROUP= Yes... but why the default will not be empty and when we install service we add override with user that packaging use? Line 13: Line 14: # Line 15: # Adjust the service so that it will disable the proxy and enable the Line 16: # HTTP connector instead: Line 18: ENGINE_PROXY_ENABLED=false Line 19: ENGINE_HTTP_ENABLED=true Line 20: ENGINE_HTTP_PORT=8700 Line 21: ENGINE_HTTPS_ENABLED=false Line 22: ENGINE_AJP_ENABLED=false OK... first change the default then apply this one? :) Line 23: Line 24: # Line 25: # Connect to the database with the postgres user and with no password Line 26: # (this is how we tell developers to connect to the database in our Line 26: # (this is how we tell developers to connect to the database in our Line 27: # build instructions): Line 28: # Line 29: ENGINE_DB_USER=postgres Line 30: ENGINE_DB_PASSWORD= Developer tests his code without database password, all works fine! He commits the code only to find out that in real setup his code fails... So I learn that better to have some password in development so that this trivial errors will not happen. Line 31: Line 32: # Line 33: # Enable remote debugging in all IP addresses and port 8787: Line 34: # -- To view, visit http://gerrit.ovirt.org/10984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I726af2b57b302750db4390dc5859a8ba36e59a2e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
