[Engine-patches] Change in ovirt-engine[master]: userportal: VM/Pool handling refactored

2013-01-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: VM/Pool handling refactored .. Patch Set 1: Looks good to me, approved http://gerrit.ovirt.org/#/c/10740/1 :) -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Fixing case issue with white list table

2013-01-07 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: Fixing case issue with white list table .. Patch Set 1: Abandoned Not needed anymore -- To view, visit http://gerrit.ovirt.org/8545 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: restapi: adding host specifying cluster by-name is not suppo...

2013-01-07 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: adding host specifying cluster by-name is not supported(#890329) .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) ..

[Engine-patches] Change in ovirt-engine[master]: engine: Add validations for removing a network

2013-01-07 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Add validations for removing a network .. engine: Add validations for removing a network The patch adds several validations for removing a network: 1. Pre

[Engine-patches] Change in ovirt-engine[master]: core: Add validation for locked template

2013-01-07 Thread vvolansk
Vered Volansky has posted comments on this change. Change subject: core: Add validation for locked template .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9070 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: When there is no post upgrade files the ...

2013-01-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: When there is no post upgrade files the ... .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10598 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade

2013-01-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: DB 3.0 to 3.1 upgrade .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/upgrade/03_0

[Engine-patches] Change in ovirt-engine[master]: userportal: pull-up syncSearch in basic and advanced view

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal: pull-up syncSearch in basic and advanced view .. Patch Set 1: Looks good to me, approved Good cleanup, but I've just realized I did the same thing (p

[Engine-patches] Change in ovirt-engine[master]: engine, userportal: Move pool filter logic to GetAllVmsAndVmP...

2013-01-07 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: engine,userportal: Move pool filter logic to GetAllVmsAndVmPoolsQuery .. engine,userportal: Move pool filter logic to GetAllVmsAndVmPoolsQuery Filter logic for

[Engine-patches] Change in ovirt-engine[master]: userportal: VM/Pool handling refactored

2013-01-07 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: userportal: VM/Pool handling refactored .. userportal: VM/Pool handling refactored 1. Removed IVmPoolResolutionService interface and its usage, as the 'Resol

[Engine-patches] Change in ovirt-engine[master]: core: DB - Snapshot Materialized Views support

2013-01-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: DB - Snapshot Materialized Views support .. Patch Set 5: Adding column avg_cost_ms that tracks the average cost of a refresh per materialized view in [ms] -

[Engine-patches] Change in ovirt-engine[master]: engine: remove Config dependency from frontend

2013-01-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: remove Config dependency from frontend .. Patch Set 2: hi Daniel, are you sure you don't want a special data struct that will hold both default config a

[Engine-patches] Change in ovirt-engine[master]: core: TarTest - assume Unix OS

2013-01-07 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: core: TarTest - assume Unix OS .. core: TarTest - assume Unix OS TarTest requires tar utility. Therefore, ignoring test for non-Unix machines. Change-Id: I1c80cb

[Engine-patches] Change in ovirt-engine[master]: engine: consolidate VM and Poll queries

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: consolidate VM and Poll queries .. Patch Set 4: Verified; Looks good to me, but someone else must approve +1 for the frontend (UiCommon) part -- To view

[Engine-patches] Change in ovirt-engine[master]: core: Alert for deprecated NFS mount options in vdsm.conf

2013-01-07 Thread gpadgett
Greg Padgett has abandoned this change. Change subject: core: Alert for deprecated NFS mount options in vdsm.conf .. Patch Set 5: Abandoned VDSM-side patch (http://gerrit.ovirt.org/8979) abandoned, no agreement on adding these

[Engine-patches] Change in ovirt-engine[master]: engine: consolidate VM and Poll queries

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: consolidate VM and Poll queries .. Patch Set 4: Just a comment to Liron's question in patch set 1: > basically the intention seems to save a backend cal

[Engine-patches] Change in ovirt-engine[master]: engine: Allow updating network if not used by hosts

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Allow updating network if not used by hosts .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10686 To unsubs

[Engine-patches] Change in ovirt-engine[master]: engine: Allow updating network if not used by hosts

2013-01-07 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow updating network if not used by hosts .. engine: Allow updating network if not used by hosts The requirement for updating network only if no

[Engine-patches] Change in ovirt-engine[master]: webadmin: double click invokes default command

2013-01-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: double click invokes default command .. Patch Set 2: Verified; Looks good to me, but someone else must approve Added double click handler to trees as

[Engine-patches] Change in ovirt-engine[master]: core: VM and VDS implement Nameable

2013-01-07 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: core: VM and VDS implement Nameable .. core: VM and VDS implement Nameable VM and VDS implements Nameable so they could be referred by the Nameable.getNam

[Engine-patches] Change in ovirt-engine[master]: core: VM and VDS implement Nameable

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: VM and VDS implement Nameable .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10724 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: engine: Add ReplacementUtils .. engine: Add ReplacementUtils Add a utility class for replacing a property within a message that represents a collection of

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add ReplacementUtils .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10723 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add ReplacementUtils .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/10723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3177 - Fixed!

2013-01-07 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3177/ Build Number: 3177 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,876 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: optimizing view for FF17 .. webadmin: optimizing view for FF17 The "This Browser version isn't optimal" will not be displayed for Firefox 17 on

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: optimizing view for FF17 .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10734 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Allow updating network if not used by hosts

2013-01-07 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Allow updating network if not used by hosts .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10686 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Add ReplacementUtils .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10723 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: remove Config dependency from frontend

2013-01-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: engine: remove Config dependency from frontend .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10330 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: webadmin: escape during dialog loading causes problems.

2013-01-07 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: escape during dialog loading causes problems. .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: escape during dialog loading causes problems.

2013-01-07 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: webadmin: escape during dialog loading causes problems. .. webadmin: escape during dialog loading causes problems. - Added prevent default to escape handler to

[Engine-patches] Change in ovirt-engine[master]: packaging: engine-setup - add firewalld support

2013-01-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: engine-setup - add firewalld support .. Patch Set 6: (5 inline comments) File packaging/fedora/set

[Engine-patches] Change in ovirt-engine[master]: core: minor cleanup in ObjectIdentityChecker

2013-01-07 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: minor cleanup in ObjectIdentityChecker .. core: minor cleanup in ObjectIdentityChecker - Change the type of ObjectIdentityChecker#mPermitted from List to Set

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3176 - Failure!

2013-01-07 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3176/ Build Number: 3176 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,875 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade

2013-01-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: DB 3.0 to 3.1 upgrade .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/upgrade/03_01_09

[Engine-patches] Change in ovirt-engine[master]: core: rerun HA vm that fails during live snapshot

2013-01-07 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: rerun HA vm that fails during live snapshot .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/10618 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Fix Max num of Cpus for 3.0

2013-01-07 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix Max num of Cpus for 3.0 .. core: Fix Max num of Cpus for 3.0 Should be 64, not 160 Change-Id: Ideade9e523016b4866e5cfa99f919378f48ded31 Sign

[Engine-patches] Change in ovirt-engine[master]: core: Fix Max num of Cpus for 3.0

2013-01-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix Max num of Cpus for 3.0 .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10535 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core:Can not upgrade from 3.1 to 3.2

2013-01-07 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core:Can not upgrade from 3.1 to 3.2 .. core:Can not upgrade from 3.1 to 3.2 This patch fix a bug that resulted from commit 6891171a906f708b8751cc583faffc9

[Engine-patches] Change in ovirt-engine[master]: core:Can not upgrade from 3.1 to 3.2

2013-01-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:Can not upgrade from 3.1 to 3.2 .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10690 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade

2013-01-07 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: DB 3.0 to 3.1 upgrade .. Patch Set 1: (1 inline comment) Just one comment - not sure why the part of the statement I marked with an inline comment should

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3175 - Fixed!

2013-01-07 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3175/ Build Number: 3175 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 3,874 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade

2013-01-07 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: DB 3.0 to 3.1 upgrade .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-

[Engine-patches] Change in ovirt-engine[master]: engine: consolidate VM and Poll queries

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: consolidate VM and Poll queries .. Patch Set 4: Rebased, no changes since last time. -- To view, visit http://gerrit.ovirt.org/10475 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: rerun HA vm that fails during live snapshot

2013-01-07 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: rerun HA vm that fails during live snapshot .. Patch Set 4: (3 inline comments) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: optimizing view for FF17 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10734 To unsubscribe, visit http://gerrit.o

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 3174 - Failure!

2013-01-07 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3174/ Build Number: 3174 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 3,873 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: webadmin: GWT 2.4 migration cleanup

2013-01-07 Thread vszocs
Vojtech Szocs has abandoned this change. Change subject: webadmin: GWT 2.4 migration cleanup .. Patch Set 1: Abandoned Abandoning this patch for now, as we're planning to move to GWT 2.5 eventually. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Move to GWTP 0.7

2013-01-07 Thread vszocs
Vojtech Szocs has abandoned this change. Change subject: webadmin,userportal: Move to GWTP 0.7 .. Patch Set 1: Abandoned Abandoning this patch for now, as we're planning to move to GWT 2.5 eventually. -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Move to GWT 2.4

2013-01-07 Thread vszocs
Vojtech Szocs has abandoned this change. Change subject: webadmin,userportal: Move to GWT 2.4 .. Patch Set 1: Abandoned Abandoning this patch for now, as we're planning to move to GWT 2.5 eventually. -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: CellTable optimization

2013-01-07 Thread vszocs
Vojtech Szocs has abandoned this change. Change subject: webadmin,userportal: CellTable optimization .. Patch Set 2: Abandoned Unfortunately, initial testing in IE8 shows that performance gain is marginal, at the cost of signi

[Engine-patches] Change in ovirt-engine[master]: restapi: wrong user id in /api/users//permissions(#89012...

2013-01-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi: wrong user id in /api/users//permissions(#890124) .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10581 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: engine : incomplete error when trying to add host with wrong...

2013-01-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : incomplete error when trying to add host with wrong cluster ID .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/10586 To unsubscribe, vis

[Engine-patches] Change in ovirt-log-collector[master]: tools: Review Request: ovirt-log-collector(BZ831878)

2013-01-07 Thread kroberts
Keith Robertson has abandoned this change. Change subject: tools: Review Request: ovirt-log-collector(BZ831878) .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/6388 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: restapi: adding host specifying cluster by-name is not suppo...

2013-01-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi: adding host specifying cluster by-name is not supported(#890329) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10726 To unsubscribe, v

[Engine-patches] Change in ovirt-iso-uploader[master]: tools: Better API error handling

2013-01-07 Thread kroberts
Keith Robertson has abandoned this change. Change subject: tools: Better API error handling .. Patch Set 2: Abandoned -- To view, visit http://gerrit.ovirt.org/8954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: restapi: version values for hosts are wrong

2013-01-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi: version values for hosts are wrong .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10687 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: optimizing view for FF17 .. Patch Set 2: Verified - rebased - fixed commit message -- To view, visit http://gerrit.ovirt.org/10734 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: engine : Autorecovering hosts shows host uid and not host na...

2013-01-07 Thread rnori
Ravi Nori has posted comments on this change. Change subject: engine : Autorecovering hosts shows host uid and not host name .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/10736 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine : Autorecovering hosts shows host uid and not host na...

2013-01-07 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: engine : Autorecovering hosts shows host uid and not host name .. engine : Autorecovering hosts shows host uid and not host name When a host is being autorecovered

[Engine-patches] Change in ovirt-engine[master]: core: DB 3.0 to 3.1 upgrade

2013-01-07 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: DB 3.0 to 3.1 upgrade .. core: DB 3.0 to 3.1 upgrade This patch fixes the following errors 1) psql:upgrade/03_01_0410_remove_image_templates_table.sql:2: ERR

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Minor UI performance improvements

2013-01-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: Minor UI performance improvements .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9365 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5541 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeb8 Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeb9 Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebe Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebc Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebd Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebb Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeba Signed-off-by: Justin Clift ---

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10728 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10733 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10732 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved einav - maybe just delete all this commented code? -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10730 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 1: Verified; Looks good to me, approved well, the rest of the comment[1] isn't correct, but shouldn't block this fix

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Dialog style improvements

2013-01-07 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin,userportal: Dialog style improvements .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6382 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Minor UI performance improvements

2013-01-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin,userportal: Minor UI performance improvements .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread iheim
Itamar Heim has posted comments on this change. Change subject: webadmin: optimizing view for FF17 .. Patch Set 1: (1 inline comment) Commit Message Line 3: AuthorDate: 2013-

[Engine-patches] Change in ovirt-engine[master]: webadmin: optimizing view for FF17

2013-01-07 Thread ecohen
Einav Cohen has uploaded a new change for review. Change subject: webadmin: optimizing view for FF17 .. webadmin: optimizing view for FF17 The "This Browser version isn't optimal" will not be displayed for Firefox 17 on Linux.

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Add ReplacementUtils .. Patch Set 2: (3 inline comments) File backend/manager/modules/utils/src/main/

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Minor UI performance improvements

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Minor UI performance improvements .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/9365 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-iso-uploader[master]: build: build rewrite using autotools

2013-01-07 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: build: build rewrite using autotools .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8855 To unsubscribe, visit

[Engine-patches] Change in ovirt-iso-uploader[master]: build: build rewrite using autotools

2013-01-07 Thread kroberts
Keith Robertson has submitted this change and it was merged. Change subject: build: build rewrite using autotools .. build: build rewrite using autotools autotools provide simple method to integrate with standard tools such as

[Engine-patches] Change in ovirt-engine[master]: engine: Add ReplacementUtils

2013-01-07 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Add ReplacementUtils .. Patch Set 2: (3 inline comments) File backend/manager/modules/utils/src/mai

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Minor UI performance improvements

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Minor UI performance improvements .. Patch Set 4: Rebased, no changes since last time. -- To view, visit http://gerrit.ovirt.org/9365 To un

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix AsyncQuery related NPE

2013-01-07 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin,userportal: Fix AsyncQuery related NPE .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10727 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: engine: Fixing some minor typos. .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5541 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Allow updating network if not used by hosts

2013-01-07 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Allow updating network if not used by hosts .. Patch Set 6: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Implement dialog close button (icon)

2013-01-07 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin,userportal: Implement dialog close button (icon) .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6112 To unsubscrib

[Engine-patches] Change in ovirt-iso-uploader[master]: build: build rewrite using autotools

2013-01-07 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: build: build rewrite using autotools .. Patch Set 6: Verified Updated gettext version. -- To view, visit http://gerrit.ovirt.org/8855 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix AsyncQuery related NPE

2013-01-07 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin,userportal: Fix AsyncQuery related NPE .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10727 T

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebe Signed-off-by: Justin Clift --- M bac

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebd Signed-off-by: Justin Clift --- M bac

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebc Signed-off-by: Justin Clift --- M fro

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeb9 Signed-off-by: Justin Clift --- M bac

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beebb Signed-off-by: Justin Clift --- M bac

[Engine-patches] Change in ovirt-engine[master]: engine: Fixing some minor typos.

2013-01-07 Thread jclift
Justin Clift has uploaded a new change for review. Change subject: engine: Fixing some minor typos. .. engine: Fixing some minor typos. Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeba Signed-off-by: Justin Clift --- M bac

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Dialog style improvements

2013-01-07 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Dialog style improvements .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/6382 To unsubscribe, visit http://gerrit.ovirt.

  1   2   3   >