Vojtech Szocs has posted comments on this change.

Change subject: engine: consolidate VM and Poll queries
......................................................................


Patch Set 4:

Just a comment to Liron's question in patch set 1:

> basically the intention seems to save a backend call and perform two queries 
> at once if possible - does it really saves us that much?

Yes, mostly from the client perspective. User Portal typically treats VMs and 
Pools as entities that are closely related, and therefore presents both kinds 
of entities in single UI representation, e.g. VM/Pool items in Basic view, or 
VM/Pool table in Extended view.

>From this perspective, it doesn't make sense to have two parallel queries (one 
>for VMs, one for Pools) and combine their results on client side. Instead, the 
>client should use a query that returns appropriate data in a single call.

--
To view, visit http://gerrit.ovirt.org/10475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59346bc9f1cf6d948c4401ddbd7bb365c67b5b05
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to