Yair Zaslavsky has posted comments on this change. Change subject: core: DB 3.0 to 3.1 upgrade ......................................................................
Patch Set 1: (1 inline comment) Just one comment - not sure why the part of the statement I marked with an inline comment should be in a patch that deals with drop/add constraint. In addition, maybe when you introduce such "helper functions" you should send email to engine-devel so people will learn about these changes? .................................................... File backend/manager/dbscripts/upgrade/03_01_0950_add_permissions_on_storage_to_users.sql Line 72: v_STORAGE_OBJECT_TYPE Line 73: FROM vds_groups Line 74: INNER JOIN storage_pool_iso_map ON vds_groups.storage_pool_id = storage_pool_iso_map.storage_pool_id Line 75: WHERE vds_groups.vds_group_id = v_permissions.object_id and Line 76: cast(v_DISK_CREATOR_ROLE_ID as VARCHAR) || cast(v_permissions.ad_element_id as VARCHAR) || Not sure why this is in the patch + I would recommend to use our convention of uppercase + proer indentation. Line 77: cast(storage_pool_iso_map.storage_id as VARCHAR) not in Line 78: ( select cast(role_id as VARCHAR) || cast(ad_element_id as VARCHAR) || Line 79: cast(object_id as VARCHAR) from permissions)); Line 80: -- To view, visit http://gerrit.ovirt.org/10735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0a37abb58f080338b3161d0694c8ba30217d99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
