Alexander Wels has uploaded a new change for review. Change subject: webadmin: escape during dialog loading causes problems. ......................................................................
webadmin: escape during dialog loading causes problems. - Added prevent default to escape handler to stop bad things from happening when pressing escape while the dialog hasn't fully loaded yet. Change-Id: Ib6a217efa88a9fb3921aa12fcc86627cd005df1d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879497 Signed-off-by: Alexander Wels <aw...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/10738/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java index dd64d57..cf271ac 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java @@ -197,6 +197,7 @@ handleEnterKey(commandInvoker); } else if (KeyCodes.KEY_ESCAPE == event.getKeyCode()) { handleEscapeKey(commandInvoker); + event.preventDefault(); } } }); -- To view, visit http://gerrit.ovirt.org/10738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6a217efa88a9fb3921aa12fcc86627cd005df1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches