Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Fix volume option dialog hang issue
..
webadmin: Fix volume option dialog hang issue
When there are no UP servers in the cluster, we
will not able to fe
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Removed duplicate call to onSuccess in RunQuery
..
webadmin: Removed duplicate call to onSuccess in RunQuery
In case of handleFailure=true, the onSucces
Greg Padgett has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (4/4)
..
Patch Set 7: Verified
No changes since prior patch.
--
To view, visit http://gerrit.ovirt.org/10169
To unsub
Greg Padgett has posted comments on this change.
Change subject: webadmin: Changes for CPU Thread Handling (3/4)
..
Patch Set 8: Verified
No changes since prior patch.
--
To view, visit http://gerrit.ovirt.org/10170
To unsubsc
Greg Padgett has posted comments on this change.
Change subject: core: VdsSelector changes for CPU Thread Handling (2/4)
..
Patch Set 6: Verified
No changes since prior patch.
--
To view, visit http://gerrit.ovirt.org/10168
To
Greg Padgett has posted comments on this change.
Change subject: core: Add attributes for CPU Thread Handling (1/4)
..
Patch Set 6: Verified
No changes since prior patch except commit message
--
To view, visit http://gerrit.ov
Selvasundaram has posted comments on this change.
Change subject: engine: Gluster Volume Geo-replication Start
..
Patch Set 14:
Upgrade script will be updated with 3.2 sequence in the next rebased patch set.
--
To view, visit
Einav Cohen has posted comments on this change.
Change subject: webadmin: Changes for CPU Thread Handling (3/4)
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10170
To unsubscribe, visit ht
Einav Cohen has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (4/4)
..
Patch Set 6: No score
[acked rest-api patch by mistake - reverting ack]
--
To view, visit http://gerrit.ovirt
Einav Cohen has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (4/4)
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10169
To unsubscribe, visit
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: disabled style for 'specific host' label
..
webadmin: disabled style for 'specific host' label
Add style for disabled label in AbstractVmPopupWidget, whi
Arik Hadas has posted comments on this change.
Change subject: webadmin: disabled style for 'specific host' label
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10295
To unsubscribe, visit http://gerrit.ovir
Arik Hadas has posted comments on this change.
Change subject: webadmin: VmDesktopNewPopupWidget cleanup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10296
To unsubscribe, visit http://gerrit.ovirt.org/set
Arik Hadas has posted comments on this change.
Change subject: webadmin: move logic from popup widget to its model
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10294
To unsubscribe, visit http://gerrit.ovi
Arik Hadas has posted comments on this change.
Change subject: webadmin: allow changing name of VM attached to pool
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10293
To unsubscribe, visit http://gerrit.ov
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: VmDesktopNewPopupWidget cleanup
..
webadmin: VmDesktopNewPopupWidget cleanup
- Rename the parameter for 'edit' method from object to unitVmModel
- Remove
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: move logic from popup widget to its model
..
webadmin: move logic from popup widget to its model
This patch improves the previous patch for fixing bug #8
Arik Hadas has uploaded a new change for review.
Change subject: webadmin: allow changing name of VM attached to pool
..
webadmin: allow changing name of VM attached to pool
This is a quick solution for a requirement to be able
Doron Fediuck has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (4/4)
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10169
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Changes for CPU Thread Handling (3/4)
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10170
T
Doron Fediuck has posted comments on this change.
Change subject: core: VdsSelector changes for CPU Thread Handling (2/4)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Doron Fediuck has posted comments on this change.
Change subject: core: Add attributes for CPU Thread Handling (1/4)
..
Patch Set 5: (1 inline comment)
Please add a reference to the feature page.
No other comments.
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Remove out of date .jar.index files
..
Patch Set 3:
Or create the index at rpm install, and not touch... as jars should not be
changed.
--
To view, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Remove out of date .jar.index files
..
Patch Set 3:
In this case I think we should copy the modules into /var/tmp and not touch
/usr.
--
To view, vis
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove out of date .jar.index files
..
Patch Set 3: Verified
Verified touching one of the .jar files, the corresponding .jar file is deleted.
--
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10218
To unsubscribe, visit http://gerrit.o
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fixed support for reporting devices with only ipv6.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10223
To unsubscribe, visit http:
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Remove out of data .jar.index files
..
packaging: Remove out of data .jar.index files
The application server creates .jar.index files in the modules
Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmInterfaceCommand
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9798
To unsubscribe, visit h
Moti Asayag has posted comments on this change.
Change subject: engine: Update VmGuestAgentInterfaces
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/vdsbrok
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
--
To view, visit http://
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: (3 inline comments)
File
backend/manager/modules/co
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vdsStatic table
..
Patch Set 3:
Of course make sure that the numbering prefix is still 02_0090 (maybe some
other patch was already m
Yair Zaslavsky has posted comments on this change.
Change subject: Adding host bios fields to vdsStatic table
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10114
To un
Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: I would prefer that you didn't submit this
(2 inline comments)
.
Alissa Bonas has uploaded a new change for review.
Change subject: core: cleanup and renaming in VdsDeploy
..
core: cleanup and renaming in VdsDeploy
Remove unused constant, rename variable according to java convention
and impro
Allon Mureinik has posted comments on this change.
Change subject: core: ClassCastException when attempting to get storage domain
of disk
..
Patch Set 1: (1 inline comment)
Alexander Wels has posted comments on this change.
Change subject: core: Added DocsServlet core: Added SplashServlet webadmin:
Added handling missing languages webadmin: Added handling missing languages
..
Patch Set 9: Verified
Alexander Wels has posted comments on this change.
Change subject: core: Added DocsServlet core: Added SplashServlet webadmin:
Added handling missing languages webadmin: Added handling missing languages
..
Patch Set 7: Verified
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: CellTable optimization
..
Patch Set 2:
Yes, but there's also CellTable row highlight behavior based on
mouseover/mouseout events, which thi
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
..
Patch Set 13: (1 inline comment)
Omer - please remove your -2
Fil
Liron Aravot has uploaded a new change for review.
Change subject: core: ClassCastException when attempting to get storage domain
of disk
..
core: ClassCastException when attempting to get storage domain of disk
When a VM has d
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added packaging to ovirt reports.
..
Patch Set 1: (5 inline comments)
I think that LICENSE is missing.
Have you verified the following sequence:
mak
Arik Hadas has posted comments on this change.
Change subject: engine: VM Linux Boot options aren't parsing properly
..
Patch Set 3: (1 inline comment)
File
frontend/webadm
Vojtech Szocs has submitted this change and it was merged.
Change subject: Initial commit of Foreman UI plugin
..
Initial commit of Foreman UI plugin
Change-Id: I8b94af6cbaa7687661762f60c5bda03b73b7a2dc
Signed-off-by: Oved Ourf
Vojtech Szocs has posted comments on this change.
Change subject: Initial commit of Foreman UI plugin
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10277
To unsubscribe, visit ht
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Adding CurrentUser a getFullUserName helper function
..
webadmin: Adding CurrentUser a getFullUserName helper function
Change-Id: Id3fac84e9c8
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Adding CurrentUser a getFullUserName helper function
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/101
Moti Asayag has posted comments on this change.
Change subject: engine: Added VM NIC validator
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
very nice and easy to read/understand/maintain/...
.
Moti Asayag has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
..
Patch Set 17: (1 inline comment)
File
backend/manager
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Adding CurrentUser a getFullUserName helper function
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10190
To unsubscribe, visit htt
Vojtech Szocs has posted comments on this change.
Change subject: Initial commit of Foreman UI plugin
..
Patch Set 1:
Thanks Oved for contributing this plugin!
--
To view, visit http://gerrit.ovirt.org/10277
To unsubscribe, vi
Mike Kolesnik has posted comments on this change.
Change subject: core: adding "NetworkLinkingSupported" to vdc_options.
..
Patch Set 8: (1 inline comment)
File backend/manag
Allon Mureinik has posted comments on this change.
Change subject: core: Removed unused class.
..
Patch Set 2: Looks good to me, but someone else must approve
Eli - should this be removed from create_tables.sql, or do we consid
Moti Asayag has posted comments on this change.
Change subject: engine: Added variable replacements to ValidationResult
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10267
To unsubscribe,
Allon Mureinik has submitted this change and it was merged.
Change subject: core: clean javadoc in VmHandler
..
core: clean javadoc in VmHandler
Remove unused parameters in javadoc and rename ones incorrectly named
in VMHandler
Allon Mureinik has posted comments on this change.
Change subject: core: clean javadoc in VmHandler
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, re-verified.
No code changes.
--
To view, visit http://gerrit.ov
Eli Mesika has posted comments on this change.
Change subject: engine: Gluster Volume Geo-replication Start
..
Patch Set 14:
shouldn't upgrade scripts be targeted to 3.2 ???
(should have 03_02 prefix )
--
To view, visit http:/
Eli Mesika has posted comments on this change.
Change subject: [WIP] core: compensation should not clean entities with
associated tasks
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9122
Mike Kolesnik has posted comments on this change.
Change subject: engine: Update VmGuestAgentInterfaces
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/vdsbr
Doron Fediuck has posted comments on this change.
Change subject: core: missing translation in Quota ($VmName)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9662
To unsubscribe, visit http
Eli Mesika has posted comments on this change.
Change subject: [WIP] engine: User queries improvements
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9825
To unsubscribe, visit http://gerri
Oved Ourfali has posted comments on this change.
Change subject: webadmin: Adding CurrentUser a getFullUserName helper function
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10190
To unsub
Eli Mesika has posted comments on this change.
Change subject: engine: create DC and cluster as 3.2
..
Patch Set 1: (1 inline comment)
File backend/manager/dbscripts/insert_d
Allon Mureinik has posted comments on this change.
Change subject: engine: Removing unneeded setVdsId() from constructors
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10235
To unsubscribe
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add GetVmGuestAgentInterfacesByVmIdQuery
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10099
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: remove 2 unused classes
..
Patch Set 1: Looks good to me, but someone else must approve
Looks good to me, but I'd like someone who is more familiar with t
Eli Mesika has posted comments on this change.
Change subject: core: Renamed event_notification_methods.java to
EventNotificationMethod.java
..
Patch Set 1: (1 inline comment)
..
Allon Mureinik has posted comments on this change.
Change subject: core: clean javadoc in VmHandler
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10283
To unsubscribe, visit http://gerrit.
Eli Mesika has posted comments on this change.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10287
To unsubscribe, visit http
Moti Asayag has uploaded a new change for review.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
engine: Add index to vm_guest_agent_interfaces
Add a patch to improve data selection from
vm_guest_agent_interfa
Eli Mesika has posted comments on this change.
Change subject: Adding host bios fields to vdsStatic table
..
Patch Set 2: (1 inline comment)
File backend/manager/dbscripts/cr
Eli Mesika has posted comments on this change.
Change subject: webadmin: Remove irrelevant operations from UserVmManager role
..
Patch Set 2:
sorry , there is already 03_02_0090_cpuhost_support.sql
please rename again
--
To vi
Moti Asayag has posted comments on this change.
Change subject: core: HotPlugEnabled shouldn't be reloadable.
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9509
To unsubscribe, visit http
Moti Asayag has posted comments on this change.
Change subject: core: adding "NetworkLinkingSupported" to vdc_options.
..
Patch Set 8: (1 inline comment)
File backend/manager
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Let udev reset user rights on virtio-channel during package
removal
..
Let udev reset user rights on virtio-channel during package removal
When the package
Moti Asayag has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
..
Patch Set 17: (1 inline comment)
File
backend/manager
Eli Mesika has posted comments on this change.
Change subject: engine: template support for cpu host
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10205
To unsubscribe
Moti Asayag has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
..
Patch Set 17:
03_02_0100 is already taken. please update to latest.
--
To view, visit http://gerrit.ovirt.
Omer Frenkel has posted comments on this change.
Change subject: core: [RFE] Display of both the console user and the guest user
..
Patch Set 3: (3 inline comments)
File
bac
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Make EntityObject class final
..
webadmin: Make EntityObject class final
Making EntityObject class final just to be on safe side with regard
t
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Make EntityObject class final
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10238
To unsubscribe, visi
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
..
Patch Set 1: (3 inline comments)
File
frontend/webadmin
Alissa Bonas has posted comments on this change.
Change subject: core: Removed unused class.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10071
To unsubscribe, visit
Alexander Wels has restored this change.
Change subject: core: i18ned splash page.
..
Patch Set 5: Restored
Figured out what I was doing wrong, restoring.
--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, visit h
Alissa Bonas has uploaded a new change for review.
Change subject: core: remove 2 unused classes
..
core: remove 2 unused classes
Remove tags_permissions_map and DetachTagFromPermissionsCommand as they
are not used in code
Chan
Alexander Wels has abandoned this change.
Change subject: core: i18ned splash page.
..
Patch Set 5: Abandoned
Gerrit doesn't seem to want to pick up the entire patchset. I am abandoning
this one, and pushing the complete one a
Daniel Erez has posted comments on this change.
Change subject: webadmin: Split VM->VmIntererface sub tub
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10242
To unsubscribe, visit http://g
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Remove KerberosUpgrade
..
core: Remove KerberosUpgrade
This class is no longer used.
Change-Id: Ic224053927f9f9c71077324593686c8d26909fd7
Signed
Juan Hernandez has posted comments on this change.
Change subject: core: Remove KerberosUpgrade
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous approval.
--
To view, visit http://gerrit.ovirt.org
Juan Hernandez has posted comments on this change.
Change subject: core: Remove KerberosUpgrade
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Fixed invalid HTML in index and 404.
..
core: Fixed invalid HTML in index and 404.
index.html added missing closing div tag.
404.html moved body
Juan Hernandez has posted comments on this change.
Change subject: core: Fixed invalid HTML in index and 404.
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9773
To unsubscribe, v
Juan Hernandez has posted comments on this change.
Change subject: core: Fixed invalid HTML in index and 404.
..
Patch Set 6: Verified; Looks good to me, approved
No need for further review.
--
To view, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Added handling missing languages
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.
Alissa Bonas has posted comments on this change.
Change subject: core: clean javadoc in VmHandler
..
Patch Set 1: Verified
compiled to make sure the code is not damaged.
--
To view, visit http://gerrit.ovirt.org/10283
To unsub
Michael Kublin has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
..
Patch Set 5:
fixed NullPointer in recovery flow
--
To view, visit http://gerrit.ovirt.org/9838
To unsubscrib
Alissa Bonas has uploaded a new change for review.
Change subject: core: clean javadoc in VmHandler
..
core: clean javadoc in VmHandler
Remove unused parameters in javadoc and rename ones incorrectly named
in VMHandler class
Ch
Juan Hernandez has posted comments on this change.
Change subject: DO NOT SUBMIT: packaging: Initial commit
..
Patch Set 3: (1 inline comment)
File java-sdk/ovirt-java-sdk.sp
Juan Hernandez has posted comments on this change.
Change subject: packaging: Dont use /etc/java/java.conf
..
Patch Set 1:
No, it is not verified yet. I will verify. But as this is mostly a cosmetic
issue it is down in my list
1 - 100 of 183 matches
Mail list logo
