Juan Hernandez has posted comments on this change.

Change subject: webadmin: Added handling missing languages
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp
Line 18:        </p>
Line 19:        <div class="book">
Line 20:                <div class="titlepage">
Line 21:                        <div>
Line 22:                                <p>It appears that you do not have the 
<c:out value="${requestScope['locale'].getDisplayLanguage()}" /> language pack 
installed. 
Remove the trailing white space.

Can we replace tabs with spaces? I know it is a matter of taste, not really 
important.
Line 23:                                Please have your administrator install 
the proper language.</p>
Line 24:                                <p>
Line 25:                                Please click <a 
href="${requestScope['englishHref']}">here</a> for the English documentation. 
This message will
Line 26:                                only be displayed once per session.


--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to