Arik Hadas has posted comments on this change.
Change subject: engine: VM Linux Boot options aren't parsing properly
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1911: getInitrd_path().setEntity(""); //$NON-NLS-1$
Line 1912: }
Line 1913:
Line 1914: if (isLinux_Unassign_UnknownOS) {
Line 1915: String noTrimmingSpacesPattern = "^$|^\\S.*\\S$"; //
$NON-NLS-1$
please use ValidationUtils.NO_TRIMMING_WHITE_SPACES_PATTERN
Line 1916: String cannotStartOrEndWithWhitespaceMsg =
ConstantsManager.getInstance()
Line 1917: .getConstants().trimmingSpacesInField();
Line 1918:
Line 1919: getKernel_path().ValidateEntity(
--
To view, visit http://gerrit.ovirt.org/9550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
