Eli Mesika has posted comments on this change.
Change subject: core: Renamed event_notification_methods.java to
EventNotificationMethod.java
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java
Line 29: * @param user
Line 30: * The user.
Line 31: * @return
Line 32: */
Line 33: protected boolean
ValidateNotificationMethod(java.util.List<EventNotificationMethod>
event_notification_methods,
I would expect a code clean-up to do that as well, it was done in other patches
and it is very easy with eclipse refatoring
Line 34: event_subscriber
event_subscriber, DbUser user) {
Line 35: boolean retValue = true;
Line 36: EventNotificationMethods notificationMethod =
event_notification_methods.get(0).getmethod_type();
Line 37:
--
To view, visit http://gerrit.ovirt.org/10068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I583ddb60b305af917db989f2dee0c22f0f7d5a24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
