Michal Skrivanek has posted comments on this change.
Change subject: agent: apply virtual-guest tuning profile on installation.
..
Patch Set 1: Looks good to me, but someone else must approve
far from being ideal but as a quick
ofri masad has posted comments on this change.
Change subject: core: remove unused private method from
CommonVmPoolWithVmsCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Michael Kublin has posted comments on this change.
Change subject: core: Added log for storage connection error (#854210)
..
Patch Set 1: I would prefer that you didn't submit this
These patch is completely wrong.
1. First of a
Maor Lipchuk has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules
Michael Kublin has posted comments on this change.
Change subject: core: MockEJBStrategyRule
..
Patch Set 1: I would prefer that you didn't submit this
Missing patch, change that clean old implementation -
JBossEmbeddedEJBUti
Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster Peer Detach bll command
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9044
To unsubscri
Oved Ourfali has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 8: (1 inline comment)
minor comment.
..
Vered Volansky has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 2: (1 inline comment)
Commit Message
Line 7: cor
Vered Volansky has posted comments on this change.
Change subject: core: remove redundant constructors from VmStatistics
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Vered Volansky has posted comments on this change.
Change subject: core: remove unused private method from
CommonVmPoolWithVmsCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Vered Volansky has posted comments on this change.
Change subject: core: Added log for storage connection error (#854210)
..
Patch Set 1: Looks good to me, but someone else must approve
I suppose you're aware of the code duplic
Vered Volansky has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
..
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
...
Alon Bar-Lev has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
..
Patch Set 13: Verified
Verify by unit tests. ACK by Shireesh Anjal to merge.
--
To view, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 13: Verified
Verified as much as the faulty ovirt-node state allows.
--
To
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 1: Verified
Some of the modules are still needed, till they are fixed in the jboss-as
package.
--
To vi
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Remove overriden JBoss modules
..
packaging: Remove overriden JBoss modules
Remove some of the JBoss modules that we replaced in the past. They are
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Fix ownership of deployments and contents
..
packaging: Fix ownership of deployments and contents
A previous commit (9d5af3) changed the .sp
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
T
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9369
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 13:
I hope too. both issues are not exposed within the public interface, so
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 13: Looks good to me, but someone else must approve
Yes, we are done. The
Vered Volansky has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/9303
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9303
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: core: MockEJBStrategyRule
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Allon Mureinik has uploaded a new change for review.
Change subject: core: MockEJBStrategyRule
..
core: MockEJBStrategyRule
Introducing MockEJBStrategyRule to provide an easy and straight forward
way to mock EJBs and resources i
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 13:
Juan, are we done?
--
To view, visit http://gerrit.ovirt.org/9174
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
I like the previous version better,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
I have no string opinion, I already wrote, do what you think best.
--
To view, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
This discussion got completely out of the scope of this change. Please open a
thread in engin
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
> Binary blobs are forbidden in Fedora.
But this what we actually do... or have no user interfa
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
>> Want do you mean without GWT? how does it actually work?
> I mean that we don't build webadm
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
Binary blobs are forbidden in Fedora.
--
To view, visit http://gerrit.ovirt.org/9400
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
I strongly against having a repository without spec file.
People and developers should be able
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
I suggest we explore the option of using the BINARY blob of the GWT for now...
yes, push the bi
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
By the way, if one day we manage to have GWT in Fedora and manage to build
everything in Fedo
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
> Want do you mean without GWT? how does it actually work?
I mean that we don't build webadmi
Sharad Mishra has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
Want do you mean without GWT? how does it actually work?
Why can't we add the GWT files as Sour
Sharad Mishra has posted comments on this change.
Change subject: core: remove unused private method from AddVdsCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
By the way, we do build the official Fedora ovirt-engine package using
mvn-rpmbuild, but with
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
Bundling GWT with ovirt-engine doesn't seem reasonable to me. If you want GWT
in Fedora it is
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
It is not that important, we can always fix this in future.
I would have explored the option of
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
So, what do you propose?
--
To view, visit http://gerrit.ovirt.org/9400
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
But it is not a reason to go farther than the best practice.
--
To view, visit http://gerrit.ov
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1: Verified
Verified building new RPMs after removing the packages containing the plugins.
--
To
Juan Hernandez has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
We can't use mvn-rpmbuild because we need GWT, which is not included in Fedora.
--
To view, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1:
Oh... I just had the same with otopi[1]... and did move to mvn-rpmbuild as
fedora specifies. It
Sharad Mishra has posted comments on this change.
Change subject: core: Add Intell Haswel model
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Just one nit.
Eyal Edri has posted comments on this change.
Change subject: packaging: Don't require Maven packages for build
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9400
To u
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup Vm
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9394
To unsubscribe, visit http://gerr
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup Vm
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/bll/src/main/java/org/ovi
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Don't require Maven packages for build
..
packaging: Don't require Maven packages for build
The .spec that we use has a lot of build requirements fo
Omer Frenkel has posted comments on this change.
Change subject: core: add Opteron G5 model
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9389
To unsubscribe, visit http://gerrit.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: core: Add Intell Haswel model
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9392
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has uploaded a new change for review.
Change subject: core: Added log for storage connection error (#854210)
..
core: Added log for storage connection error (#854210)
Added a log entry when a VDS connect to storage dom
Sharad Mishra has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (6 inline comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 2:
Note that also changed the release number to 0.1.MMDDHHMMSS to avoid using
git.
--
To view, visit
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 2: Verified
Verified building a new set of packages with this patch and
http://gerrit.ovirt.org/9369 . Th
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Minor bugfix release 3.1.0-4
..
packaging: Minor bugfix release 3.1.0-4
This prepares for a minor bug fix release to fix the bugs indicated
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Minor bugfix release 3.1.0-4
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9147
To unsubscribe, visit http://g
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 2: No score
--
To view, visit http://gerrit.ovirt.org/9369
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 2: Looks good to me, but someone else must approve
Sorry.
--
To view, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 2: Verified
OK, thank you for explaining that.
--
To view, visit http://gerrit.ovirt.org/9369
T
Juan Hernandez has posted comments on this change.
Change subject: packaging: Fix ownership of deployments and contents
..
Patch Set 1: (1 inline comment)
File packaging/fedo
Maor Lipchuk has posted comments on this change.
Change subject: core: Adding force extend support to extendVG
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: support python3 in make tarball
..
packaging: support python3 in make tarball
This fix minor python3 related syntax change.
Change-Id: Idec
Juan Hernandez has posted comments on this change.
Change subject: packaging: support python3 in make tarball
..
Patch Set 2: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To view, vi
Juan Hernandez has posted comments on this change.
Change subject: packaging: support python3 in make tarball
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9391
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: support python3 in make tarball
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/9391
To unsubscribe, visit http://gerrit.ovirt.org/s
Roy Golan has uploaded a new change for review.
Change subject: core: Add Intell Haswel model
..
core: Add Intell Haswel model
Adding Intel Haswell model to the engine's config
Change-Id: I269a041227453fb3af11ce82e0db9694b4be9b
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: support python3 in make tarball
..
packaging: support python3 in make tarball
This fix minor python3 related syntax change.
Change-Id: Idec1402ff3eda
Maor Lipchuk has uploaded a new change for review.
Change subject: core:End failed live snapshot with warning.
..
core:End failed live snapshot with warning.
Engine fails to create Live-Snapshot during power off of VM.
This is s
Juan Hernandez has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 1: (1 inline comment)
File Makefile
Line 50: RPM_VERS
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Bump package version to 3.2.0
..
Patch Set 1: (1 inline comment)
+1 on the need to bump version (added few falks from engine to review).
Small commen
Juan Hernandez has posted comments on this change.
Change subject: packaging: all-in-one: depend on ovirt-host-deploy-offline
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 13:
I referenced all comments. Only exception I think is the finalized discu
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (7 inline comments)
Thank you!
I am glad it all about format.
Alona Kaplan has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/m
Roy Golan has uploaded a new change for review.
Change subject: core: add Opteron G5 model
..
core: add Opteron G5 model
Adding AMD Opteron G5 model to the engine's config
Change-Id: I6eb396a88898924459e6ba5ff58356adddc56707
Bu
Juan Hernandez has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (2 inline comments)
In order to build an RPM you just have to type "mak
Roy Golan has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (1 inline comment)
File
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused private method from AddVdsCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: detach OVirtUpgrader from VdsInstaller into
OVirtNodeUpgrade
..
Patch Set 12: (12 inline comments)
See my comments inside. Nothing new.
...
Kanagaraj M has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
one minor comment.
..
Justin Hammond has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: (7 inline comments)
Replied to a few comments.
Yair - Got it. Thanks!
Oved Ourfali has posted comments on this change.
Change subject: Python Sample: first commit
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9387
To unsubscribe, visit http://gerrit.ovirt.or
Shahar Havivi has posted comments on this change.
Change subject: Python Sample: first commit
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Oved Ourfali has posted comments on this change.
Change subject: Python Sample: first commit
..
Patch Set 2: (4 inline comments)
Some minor comments.
Nice work!
File python/
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Justin - you should use the same change-id -
What I do in such cases is
Justin Hammond has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
Hi Juan,
Regarding your question about the location of the Jar files:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Messages grammar fixes
..
core: Messages grammar fixes
The main issues (in file AuditLogMessages.properties):
1. "finish to XXX" is changed to "f
Vered Volansky has posted comments on this change.
Change subject: core: Messages grammar fixes
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Allon Mureinik has posted comments on this change.
Change subject: core: Messages grammar fixes
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9352
To unsubscribe, visit http://gerrit.ovirt
1 - 100 of 140 matches
Mail list logo
