Justin Hammond has posted comments on this change.

Change subject: engine: Integrate Atlassian Crowd Client as a new 
Authentication Domain
......................................................................


Patch Set 1:

Hi Juan,
Regarding your question about the location of the Jar files:

They ended up in the lib directory of the unpacked EAR:
These are the files I assume are pulled in as dependencies:
crowd-integration-api-2.3.6.jar
crowd-integration-client-rest-2.3.6.jar
crowd-integration-client-common-2.3.6.jar
embedded-crowd-api-2.3.6.jar

(this is on the standalone directory. Question: How do I build a RPM to test a 
deployment scenario?)

I testing removing these files from the lib directory and starting jboss. 
oVirt-engine starts up ok, but as soon as someone hits either the API or  
webadmin pages, it throws a exception, and you can't log in:

2012-11-19 23:00:26,892 ERROR [org.jboss.ejb3.invocation] 
(http--0.0.0.0-8700-2) JBAS014134: EJB Invocation failed on component Backend 
for method public abstract 
org.ovirt.engine.core.common.queries.VdcQueryReturnValue 
org.ovirt.engine.core.common.interfaces.BackendLocal.RunPublicQuery(org.ovirt.engine.core.common.queries.VdcQueryType,org.ovirt.engine.core.common.queries.VdcQueryParametersBase):
 javax.ejb.EJBException: java.lang.RuntimeException: 
java.lang.NoClassDefFoundError: 
com/atlassian/crowd/embedded/api/SearchRestriction
and
2012-11-19 23:00:26,957 ERROR 
[org.apache.catalina.core.ContainerBase.[jboss.web].[default-host].[/webadmin]] 
(http--0.0.0.0-8700-2) Exception while dispatching incoming RPC call: 
com.google.gwt.user.server.rpc.UnexpectedException: Service method 'public 
abstract org.ovirt.engine.core.common.queries.VdcQueryReturnValue 
org.ovirt.engine.ui.frontend.gwtservices.GenericApiGWTService.RunPublicQuery(org.ovirt.engine.core.common.queries.VdcQueryType,org.ovirt.engine.core.common.queries.VdcQueryParametersBase)'
 threw an unexpected exception: javax.ejb.EJBException: 
java.lang.RuntimeException: java.lang.NoClassDefFoundError: 
com/atlassian/crowd/embedded/api/SearchRestriction
        at com.google.gwt.rpc.server.RPC.invokeAndStreamResponse(RPC.java:219) 
[gwt-servlet-2.3.0.jar:]

I got a feeling I know where you are heading with this question... Potentially 
we could just modify the ovirt-engine to load the crowd libraries if they 
exist, and if not, just continue. Sounds like a potential solution if oVirt 
can't distribute these libraries. 

Unfortunately, my Java skills doesn't extend that far. Iḿ happy to have a stab 
at it, if someone points me in the right direction though. (and if my 
assumption is correct. I assume I would just need to find a way to catch the 
exception and continue on instead of getting into whatever state its in now)

I'll start tiding up the patches shortly given the feedback already received... 

(any pointers to the Gerrit/git workflow for revising the patches available - I 
did a quick search on the wiki, but came up blank, or I just commit as per how 
I did this initial contribution?)

--
To view, visit http://gerrit.ovirt.org/9324
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide867f16d092eb329c0ce2fccf4ebd02f3aae0df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Justin Hammond <jus...@dynam.ac>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Justin Hammond <jus...@dynam.ac>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to