Maor Lipchuk has posted comments on this change.

Change subject: core: Adding force extend support to extendVG
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java
Line 16:     protected void ExecuteIrsBrokerCommand() {
Line 17:         String storageDomainId = 
getParameters().getStorageDomainId().toString();
Line 18:         String storagePoolId = 
getParameters().getStoragePoolId().toString();
Line 19:         List<String> deviceList = getParameters().getDeviceList();
Line 20:         String[] deviceArray = deviceList.toArray(new 
String[deviceList.size()]);
Not relevant
Line 21:         boolean isForce = getParameters().isForce();
Line 22: 
Line 23:         status = getParameters().isSupportForceExtendVG() ?
Line 24:                 getIrsProxy().extendStorageDomain(storageDomainId, 
storagePoolId, deviceArray, isForce) :


--
To view, visit http://gerrit.ovirt.org/9343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9196333f680bfad8bb421ad0dad8843b9c8e2b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to