Allon Mureinik has posted comments on this change.
Change subject: core: ImagesHandler clenaup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Allon Mureinik has posted comments on this change.
Change subject: core: ExportVmCommand clenaup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Allon Mureinik has posted comments on this change.
Change subject: core: ChangeDiskCommand clenaup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: SnapshotsManager clenaup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8202
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Allon Mureinik has posted comments on this change.
Change subject: core: UpdateStorageDomainCommand clenaup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8201
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has uploaded a new change for review.
Change subject: core: UpdateStorageDomainCommand clenaup
..
core: UpdateStorageDomainCommand clenaup
Removed usage of the deprecated StringHelper class from
UpdateStorageDoami
Allon Mureinik has uploaded a new change for review.
Change subject: core: ChangeDiskCommand clenaup
..
core: ChangeDiskCommand clenaup
Removed usage of the deprecated StringHelper class from
ChangeDiskCommand and used a simple
Allon Mureinik has uploaded a new change for review.
Change subject: core: ExportVmCommand clenaup
..
core: ExportVmCommand clenaup
Removed usage of the deprecated StringHelper class from
ExortVmCommand and used apache commons'
Allon Mureinik has uploaded a new change for review.
Change subject: core: ImagesHandler clenaup
..
core: ImagesHandler clenaup
Removed usage of the deprecated StringHelper class from
ImagesHandler and used apache commons' Strin
Allon Mureinik has uploaded a new change for review.
Change subject: core: SnapshotsManager clenaup
..
core: SnapshotsManager clenaup
Removed usage of the deprecated StringHelper class from
SnapshotsManager and used apache commo
Allon Mureinik has posted comments on this change.
Change subject: core: log domain name during error in irsbroker (#854025)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Federico Simoncelli has posted comments on this change.
Change subject: Trust the SpmStart task result during election
..
Patch Set 2: (1 inline comment)
File
backend/manage
Greg Padgett has posted comments on this change.
Change subject: core: log domain name during error in irsbroker (#854025)
..
Patch Set 2: Verified
Rebased (note there were a few changes to merge), re-verified, made
getDomainI
Sharad Mishra has posted comments on this change.
Change subject: core: remove redundant nullcheck
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7959
To unsubscribe, v
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Resizable columns in main tab grids
..
webadmin: Resizable columns in main tab grids
This patch enables column resizing for all main tab grids,
updati
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: Run once: unable to attach floppy disks
(#855579)
..
userportal,webadmin: Run once: unable to attach floppy disks (#855579)
https:
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests
..
userportal,webadmin: Invalid Time Zone Shown for Windows Guests
VM -> General: Time z
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/79
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: Run once: unable to attach floppy disks
(#855579)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Resizable table columns
..
Patch Set 10:
MainTabVirtualMachineView (VM main tab table) related changes were reverted,
column resizing will
Allon Mureinik has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
..
Patch Set 4:
Laszlo - it's already merged.
You can check it out at http://gerrit.ovirt.org/#/c/7257/
Allon Mureinik has posted comments on this change.
Change subject: userportal,webadmin: ClusterModel FindBugs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8197
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: webadmin: SearchSuggestionDisplay Findbugs
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8196
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: DateTime cleanup: Remove unused methods
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8195
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: check for duplicate upgrade scripts on unix
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased (on top of unrelated changes
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: SearchSuggestionDisplay Findbugs
..
webadmin: SearchSuggestionDisplay Findbugs
Fixed the FindBugs issue:
"Possible null pointer dereference of sugges
Allon Mureinik has uploaded a new change for review.
Change subject: userportal,webadmin: ClusterModel FindBugs
..
userportal,webadmin: ClusterModel FindBugs
In StoragePool_SelectedItemChanged, selectedDataCenter is validated to
Allon Mureinik has uploaded a new change for review.
Change subject: core: DateTime cleanup: Remove unused methods
..
core: DateTime cleanup: Remove unused methods
Removed unused methods of DateTime.
As a side effect, this solv
Roy Golan has posted comments on this change.
Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806)
..
Patch Set 2: (2 inline comments)
File
backen
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removing TransactiveAttribute and appropriate logic
..
core: Removing TransactiveAttribute and appropriate logic
The following attribute was used
Michael Kublin has posted comments on this change.
Change subject: core: Removing TransactiveAttribute and appropriate logic
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
..
Patch Set 4:
mkublin - can you verify that your patch (removing said class) also solve this
issue?
--
Michael Kublin has submitted this change and it was merged.
Change subject: core: add locks to VmTemplate commands (#761515)
..
core: add locks to VmTemplate commands (#761515)
https://bugzilla.redhat.com/761515
Currently the
Michael Kublin has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 17: Verified; Looks good to me, approved
(1 inline comment)
.
Michael Kublin has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
..
Patch Set 4:
Hi, I remove a HandleFailedStorageDomain class
--
To view, visit http://gerrit.ovirt.org/
Michael Kublin has posted comments on this change.
Change subject: core: minor AddStorageDomainCommon cleanup
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7958
To unsubscribe, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: remove redundant nullcheck
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7959
To unsubscribe, visit http://gerrit.o
Michael Kublin has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
..
Patch Set 4: Looks good to me, approved
consider applly Allon's remarks
--
To view, visit http://gerrit.ovirt.org/7960
To uns
Michael Kublin has posted comments on this change.
Change subject: core: GetStoragePoolInfoVDSCommand cleanup
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7963
To unsubscribe, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7962
To unsubscribe, visit http://gerrit.ovi
Michael Kublin has posted comments on this change.
Change subject: core: IrsBrokerCommand cleanup II
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7961
To unsubscribe, visit http://gerrit.
Michael Kublin has submitted this change and it was merged.
Change subject: Use the parent parameters in RemoveAllVmImagesCommand
..
Use the parent parameters in RemoveAllVmImagesCommand
When performing the RemoveAllVmImagesCom
Michael Kublin has posted comments on this change.
Change subject: Use the parent parameters in RemoveAllVmImagesCommand
..
Patch Set 2: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/811
Juan Hernandez has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: Use the parent parameters in RemoveAllVmImagesCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8119
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8124
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 4: (1 inline comment)
File packaging/fedo
Allon Mureinik has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8013
Juan Hernandez has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 4: (1 inline comment)
File packaging/fe
Liron Aravot has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 15: (1 inline comment)
File
backend/manager/mo
Federico Simoncelli has posted comments on this change.
Change subject: Use the parent parameters in RemoveAllVmImagesCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8119
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
Add the missing annotation
Daniel Erez has submitted this change and it was merged.
Change subject: core: fixed exception during creation of VM from template
..
core: fixed exception during creation of VM from template
During executing AddVmFromTemplateC
Daniel Erez has posted comments on this change.
Change subject: core: fixed exception during creation of VM from template
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8194
To un
Daniel Erez has posted comments on this change.
Change subject: core: fixed exception during creation of VM from template
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8194
To un
Roy Golan has posted comments on this change.
Change subject: core: less mutable VdsSelector
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6830
To unsubscribe, visit http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: core: Make dependency on commons-collections explicit
..
Patch Set 1:
> 1. If your code imports something - a dependency should be added to the
> pom.xml of th
Allon Mureinik has posted comments on this change.
Change subject: core: fixed exception during creation of VM from template
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Liron Aravot has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/8013
To unsubscribe, visit http://gerrit.ovir
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 4: (1 inline comment)
File packaging/fedo
Liron Aravot has uploaded a new change for review.
Change subject: core: fixed exception during creation of VM from template
..
core: fixed exception during creation of VM from template
During executing AddVmFromTemplateCommand,
Allon Mureinik has posted comments on this change.
Change subject: core: Make dependency on commons-collections explicit
..
Patch Set 1: Looks good to me, but someone else must approve
Thanks Juan, that was enlightening.
Just
Juan Hernandez has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
.
Juan Hernandez has posted comments on this change.
Change subject: core: Make dependency on commons-collections explicit
..
Patch Set 1:
No, it is not a duplication. Any thing that is included in an "import ..."
statement in t
Allon Mureinik has posted comments on this change.
Change subject: core: Make dependency on commons-collections explicit
..
Patch Set 1:
this dependency is defined in the master pom.xml - isn't this a duplication?
--
To view,
Roy Golan has submitted this change and it was merged.
Change subject: core: CI - ban artifacts in common project to avoid compilation
problem of GWT
..
core: CI - ban artifacts in common project to avoid compilation problem of
Roy Golan has posted comments on this change.
Change subject: core: CI - ban artifacts in common project to avoid compilation
problem of GWT
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.
Roy Golan has posted comments on this change.
Change subject: core: CI - ban artifacts in common project to avoid compilation
problem of GWT
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6785
To unsubscrib
Daniel Erez has submitted this change and it was merged.
Change subject: core: show LUN id in audit log when SD partially inaccessible
(#854214)
..
core: show LUN id in audit log when SD partially inaccessible (#854214)
https:
Daniel Erez has posted comments on this change.
Change subject: core: show LUN id in audit log when SD partially inaccessible
(#854214)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
.
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Resizable table columns (#767924)
..
Patch Set 9:
Patch set updated with regard to table scroll bar position handling:
* while in the same
Allon Mureinik has posted comments on this change.
Change subject: core: IrsBrokerCommand cleanup II
..
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
see inline
.
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup IrsBrokerCommand
..
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
Allon Mureinik has posted comments on this change.
Change subject: core: remove redundant nullcheck
..
Patch Set 4:
Sharad:
I'm guessing this is a "bug by evolution"
1st iteration: getstatus().equals(Active) - as you mentioned
Allon Mureinik has posted comments on this change.
Change subject: core: remove redundant nullcheck
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7959
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: core: check for duplicate upgrade scripts on unix
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: minor AddStorageDomainCommon cleanup
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7958
To uns
Allon Mureinik has posted comments on this change.
Change subject: core: GetStoragePoolInfoVDSCommand cleanup
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7963
To uns
Daniel Erez has submitted this change and it was merged.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
core: error message when deactivating SD with active VMs (#843407)
https://bugzilla
Daniel Erez has posted comments on this change.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Removing TransactiveAttribute and appropriate logic
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: CI - ban artifacts in common project to avoid compilation
problem of GWT
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visi
Oved Ourfali has posted comments on this change.
Change subject: core: CI - ban artifacts in common project to avoid compilation
problem of GWT
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: show LUN id in audit log when SD partially inaccessible
(#854214)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http:
Allon Mureinik has posted comments on this change.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Roy Golan has submitted this change and it was merged.
Change subject: core: throttle running of VMs (#843058)
..
core: throttle running of VMs (#843058)
https://bugzilla.redhat.com/show_bug.cgi?id=843058
Bulk running of VMs r
Roy Golan has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: check for duplicate upgrade scripts on unix
..
Patch Set 2: Verified
patchset 2: changed !windows to unix
--
To view, visit http://gerrit.ovirt.org/8192
Roy Golan has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit htt
Allon Mureinik has posted comments on this change.
Change subject: core: check for duplicate upgrade scripts on unix
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8192
To unsubscribe, visit http://gerrit.ov
Roy Golan has submitted this change and it was merged.
Change subject: core: replace Date with long for time variable
..
core: replace Date with long for time variable
Change-Id: I50473b6fddaf06f2cedffb2a7c45a8507c1a7014
Signed
Roy Golan has posted comments on this change.
Change subject: core: replace Date with long for time variable
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7245
To unsubscribe, vi
Roy Golan has posted comments on this change.
Change subject: core: replace Date with long for time variable
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/7245
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has uploaded a new change for review.
Change subject: core: check for duplicate upgrade scripts on unix
..
core: check for duplicate upgrade scripts on unix
The check for duplicate upgrade scripts is implemented a
Ayal Baron has posted comments on this change.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Ayal Baron has posted comments on this change.
Change subject: core: show LUN id in audit log when SD partially inaccessible
(#854214)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ge
Roy Golan has posted comments on this change.
Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests
..
Patch Set 1: Looks good to me, approved
its just its confusing to have both of them with no way to
Ayal Baron has posted comments on this change.
Change subject: core: log domain name during error in irsbroker (#854025)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Roy Golan has posted comments on this change.
Change subject: core: Extracted VmValidator
..
Patch Set 4:
CDI patch - http://gerrit.ovirt.org/#/c/5575/
--
To view, visit http://gerrit.ovirt.org/8101
To unsubscribe, visit http:
1 - 100 of 127 matches
Mail list logo