[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler clenaup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImagesHandler clenaup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerr

[Engine-patches] Change in ovirt-engine[master]: core: ExportVmCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ExportVmCommand clenaup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8204 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: ChangeDiskCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ChangeDiskCommand clenaup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8203 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: SnapshotsManager clenaup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: SnapshotsManager clenaup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8202 To unsubscribe, visit http://gerrit.ovirt.org/settings G

[Engine-patches] Change in ovirt-engine[master]: core: UpdateStorageDomainCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: UpdateStorageDomainCommand clenaup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8201 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: UpdateStorageDomainCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: UpdateStorageDomainCommand clenaup .. core: UpdateStorageDomainCommand clenaup Removed usage of the deprecated StringHelper class from UpdateStorageDoami

[Engine-patches] Change in ovirt-engine[master]: core: ChangeDiskCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: ChangeDiskCommand clenaup .. core: ChangeDiskCommand clenaup Removed usage of the deprecated StringHelper class from ChangeDiskCommand and used a simple

[Engine-patches] Change in ovirt-engine[master]: core: ExportVmCommand clenaup

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: ExportVmCommand clenaup .. core: ExportVmCommand clenaup Removed usage of the deprecated StringHelper class from ExortVmCommand and used apache commons'

[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler clenaup

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: ImagesHandler clenaup .. core: ImagesHandler clenaup Removed usage of the deprecated StringHelper class from ImagesHandler and used apache commons' Strin

[Engine-patches] Change in ovirt-engine[master]: core: SnapshotsManager clenaup

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: SnapshotsManager clenaup .. core: SnapshotsManager clenaup Removed usage of the deprecated StringHelper class from SnapshotsManager and used apache commo

[Engine-patches] Change in ovirt-engine[master]: core: log domain name during error in irsbroker (#854025)

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: log domain name during error in irsbroker (#854025) .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: Trust the SpmStart task result during election

2012-09-25 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Trust the SpmStart task result during election .. Patch Set 2: (1 inline comment) File backend/manage

[Engine-patches] Change in ovirt-engine[master]: core: log domain name during error in irsbroker (#854025)

2012-09-25 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: core: log domain name during error in irsbroker (#854025) .. Patch Set 2: Verified Rebased (note there were a few changes to merge), re-verified, made getDomainI

[Engine-patches] Change in ovirt-engine[master]: core: remove redundant nullcheck

2012-09-25 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: remove redundant nullcheck .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7959 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Resizable columns in main tab grids

2012-09-25 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Resizable columns in main tab grids .. webadmin: Resizable columns in main tab grids This patch enables column resizing for all main tab grids, updati

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Run once: unable to attach floppy disks...

2012-09-25 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Run once: unable to attach floppy disks (#855579) .. userportal,webadmin: Run once: unable to attach floppy disks (#855579) https:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Invalid Time Zone Shown for Windows Gue...

2012-09-25 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests .. userportal,webadmin: Invalid Time Zone Shown for Windows Guests VM -> General: Time z

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Invalid Time Zone Shown for Windows Gue...

2012-09-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/79

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Run once: unable to attach floppy disks...

2012-09-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Run once: unable to attach floppy disks (#855579) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Resizable table columns

2012-09-25 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Resizable table columns .. Patch Set 10: MainTabVirtualMachineView (VM main tab table) related changes were reverted, column resizing will

[Engine-patches] Change in ovirt-engine[master]: core: notify user about broken domain tasks (#753591)

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: notify user about broken domain tasks (#753591) .. Patch Set 4: Laszlo - it's already merged. You can check it out at http://gerrit.ovirt.org/#/c/7257/

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: ClusterModel FindBugs

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: userportal,webadmin: ClusterModel FindBugs .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8197 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: webadmin: SearchSuggestionDisplay Findbugs

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: SearchSuggestionDisplay Findbugs .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8196 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: DateTime cleanup: Remove unused methods

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: DateTime cleanup: Remove unused methods .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8195 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: check for duplicate upgrade scripts on unix .. Patch Set 3: Verified; Looks good to me, but someone else must approve rebased (on top of unrelated changes

[Engine-patches] Change in ovirt-engine[master]: webadmin: SearchSuggestionDisplay Findbugs

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: webadmin: SearchSuggestionDisplay Findbugs .. webadmin: SearchSuggestionDisplay Findbugs Fixed the FindBugs issue: "Possible null pointer dereference of sugges

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: ClusterModel FindBugs

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: userportal,webadmin: ClusterModel FindBugs .. userportal,webadmin: ClusterModel FindBugs In StoragePool_SelectedItemChanged, selectedDataCenter is validated to

[Engine-patches] Change in ovirt-engine[master]: core: DateTime cleanup: Remove unused methods

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: DateTime cleanup: Remove unused methods .. core: DateTime cleanup: Remove unused methods Removed unused methods of DateTime. As a side effect, this solv

[Engine-patches] Change in ovirt-engine[master]: engine: vm doesn't boot from cd when CD set in "edit" (#8568...

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806) .. Patch Set 2: (2 inline comments) File backen

[Engine-patches] Change in ovirt-engine[master]: core: Removing TransactiveAttribute and appropriate logic

2012-09-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: Removing TransactiveAttribute and appropriate logic .. core: Removing TransactiveAttribute and appropriate logic The following attribute was used

[Engine-patches] Change in ovirt-engine[master]: core: Removing TransactiveAttribute and appropriate logic

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Removing TransactiveAttribute and appropriate logic .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: notify user about broken domain tasks (#753591)

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: notify user about broken domain tasks (#753591) .. Patch Set 4: mkublin - can you verify that your patch (removing said class) also solve this issue? --

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: add locks to VmTemplate commands (#761515) .. core: add locks to VmTemplate commands (#761515) https://bugzilla.redhat.com/761515 Currently the

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: add locks to VmTemplate commands (#761515) .. Patch Set 17: Verified; Looks good to me, approved (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: notify user about broken domain tasks (#753591)

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: notify user about broken domain tasks (#753591) .. Patch Set 4: Hi, I remove a HandleFailedStorageDomain class -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: minor AddStorageDomainCommon cleanup

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: minor AddStorageDomainCommon cleanup .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7958 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: remove redundant nullcheck

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: remove redundant nullcheck .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7959 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: cleanup IrsBrokerCommand

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: cleanup IrsBrokerCommand .. Patch Set 4: Looks good to me, approved consider applly Allon's remarks -- To view, visit http://gerrit.ovirt.org/7960 To uns

[Engine-patches] Change in ovirt-engine[master]: core: GetStoragePoolInfoVDSCommand cleanup

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: GetStoragePoolInfoVDSCommand cleanup .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7963 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: cleanup IrsBrokerCommand

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: cleanup IrsBrokerCommand .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7962 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: IrsBrokerCommand cleanup II

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: IrsBrokerCommand cleanup II .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7961 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: Use the parent parameters in RemoveAllVmImagesCommand

2012-09-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: Use the parent parameters in RemoveAllVmImagesCommand .. Use the parent parameters in RemoveAllVmImagesCommand When performing the RemoveAllVmImagesCom

[Engine-patches] Change in ovirt-engine[master]: Use the parent parameters in RemoveAllVmImagesCommand

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: Use the parent parameters in RemoveAllVmImagesCommand .. Patch Set 2: Verified; Looks good to me, approved rebase -- To view, visit http://gerrit.ovirt.org/811

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: Use the parent parameters in RemoveAllVmImagesCommand

2012-09-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: Use the parent parameters in RemoveAllVmImagesCommand .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8119 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/8124 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 4: (1 inline comment) File packaging/fedo

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: add locks to VmTemplate commands (#761515) .. Patch Set 16: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8013

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 4: (1 inline comment) File packaging/fe

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: add locks to VmTemplate commands (#761515) .. Patch Set 15: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: Use the parent parameters in RemoveAllVmImagesCommand

2012-09-25 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Use the parent parameters in RemoveAllVmImagesCommand .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8119 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: add locks to VmTemplate commands (#761515) .. Patch Set 15: Looks good to me, but someone else must approve (1 inline comment) Add the missing annotation

[Engine-patches] Change in ovirt-engine[master]: core: fixed exception during creation of VM from template

2012-09-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: core: fixed exception during creation of VM from template .. core: fixed exception during creation of VM from template During executing AddVmFromTemplateC

[Engine-patches] Change in ovirt-engine[master]: core: fixed exception during creation of VM from template

2012-09-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: fixed exception during creation of VM from template .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8194 To un

[Engine-patches] Change in ovirt-engine[master]: core: fixed exception during creation of VM from template

2012-09-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: fixed exception during creation of VM from template .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8194 To un

[Engine-patches] Change in ovirt-engine[master]: core: less mutable VdsSelector

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: less mutable VdsSelector .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6830 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2012-09-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: > 1. If your code imports something - a dependency should be added to the > pom.xml of th

[Engine-patches] Change in ovirt-engine[master]: core: fixed exception during creation of VM from template

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fixed exception during creation of VM from template .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)

2012-09-25 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: add locks to VmTemplate commands (#761515) .. Patch Set 15: Verified -- To view, visit http://gerrit.ovirt.org/8013 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 4: (1 inline comment) File packaging/fedo

[Engine-patches] Change in ovirt-engine[master]: core: fixed exception during creation of VM from template

2012-09-25 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: core: fixed exception during creation of VM from template .. core: fixed exception during creation of VM from template During executing AddVmFromTemplateCommand,

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: Looks good to me, but someone else must approve Thanks Juan, that was enlightening. Just

[Engine-patches] Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output

2012-09-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: add a method to work with parsed sql output .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2012-09-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: No, it is not a duplication. Any thing that is included in an "import ..." statement in t

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Make dependency on commons-collections explicit .. Patch Set 1: this dependency is defined in the master pom.xml - isn't this a duplication? -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...

2012-09-25 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT .. core: CI - ban artifacts in common project to avoid compilation problem of

[Engine-patches] Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/6785 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: show LUN id in audit log when SD partially inaccessibl...

2012-09-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: core: show LUN id in audit log when SD partially inaccessible (#854214) .. core: show LUN id in audit log when SD partially inaccessible (#854214) https:

[Engine-patches] Change in ovirt-engine[master]: core: show LUN id in audit log when SD partially inaccessibl...

2012-09-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: show LUN id in audit log when SD partially inaccessible (#854214) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: cleanup IrsBrokerCommand

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: cleanup IrsBrokerCommand .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Resizable table columns (#767924)

2012-09-25 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Resizable table columns (#767924) .. Patch Set 9: Patch set updated with regard to table scroll bar position handling: * while in the same

[Engine-patches] Change in ovirt-engine[master]: core: IrsBrokerCommand cleanup II

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: IrsBrokerCommand cleanup II .. Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) see inline .

[Engine-patches] Change in ovirt-engine[master]: core: cleanup IrsBrokerCommand

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: cleanup IrsBrokerCommand .. Patch Set 4: Looks good to me, but someone else must approve (2 inline comments)

[Engine-patches] Change in ovirt-engine[master]: core: remove redundant nullcheck

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: remove redundant nullcheck .. Patch Set 4: Sharad: I'm guessing this is a "bug by evolution" 1st iteration: getstatus().equals(Active) - as you mentioned

[Engine-patches] Change in ovirt-engine[master]: core: remove redundant nullcheck

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: remove redundant nullcheck .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7959 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix

2012-09-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: check for duplicate upgrade scripts on unix .. Patch Set 2: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: minor AddStorageDomainCommon cleanup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: minor AddStorageDomainCommon cleanup .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7958 To uns

[Engine-patches] Change in ovirt-engine[master]: core: GetStoragePoolInfoVDSCommand cleanup

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: GetStoragePoolInfoVDSCommand cleanup .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7963 To uns

[Engine-patches] Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...

2012-09-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: core: error message when deactivating SD with active VMs (#843407) .. core: error message when deactivating SD with active VMs (#843407) https://bugzilla

[Engine-patches] Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...

2012-09-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: error message when deactivating SD with active VMs (#843407) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Removing TransactiveAttribute and appropriate logic

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Removing TransactiveAttribute and appropriate logic .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...

2012-09-25 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: show LUN id in audit log when SD partially inaccessibl...

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: show LUN id in audit log when SD partially inaccessible (#854214) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: error message when deactivating SD with active VMs (#843407) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: throttle running of VMs (#843058)

2012-09-25 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: throttle running of VMs (#843058) .. core: throttle running of VMs (#843058) https://bugzilla.redhat.com/show_bug.cgi?id=843058 Bulk running of VMs r

[Engine-patches] Change in ovirt-engine[master]: core: throttle running of VMs (#843058)

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: throttle running of VMs (#843058) .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7204 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: check for duplicate upgrade scripts on unix .. Patch Set 2: Verified patchset 2: changed !windows to unix -- To view, visit http://gerrit.ovirt.org/8192

[Engine-patches] Change in ovirt-engine[master]: core: throttle running of VMs (#843058)

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: throttle running of VMs (#843058) .. Patch Set 9: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7204 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix

2012-09-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: check for duplicate upgrade scripts on unix .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8192 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: replace Date with long for time variable

2012-09-25 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: replace Date with long for time variable .. core: replace Date with long for time variable Change-Id: I50473b6fddaf06f2cedffb2a7c45a8507c1a7014 Signed

[Engine-patches] Change in ovirt-engine[master]: core: replace Date with long for time variable

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: replace Date with long for time variable .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7245 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: replace Date with long for time variable

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: replace Date with long for time variable .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7245 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix

2012-09-25 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: check for duplicate upgrade scripts on unix .. core: check for duplicate upgrade scripts on unix The check for duplicate upgrade scripts is implemented a

[Engine-patches] Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...

2012-09-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: error message when deactivating SD with active VMs (#843407) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: show LUN id in audit log when SD partially inaccessibl...

2012-09-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: show LUN id in audit log when SD partially inaccessible (#854214) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Invalid Time Zone Shown for Windows Gue...

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests .. Patch Set 1: Looks good to me, approved its just its confusing to have both of them with no way to

[Engine-patches] Change in ovirt-engine[master]: core: log domain name during error in irsbroker (#854025)

2012-09-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: log domain name during error in irsbroker (#854025) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Extracted VmValidator

2012-09-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Extracted VmValidator .. Patch Set 4: CDI patch - http://gerrit.ovirt.org/#/c/5575/ -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http:

  1   2   >