Roy Golan has posted comments on this change.
Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BootSequence.java
Line 27: ND(14, N, D);
Line 28:
Line 29: private int intValue;
Line 30: private static Map<Integer, BootSequence> mappings;
Line 31: private final List<BootSequence> subsequences;
see java.util.EnumSet. I think it cant help simplify instead of the List
Line 32:
Line 33: static {
Line 34: mappings = new HashMap<Integer, BootSequence>();
Line 35: for (BootSequence error : values()) {
Line 79: boolean firstElementNotPresent = firstElementIndex == -1;
Line 80: boolean subsequenceTooLong = subsequences.size() -
firstElementIndex < subsequence.subsequences.size();
Line 81:
Line 82: if (firstElementNotPresent || subsequenceTooLong) {
Line 83: return false;
again you get all this in EnumSet
Line 84: }
Line 85:
Line 86: List<BootSequence> sublist =
Line 87: subsequences.subList(firstElementIndex,
firstElementIndex + subsequence.subsequences.size());
--
To view, visit http://gerrit.ovirt.org/8077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d39f8559bcffdc154b0b2c01d5303cf2ff1e1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
