Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 380: if rc == 0:
Line 381: # we need to provide records, but return the newline
Line 382: # so that if field contains new line it will be preserved
Line 383: # we also want reusable list, so load all into memory
Line 384: ret = [x for x in csv.DictReader([x+"\n" for x in
out.split("\n")])]
Mine either... but isn't this the Python way? :)
It is the same as:
in = []
for x in out.split("\n"):
in.append(x+"\n")
ret = []
for x in csv.DictReader(in):
ret.append(x)
Line 385:
Line 386: return ret, rc
Line 387:
Line 388: def replaceWithLink(target, link):
--
To view, visit http://gerrit.ovirt.org/8124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a6e0461a3e31d31b2f3c8ef82a92c0e047b8e82
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
