Federico Simoncelli has posted comments on this change.

Change subject: Trust the SpmStart task result during election
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 112:     }
Line 113: 
Line 114:     private void logException(RuntimeException ex) {
Line 115:         log.errorFormat("Command {0} execution failed. Exception: 
{1}", getCommandName(), ExceptionUtils.getMessage(ex));
Line 116:         if (!(ex instanceof VDSExceptionBase)) {
This is related to how this issue was discovered and debugged. Anyway let me 
know if you prefer this in a separate patch.
Line 117:             log.error(ExceptionUtils.getStackTrace(ex));
Line 118:         }
Line 119:     }
Line 120: 


--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to