Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 10:
Manual rebase.
--
To view, visit http://gerrit.ovirt.org/6997
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 15: (1 inline comment)
File
backend/manager/modules/bll/src/m
Alon Bar-Lev has posted comments on this change.
Change subject: core: Incorrect syntax for String.format
..
Patch Set 1:
yair?
--
To view, visit http://gerrit.ovirt.org/7852
To unsubscribe, visit http://gerrit.ovirt.org/setti
Keith Robertson has posted comments on this change.
Change subject: tools: Fix default port (BZ857480)
..
Patch Set 3: (1 inline comment)
File src/engine-iso-uploader.py
Line
Muli Salem has posted comments on this change.
Change subject: core: Allow Non-Required Networks Not On Host (Do not submit)
..
Patch Set 2: (5 inline comments)
File
backend
Vered Volansky has posted comments on this change.
Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7798
Vered Volansky has posted comments on this change.
Change subject: core: RemoveTemplateSnapshot's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7799
Vered Volansky has posted comments on this change.
Change subject: core: VmCommand's ConcreteCreateTask
..
Patch Set 5: No score; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7801
To
Vered Volansky has posted comments on this change.
Change subject: core: RestoreFromSnapshot's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7800
To
Vered Volansky has posted comments on this change.
Change subject: core: RemoveImage's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
.
Vered Volansky has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
...
Vered Volansky has posted comments on this change.
Change subject: core: HibernateVmCommand's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
..
Vered Volansky has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit htt
Vered Volansky has posted comments on this change.
Change subject: core: VmCommand's ConcreteCreateTask
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7801
To unsubscribe, visit http://gerrit.ovirt.org/setti
Vered Volansky has posted comments on this change.
Change subject: core: CreateImageTemplate's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7794
To
Vered Volansky has posted comments on this change.
Change subject: core: AddImageFromScratch's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7793
To
Vered Volansky has posted comments on this change.
Change subject: core: CreateCloneOfTemplate's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7795
Vered Volansky has posted comments on this change.
Change subject: core: MoveOrCopyImageGroup's ConcreteCreateTask
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7796
T
Vered Volansky has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7792
To uns
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Avoid 64 bit JVM options (#852037)
..
packaging: Avoid 64 bit JVM options (#852037)
https://bugzilla.redhat.com/852037
Currently we add the
Juan Hernandez has posted comments on this change.
Change subject: packaging: Avoid 64 bit JVM options (#852037)
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verificatio.
--
To view,
Juan Hernandez has posted comments on this change.
Change subject: packaging: Avoid 64 bit JVM options (#852037)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7949
To unsubscribe, visit ht
Roy Golan has submitted this change and it was merged.
Change subject: core: allow upgrading cluster level when there are running VMs
(#856172)
..
core: allow upgrading cluster level when there are running VMs (#856172)
Removi
Roy Golan has posted comments on this change.
Change subject: core: allow upgrading cluster level when there are running VMs
(#856172)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
..
Patch Set 6: Looks good to me, approved
Approved.
Michael's comments were applied.
--
To view, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7989
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: Making NGuid implement Comparable(#852451)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7988
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: audig_log table is not cleaned ...(#856009)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8016
To unsubscribe, visi
Roy Golan has posted comments on this change.
Change subject: core: allow upgrading cluster level when there are running VMs
(#856172)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7987
To unsubscribe, vis
Eli Mesika has uploaded a new change for review.
Change subject: core: audig_log table is not cleaned ...(#856009)
..
core: audig_log table is not cleaned ...(#856009)
core audig_log table is not cleaned properly, causing rhevm
Eli Mesika has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules
Eli Mesika has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
..
Patch Set 5: (2 inline comments)
File
backend/manager/module
Daniel Erez has submitted this change and it was merged.
Change subject: core: HibernateVmCommand's ConcreteCreateTask
..
core: HibernateVmCommand's ConcreteCreateTask
Removed ConcreteCreateTask from HibernateVmCommand.,
and us
Daniel Erez has posted comments on this change.
Change subject: core: HibernateVmCommand's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7802
To unsubscribe, v
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmCommand's ConcreteCreateTask
..
core: VmCommand's ConcreteCreateTask
Removed ConcreteCreateTask from VmCommand,
and used the new getTaskType() mec
Daniel Erez has posted comments on this change.
Change subject: core: VmCommand's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7801
To unsubscribe, visit http
Daniel Erez has submitted this change and it was merged.
Change subject: core: RestoreFromSnapshot's ConcreteCreateTask
..
core: RestoreFromSnapshot's ConcreteCreateTask
Removed ConcreteCreateTask from RestoreFromSnapshotComman
Daniel Erez has posted comments on this change.
Change subject: core: RestoreFromSnapshot's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7800
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: core: RemoveTemplateSnapshot's ConcreteCreateTask
..
core: RemoveTemplateSnapshot's ConcreteCreateTask
Removed ConcreteCreateTask from RemoveTemplateSnaps
Daniel Erez has posted comments on this change.
Change subject: core: RemoveTemplateSnapshot's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7799
To unsubscrib
Daniel Erez has submitted this change and it was merged.
Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask
..
core: RemoveSnapshotSingleDisk ConcreteCreateTask
Removed ConcreteCreateTask from RemoveSnapshotSingl
Daniel Erez has posted comments on this change.
Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7798
To unsubscrib
Daniel Erez has submitted this change and it was merged.
Change subject: core: RemoveImage's ConcreteCreateTask
..
core: RemoveImage's ConcreteCreateTask
Removed ConcreteCreateTask from RemoveImageCommand,
and used the new getT
Daniel Erez has posted comments on this change.
Change subject: core: RemoveImage's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7797
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Daniel Erez has submitted this change and it was merged.
Change subject: core: MoveOrCopyImageGroup's ConcreteCreateTask
..
core: MoveOrCopyImageGroup's ConcreteCreateTask
Removed ConcreteCreateTask from MoveOrCopyImageGroupCom
Daniel Erez has posted comments on this change.
Change subject: core: MoveOrCopyImageGroup's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7796
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: core: CreateCloneOfTemplate's ConcreteCreateTask
..
core: CreateCloneOfTemplate's ConcreteCreateTask
Removed ConcreteCreateTask from CreateCloneOfTemplate
Daniel Erez has posted comments on this change.
Change subject: core: CreateCloneOfTemplate's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7795
To unsubscribe
Daniel Erez has submitted this change and it was merged.
Change subject: core: CreateImageTemplate's ConcreteCreateTask
..
core: CreateImageTemplate's ConcreteCreateTask
Removed ConcreteCreateTask from CreateImageTemplateComman
Daniel Erez has posted comments on this change.
Change subject: core: CreateImageTemplate's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7794
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: core: AddImageFromScratch's ConcreteCreateTask
..
core: AddImageFromScratch's ConcreteCreateTask
Removed the ConcreteCreateTask from the AddImageFromScrat
Daniel Erez has posted comments on this change.
Change subject: core: AddImageFromScratch's ConcreteCreateTask
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7793
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removing auto-recovery code for storage domains
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Besides the order issu
Daniel Erez has submitted this change and it was merged.
Change subject: core: CommandsBase: refactor task creation
..
core: CommandsBase: refactor task creation
In order to create async tasks, CommandBase expects inheriting cl
Daniel Erez has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7792
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7792
To unsubscribe, visi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix the fn_db_split_config_value db function and uses
..
core: fix the fn_db_split_config_value db function and uses
Previous patch added the fn_db
Oved Ourfali has posted comments on this change.
Change subject: core: fix the fn_db_split_config_value db function and uses
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7973
To
Oved Ourfali has posted comments on this change.
Change subject: core: fix the fn_db_split_config_value db function and uses
..
Patch Set 2:
Verified both on secured and non-secured environments.
Ran the VM and was able to conn
Michael Kublin has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Michael Kublin has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
..
Patch Set 5: Looks good to me, approved
(2 inline comments)
Small remarks
..
Michael Kublin has uploaded a new change for review.
Change subject: core: Removing auto-recovery code for storage domains
..
core: Removing auto-recovery code for storage domains
Because of change which were done at error stora
Michael Kublin has uploaded a new change for review.
Change subject: core: Upgrade status domain
..
core: Upgrade status domain
Because of change in behaviour at error flows, all
statuses of storage domains which were InActive s
Allon Mureinik has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
..
Patch Set 5:
This is indeed not the only place - this patch includes CreateSnapshotCommand
as /an example/ to sho
Yair Zaslavsky has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
..
Patch Set 5: (1 inline comment)
CreateSnapshotCommand is the only place that is affected by this change?
This is n
Yair Zaslavsky has submitted this change and it was merged.
Change subject: utils: cleanup: SSHClient: add properties get methods
..
utils: cleanup: SSHClient: add properties get methods
This is required to allow proper messagi
Yair Zaslavsky has posted comments on this change.
Change subject: utils: cleanup: SSHClient: add properties get methods
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8009
To unsubscribe, visit http://gerri
Yair Zaslavsky has posted comments on this change.
Change subject: utils: cleanup: SSHClient: add properties get methods
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8009
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: Allow Non-Required Networks Not On Host (Do not submit)
..
Patch Set 2: (5 inline comments)
What should be the case of hotplug-nic ? doesn't same mitigation
Liron Aravot has uploaded a new change for review.
Change subject: core: add locks to VmTemplate commands (#761515)
..
core: add locks to VmTemplate commands (#761515)
https://bugzilla.redhat.com/761515
Currently the different
Yair Zaslavsky has posted comments on this change.
Change subject: core: VmDevice implements comparable(#852451)
..
Patch Set 2: (2 inline comments)
File
backend/manager/mod
Yair Zaslavsky has posted comments on this change.
Change subject: core: Making NGuid implement Comparable(#852451)
..
Patch Set 2:
I agree with the change to "other"
--
To view, visit http://gerrit.ovirt.org/7988
To unsubscri
73 matches
Mail list logo
