Michael Kublin has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
......................................................................
Patch Set 5: Looks good to me, approved
(2 inline comments)
Small remarks
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
Line 86:
Line 87: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 88: @Override
Line 89: public Void runInTransaction() {
Line 90:
can u add space before devices
Line 91:
getVmDeviceDao().updateAll("UpdateVmDeviceForHotPlugDisk",devices);
Line 92: VmHandler.updateDisksFromDb(getVm());
Line 93: return null;
Line 94: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 221:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 222: new TransactionMethod<Void>() {
Line 223:
Line 224: @Override
Line 225: public Void runInTransaction() {
please add space before entities
Line 226: dao.updateAll(procedureName,entities);
Line 227: return null;
Line 228: }
Line 229: });
--
To view, visit http://gerrit.ovirt.org/7641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If316259f9760777c5f85db0880a157021c61a6ba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
