Yair Zaslavsky has posted comments on this change.
Change subject: core: Removing auto-recovery code for storage domains
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Besides the order issue, looks good to me.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 602: select
fn_db_update_config_value('VdsFenceType','alom,apc,bladecenter,drac5,eps,ilo,ilo3,ipmilan,rsa,rsb,wti,cisco_ucs','3.1');
Line 603: select fn_db_update_config_value('VmGracefulShutdownMessage','The
Engine is shutting down this Virtual Machine','general');
Line 604: select
fn_db_update_config_value('DisconnectPoolOnReconstruct','0,2,3','general');
Line 605: select
fn_db_update_config_value('SupportBridgesReportByVDSM','false','3.1');
Line 606: select
fn_db_update_config_value('AutoRecoveryAllowedTypes','{\"hosts\":\"false\"}','general');
Please maintain alpha-betical order here, I know we missed it out in some
reviews, but it should be kept in order.
Thanks!
Line 607:
Line 608:
Line 609:
------------------------------------------------------------------------------------
Line 610: -- Update only if default not changed section
--
To view, visit http://gerrit.ovirt.org/8015
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04f25dca8888b19711a840aed150227437972d65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
