Yair Zaslavsky has posted comments on this change.
Change subject: core: CommandsBase: refactor task creation
......................................................................
Patch Set 5: (1 inline comment)
CreateSnapshotCommand is the only place that is affected by this change?
This is not the only place where we use "ConcreteCreateTask".
If there are more places, I would separate the patch to "infra" patch (this
one) and "usage" patch (next patch)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1116: parametersForTask,
Line 1117: asyncTaskCreationInfo.getStepId(),
Line 1118: getCommandId()));
Line 1119: p.setEntityId(getParameters().getEntityId());
Line 1120: return
AsyncTaskManager.getInstance().CreateTask(getTaskType(), p);
while you're at it - would you like to do a favor and use a
"getAsyncTaskManager" instead of AsyncTaskManager.getInstance evil singletone
method? :)
Line 1121: }
Line 1122:
Line 1123: /** @return The type of task that should be created for this
command. Commands that do not create async tasks should throw a {@link
UnsupportedOperationException} */
Line 1124: protected AsyncTaskType getTaskType() {
--
To view, visit http://gerrit.ovirt.org/7792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a4c77067d43ba5c2dbaf46ff855ac14d29de2ff
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
