Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
Incorporated review comment.
File
Yair Zaslavsky has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
..
Patch Set 3:
I suspect the commit message is wrong -
The audit log occurs when a storage pool (DataCen
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/bll/src/m
Yair Zaslavsky has posted comments on this change.
Change subject: core: allow upgrading cluster level when there are running VMs
(#856172)
..
Patch Set 1: Looks good to me, approved
Please verify.
The code looks good to me.
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
core: Power Management for ilo3 is not...(#855835)
core: Power Management for ilo3 is not enabled
Yair Zaslavsky has posted comments on this change.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7990
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7990
To unsubscribe, visit http://gerrit.o
Yair Zaslavsky has posted comments on this change.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7990
To unsubscribe, vis
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: hiding DC in Host tab - GlusterOnly mode
..
webadmin: hiding DC in Host tab - GlusterOnly mode
Data Center column in the Host tab table will not be show
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2501/
Build Number: 2501
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,062
-
Changes Since La
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 13:
Rebased
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerrit.ovirt.org/se
Yair Zaslavsky has posted comments on this change.
Change subject: core: Renamed Execute() to execute() in BrokerCommandBase class
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7996
To uns
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Fix for Find bug error
..
engine: Fix for Find bug error
Build #2499
Change-Id: Ie040cff6cb94e53ce35a35c83752ee3da1cbd313
Signed-off-by: Sel
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fix for Find bug error
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8000
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fix for Find bug error
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8000
To unsubscribe, visit http://gerrit.ovi
Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/bll/src
Kanagaraj M has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
Reply to Alon's comment.
File
backend/
Selvasundaram has uploaded a new change for review.
Change subject: engine: Fix for Find bug error
..
engine: Fix for Find bug error
Build #2499
Change-Id: Ie040cff6cb94e53ce35a35c83752ee3da1cbd313
Signed-off-by: Selvasundara
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: Updating the usage of the new location of .pgpass
..
packaging: Updating the usage of the new location of .pgpass
* Updated usage of the new .pg
Yaniv Dary has posted comments on this change.
Change subject: packaging: Updating the usage of the new location of .pgpass
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7974
To unsubscrib
Yair Zaslavsky has posted comments on this change.
Change subject: core: Making NGuid implement Comparable(#852451)
..
Patch Set 1: (1 inline comment)
File
backend/manager/m
Greg Padgett has uploaded a new change for review.
Change subject: core: log domain name during error in irsbroker (#854025)
..
core: log domain name during error in irsbroker (#854025)
https://bugzilla.redhat.com/854025
Log st
Greg Padgett has posted comments on this change.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
Patch Set 1:
Probably shouldn't merge until after this goes in:
http://gerrit.ovirt.org/7
Greg Padgett has uploaded a new change for review.
Change subject: core: error message when deactivating SD with active VMs
(#843407)
..
core: error message when deactivating SD with active VMs (#843407)
https://bugzilla.redhat
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed Execute() to execute() in BrokerCommandBase class
..
core: Renamed Execute() to execute() in BrokerCommandBase class
To conform to java method nam
Itamar Heim has posted comments on this change.
Change subject: core: Making NGuid implement Comparable(#852451)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modu
Sharad Mishra has abandoned this change.
Change subject: v2
..
Patch Set 1: Abandoned
oops, forgot to merge changes
--
To view, visit http://gerrit.ovirt.org/7995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
Sharad Mishra has uploaded a new change for review.
Change subject: v2
..
v2
Change-Id: I8330b37fcd45b81b12be30d604d72d8de7354194
Signed-off-by: Sharad Mishra
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed CanAddVm to canAddVm
..
Patch Set 1: (2 inline comments)
Commit Message
Line 3: AuthorDate: 20
Sharad Mishra has abandoned this change.
Change subject: core: Use lower case letter to start a method name.
..
Patch Set 1: Abandoned
Abandoning this patch in favor of http://gerrit.ovirt.org/#/c/7994/
--
To view, visit http:
Sharad Mishra has uploaded a new change for review.
Change subject: core: removing unused class AdGroupsHandlingOperationBase
..
core: removing unused class AdGroupsHandlingOperationBase
Change-Id: I00946d23468940633a0d2a35566b5
Alex Lourie has posted comments on this change.
Change subject: packaging: Avoid 64 bit JVM options (#852037)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7949
To uns
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
File
backend/manager/modules/bll/src/m
Sharad Mishra has posted comments on this change.
Change subject: core: Use lower case letter to start a method name.
..
Patch Set 1:
Thanks Roy for confirming. I had the same question.
I will submit another patch to remove th
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2500/
Build Number: 2500
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,061
-
Changes
Muli Salem has uploaded a new change for review.
Change subject: core: Allow Non-Required Networks Not On Host (Do not submit)
..
core: Allow Non-Required Networks Not On Host (Do not submit)
This patch adds the ConfigValue
Only
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2499/
Build Number: 2499
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,060
-
Changes Since
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
core:Import VM should not be blocked when collapse.(#766657)
https://bugzilla.redhat.com/
Maor Lipchuk has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7756
Asaf Shakarchi has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7756
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/7756
To unsubscribe, visit http://
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
engine: Firewall configuration modified to support virt and glust
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http:
Selvasundaram has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/7244
To un
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/7244
To u
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 7: (1 inline comment)
.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7641
To
Selvasundaram has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (2 inline comments)
.
Allon Mureinik has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 8: Looks good to me, but someone else must approve
Code looks OK, please address abaro
Ayal Baron has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
..
Patch Set 7: Looks good to me, but someone else must approve
(6 inline comments)
..
Eli Mesika has posted comments on this change.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7990
To unsubscribe, visit http://gerrit.ovirt
Eli Mesika has uploaded a new change for review.
Change subject: core: Power Management for ilo3 is not...(#855835)
..
core: Power Management for ilo3 is not...(#855835)
core: Power Management for ilo3 is not enabled for 3.1
ht
Maor Lipchuk has posted comments on this change.
Change subject: core[WIP]:Lost tasks will become unknown in engine.
..
Patch Set 1:
Why vdsm looses tasks?
There is an open bug about it on VDSM (https://bugzilla.redhat.com/85
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Change import vm/template messages (#840874)
..
core: Change import vm/template messages (#840874)
https://bugzilla.redhat.com/840874
The log m
Gilad Chaplik has posted comments on this change.
Change subject: core: Change import vm/template messages (#840874)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7975
To unsubs
Shireesh Anjal has posted comments on this change.
Change subject: engine: Execution messages for Gluster Volume Actions (#856102)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
ofri masad has posted comments on this change.
Change subject: core: Change import vm/template messages (#840874)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7975
To unsubscribe, visit http://gerrit.ovir
Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7988
to review the following change.
Change subject: core: Making NGuid implement Comparable(#852451)
..
core: Making NGuid impl
Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7989
to review the following change.
Change subject: core: VmDevice implements comparable(#852451)
..
core: VmDevice implements
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Peer probe gluster servers on bootstrap
..
engine: Peer probe gluster servers on bootstrap
Whenever the gluster server comes up, do peer probe
Oved Ourfali has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscrib
Eli Mesika has posted comments on this change.
Change subject: core: Prevent dead lock on vm device (#852451)
..
Patch Set 3: (4 inline comments)
File backend/manager/dbscrip
Oved Ourfali has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit http://gerrit.ovirt
Oved Ourfali has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Peer probe gluster servers on bootstrap
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7243
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: core: fix the fn_db_split_config_value db function and uses
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7973
To unsubscribe
Roy Golan has uploaded a new change for review.
Change subject: core: allow upgrading cluster level when there are running VMs
(#856172)
..
core: allow upgrading cluster level when there are running VMs (#856172)
Removing the r
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: Looks good to me, but someone else must approve
OK, apart of the minor issue of String.format(), ACK for the SS
Eli Mesika has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (2 inline comments)
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comm
Michael Kublin has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
..
Patch Set 2: Do not submit
Possible we have some race, but that fix will
Michael Kublin has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
..
Patch Set 2:
small remark, u will need to add a new variable to IrBrokerC
Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13:
Alon, thanks to *your review* - the code looks far cleaner and easy to
understand now :)
--
To view, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (1 inline comment)
.
Oved Ourfali has posted comments on this change.
Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7985
To unsubscribe, visit htt
Oved Ourfali has posted comments on this change.
Change subject: core: fix the fn_db_split_config_value db function and uses
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7973
To unsubscribe, visit http://g
Oved Ourfali has uploaded a new change for review.
Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query
..
core: fix power user roles and GetAllVmPoolsAttachedToUser query
Assigning user roles to Syst
Itamar Heim has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (1 inline comment)
Kanagaraj M has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (1 inline comment)
Reply to Alon's first comment.
File
ba
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (1 inline comment)
...
Moran Goldboim has posted comments on this change.
Change subject: packaging: Updating the usage of the new location of .pgpass
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Selvasundaram has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (1 inline comment)
..
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Get Gluster Servers query
..
Patch Set 13: (2 inline comments)
Thank yo so much!
Two minor questions.
..
Michael Kublin has posted comments on this change.
Change subject: core: WIP :prevent simultaneous ReconstructsMasterDomain on the
same pool(#845838)
..
Patch Set 2: I would prefer that you didn't submit this
I don't like such
Greg Padgett has posted comments on this change.
Change subject: core: look for changes in view and sp files during upgrade
(#857029)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7983
To unsubscribe, visi
Greg Padgett has uploaded a new change for review.
Change subject: core: look for changes in view and sp files during upgrade
(#857029)
..
core: look for changes in view and sp files during upgrade (#857029)
https://bugzilla.re
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Adding gluster volume virt options to configuration
..
engine: Adding gluster volume virt options to configuration
While optimizing a gluster v
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Adding gluster volume virt options to configuration
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7946
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Adding gluster volume virt options to configuration
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7946
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Adding gluster volume virt options to configuration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7946
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 8: (1 inline comment)
File
backend/mana
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 8: (1 inline comment)
File
backend/man
Shireesh Anjal has posted comments on this change.
Change subject: engine: Adding gluster volume virt options to configuration
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Doron Fediuck has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7
Doron Fediuck has posted comments on this change.
Change subject: core: Change import vm/template messages (#840874)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7975
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Firewall configuration modified to support virt and
gluster iptable rules.
..
Patch Set 6: (1 inline comment)
...
Kanagaraj M has posted comments on this change.
Change subject: engine: Adding gluster volume virt options to configuration
..
Patch Set 2:
Updated the options, please have a look at it.
--
To view, visit http://gerrit.ovirt.o
1 - 100 of 186 matches
Mail list logo
