Yair Zaslavsky has posted comments on this change. Change subject: core: Making NGuid implement Comparable(#852451) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java Line 155: .toHexString(k); Line 156: } Line 157: Line 158: @Override Line 159: public int compareTo(NGuid rhs) { rhs = right-hand side. Actually, a term from c++. We can use "other" here. Line 160: return this.getUuid().compareTo(rhs.getUuid()); Line 161: } Line 162: -- To view, visit http://gerrit.ovirt.org/7988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05680581ff14ac916e4d9d559476dfb4683ed229 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches