Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 13: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 95: int state = getIntValue(firstHostElement, STATE);
Line 96: // Add the server only if the state is 3
Line 97: if (state == PEER_IN_CLUSTER) {
Line 98: String hostName = getTextValue(firstHostElement,
HOST_NAME);
Line 99: fingerprints.put(hostName,
getFingerprint(hostName));
Why can't UI (webadmin code) understand null?
Let's not complicate this.
- If fingerprint can't be fetched for any reason, it remains null
- If at least one fingerprint is null, UI gives appropriate error message, and
user can't import *any* server. (Null values will be shown empty on the UI)
- If all fingerprints are non-null, user verifies and approves them, and clicks
on the button to add all of them to the cluster.
Line 100: }
Line 101: }
Line 102: }
Line 103: return fingerprints;
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
