Kanagaraj M has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 13: (1 inline comment)
Reply to Alon's first comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 95: int state = getIntValue(firstHostElement, STATE);
Line 96: // Add the server only if the state is 3
Line 97: if (state == PEER_IN_CLUSTER) {
Line 98: String hostName = getTextValue(firstHostElement,
HOST_NAME);
Line 99: fingerprints.put(hostName,
getFingerprint(hostName));
It could be either "null" or empty string in case of not able to fetch the
fingerprint, UI checks for both of them. And the UI will show an Error to the
user saying "Unable to fetch the fingerprint of the server ...".
Line 100: }
Line 101: }
Line 102: }
Line 103: return fingerprints;
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
