Michael Pasternak has posted comments on this change.
Change subject: cli: support utf-8 encoding
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6978
To unsubscribe, visit http://
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: support utf-8 encoding
..
cli: support utf-8 encoding
Change-Id: I0353e14b1f5268bea4077c40da167d5370a02bd6
Signed-off-by: Michael Pasternak
--
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static AsyncTaskRowMapper instance
..
Patch Set 6:
Please ignore Jenkin's -1.
The error is a server access problem:
"Last Built Revision: R
Michael Pasternak has posted comments on this change.
Change subject: codegen: do not require optional params
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7007
To unsubscribe, v
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: do not require optional params
..
codegen: do not require optional params
Change-Id: I83cc339b060fd8e68ac0918b5faa827355f48f76
Signed-off-b
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: AsyncTaskDAO: static AsyncTaskRowMapper instance
..
Patch Set 6: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.i
Allon Mureinik has posted comments on this change.
Change subject: Revert "core: Option with empty name and value ..."
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/71
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/101/ : SUCCESS
htt
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Replaced FQCNs with imports
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Rebaed, no changes since last +2 revie
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Rebaed, no changes since last +1 revie
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static AsyncTaskRowMapper instance
..
Patch Set 6: Verified
Rebaed, fixed link in commit message as per Sharad's comment in previous patch.
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 6: Verified
Rebaed, fixed link in commit message as per Sharad's comment.
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: make log final
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +1 review.
--
To vi
Allon Mureinik has posted comments on this change.
Change subject: core: SPMAsyncTask: Make logger final
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pendi
Allon Mureinik has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 5: (1 inline comment)
Commit Message
Line 6:
Yair Zaslavsky has posted comments on this change.
Change subject: Revert "core: Option with empty name and value ..."
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7142
To unsubscribe, vi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix AddDisk permission check
..
core: fix AddDisk permission check
When someone adds a floating from the webadmin UI, the vm id is
EMPTY_GUID. Howe
Oved Ourfali has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http:
Oved Ourfali has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/m
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_ad
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/
Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/96/
Build Number: 96
Build Status: Fixed
Triggered By: Manually triggered by user rmiddle for Gerrit:
http://gerrit.ovirt.org/7152
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/
Project: http://jenkins.ovirt.info/job/patch_engine_create_rpms/
Build: http://jenkins.ovirt.info/job/patch_engine_create_rpms/95/
Build Number: 95
Build Status: Failure
Triggered By: Manually triggered by user rmiddle for Gerrit:
http://gerrit.ovirt.org/7152
---
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_ad
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_ad
oVirt Jenkins CI Server has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_unit_t
Alon Bar-Lev has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 2:
Tabs - I didn't change the file syntax. Where there were tabs I used tabs.
--
To view, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 1:
I evaluate the use of a servlet for the error, the benefit of it is that it can
do getServletContext(
Juan Hernandez has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 1:
And, please, use spaces instead of tabs ;-) .
--
To view, visit http://gerrit.ovirt.org/7153
To uns
Sharad Mishra has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 17: (1 inline comment)
File
backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: core: Redirect to index when page not found
..
Patch Set 1: Verified
Juan, what do you think? Look like it is working.
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: Redirect to index when page not found
..
core: Redirect to index when page not found
This is a fix for commit 2107a03979 (ouput index.html as error page),
Sharad Mishra has posted comments on this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7116
To
Sharad Mishra has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 5: (1 inline comment)
Commit Message
Line 6:
L
Sharad Mishra has posted comments on this change.
Change subject: core: AsyncTaskDAO: make log final
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7111
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 3: Do not submit
(2 inline comments)
First of all the patch is bad,
Sharad Mishra has posted comments on this change.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
Patch Set 1:
Don't think you need to put "core" within "<>". Rest looks good !!
--
To view
Robert Middleswarth has uploaded a new change for review.
Change subject: : Adding a README just to testing out the patch process
(#xx)
..
: Adding a README just to testing out the patch process (#xx)
https://bugzilla.r
Michael Kublin has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 7: Verified
Minor fixups due to last rebase.
Please note that error page should be handled a
Ayal Baron has posted comments on this change.
Change subject: Revert "core: Option with empty name and value ..."
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7142
T
Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by data center version
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6990
Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by data center version
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6990
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 7:
If java lover are drunk then I guess I understand why they love writing useless
code :)
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 6:
Another discussion worth a drink.
The fact that Java has garbage collection doesn't m
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/4853
To unsubscribe, visit http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6827
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 6:
> I should have marked the "close" comments as "extra picky" as well.
But it has no rea
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 5: (4 inline comments)
I should have marked the "close" comments as "extra picky" as well
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 15: (1 inline comment)
File packaging/fedora/setup/
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 5: (4 inline comments)
File
backend/m
Juan Hernandez has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
..
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 15:
Fixed the location of the pubtemp variable.
--
To view, visit http://gerrit.ovirt.org/4853
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 14: (1 inline comment)
File packaging/fedora/setup/
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 5: (5 inline comments)
File
backend
Juan Hernandez has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine
..
Patch Set 9: (9 inline comments)
File
backend/manager/mo
Sharad Mishra has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src
Sharad Mishra has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
...
Juan Hernandez has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 14: (2 inline comments)
File packaging/fedora/set
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 14: (3 inline comments)
File packaging/fedora/setup
Juan Hernandez has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 14: (3 inline comments)
File packaging/fedora/set
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 14:
done last comments.
--
To view, visit http://gerrit.ovirt.org/4853
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 6:
rebase with conflicts of master.
--
To view, visit http://gerrit.ovirt.org/6827
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 12: (5 inline comments)
File
backend/manager/modul
Sharad Mishra has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 3: (1 inline comment)
Juan Hernandez has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 5: Looks good to me, but someone else must approve
Nice to see web-conf.js disappear, thank
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: move node id creation command to configuration
..
bootstrap: move node id creation command to configuration
This will enable to modify the co
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: move node id creation command to configuration
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7068
To
Doron Fediuck has submitted this change and it was merged.
Change subject: utils: ssh public key entry should contain new line
..
utils: ssh public key entry should contain new line
A complete entry is a single line.
Change-Id
Juan Hernandez has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 12: Looks good to me, but someone else must approve
(5 inline comments)
.
Doron Fediuck has posted comments on this change.
Change subject: utils: ssh public key entry should contain new line
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7027
To unsubs
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/4853
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has uploaded a new change for review.
Change subject: Revert "core: Option with empty name and value ..."
..
Revert "core: Option with empty name and value ..."
This reverts commit fa6988eac4c32f87680a0f6bd6571315f2
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Method to fetch SSH fingerprint of server
..
Patch Set 4:
Please close this set, thanks.
--
To view, visit http://gerrit.ovirt.org/6927
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 5:
Modified hrefs to be absolute, will submit a patch to fix the error page better
and rever
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send firewall rules without creating temp file
..
Patch Set 4: (1 inline comment)
File
backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 12:
ssh public key fingerprint is now back.
--
To view, visit http://gerrit.ovirt.org/4853
To unsubscri
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix AddDisk permission check
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: utils: ssh public key entry should contain new line
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/7027
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: move node id creation command to configuration
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/7068
To unsubscribe, visit http://ger
Sharad Mishra has posted comments on this change.
Change subject: core: ReconstructMasterDomainCommand-added methods for commands
execution
..
Patch Set 1:
Are we going to call these new methods in future? Currently they are o
Oved Ourfali has uploaded a new change for review.
Change subject: core: fix AddDisk permission check
..
core: fix AddDisk permission check
When someone adds a floating from the webadmin UI, the vm id is
EMPTY_GUID. However, in
Juan Hernandez has posted comments on this change.
Change subject: build: sync packaging with engine
..
Patch Set 5:
>From the packaging point of view I don't see anything wrong here, but we need
>to verify that it works and t
Alon Bar-Lev has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
..
Patch Set 6: (1 inline comment)
Missing is the upgrade part. Will be done soon.
Juan Hernandez has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
..
Patch Set 6: (1 inline comment)
File backend/manager/conf/ca/Creat
Alon Bar-Lev has posted comments on this change.
Change subject: build: sync packaging with engine
..
Patch Set 4: (1 inline comment)
File Makefile
Line 143: install_files:
L
Alon Bar-Lev has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
..
Patch Set 6: (2 inline comments)
This will be pushed after 3.1... then we notify.
..
Allon Mureinik has posted comments on this change.
Change subject: core:Print clusters when upgrading DC version(#844425)
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Minor issues, see inline.
Alex Lourie has posted comments on this change.
Change subject: packaging: Moved config file and backups from /usr (#805516)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Moved config file and backups from /usr (#805516)
..
packaging: Moved config file and backups from /usr (#805516)
https://bugzilla.redhat.com/show_bug.
Asaf Shakarchi has uploaded a new change for review.
Change subject: engine: Import linux template with legacy usb policy (#834254)
..
engine: Import linux template with legacy usb policy (#834254)
https://bugzilla.redhat.com/83
Juan Hernandez has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
..
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
Remember to inform and request input
Liron Aravot has abandoned this change.
Change subject: core: ReconstructMasterDomain - executing host shouldn't
disconnect from pool
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7136
To unsubscribe, vis
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 15:
I think that re factoring the method is good, but I think that implementing it
s
Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 17: Looks good to me, approved
For me it would be more readable if it was merged to the patch
1 - 100 of 230 matches
Mail list logo
