Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send firewall rules without creating temp file ......................................................................
Patch Set 6: > I should have marked the "close" comments as "extra picky" as well. But it has no reason. With all Java wanders, they could not figure out how to do proper resource management, this why the code looks like assembly. Don't get me wrong, I have my share in assembly, but I refuse to believe that at 2012 language that pretend to be progressed stacked at the 70s. -- To view, visit http://gerrit.ovirt.org/7028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b0ee4c62382807d14c5476baf2898a08ee5892 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
