[Engine-patches] Change in ovirt-engine[master]: Revert "core: Option with empty name and value ..."

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: Revert "core: Option with empty name and value ..."
......................................................................

Revert "core: Option with empty name and value ..."

This reverts commit fa6988eac4c32f87680a0f6bd6571315f2c4ab95.

Storage domain cannot be activated or attached to data center.
Cannot discover targets.

Change-Id: Ia99b01a8f7e89dde1b74403fb69c72e0898a0b65
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/7142/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
index c1f831e..eed4d5b 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
@@ -5,7 +5,6 @@
 import org.ovirt.engine.core.bll.Backend;
 import org.ovirt.engine.core.bll.InternalCommandAttribute;
 import 
org.ovirt.engine.core.common.action.StorageServerConnectionParametersBase;
-import org.ovirt.engine.core.common.businessentities.storage_pool;
 import 
org.ovirt.engine.core.common.businessentities.storage_server_connections;
 import org.ovirt.engine.core.common.errors.VdcFault;
 import 
org.ovirt.engine.core.common.vdscommands.ConnectStorageServerVDSCommandParameters;
@@ -23,14 +22,6 @@
 
     @Override
     protected boolean canDoAction() {
-        Guid id = getParameters().getStoragePoolId();
-        if (id != null) {
-            storage_pool dc = getStoragePoolDAO().get(id);
-            if (dc == null) {
-                
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST);
-                return false;
-            }
-        }
         if (!StorageHelperDirector.getInstance()
                 
.getItem(getParameters().getStorageServerConnection().getstorage_type())
                 .ValidateStoragePoolConnectionsInHost(getVds(),


--
To view, visit http://gerrit.ovirt.org/7142
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia99b01a8f7e89dde1b74403fb69c72e0898a0b65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches