Juan Hernandez has posted comments on this change. Change subject: pki: remove the need to store ssh public key ......................................................................
Patch Set 14: (2 inline comments) .................................................... File packaging/fedora/setup/engine-setup.py Line 866: f.write(pubkey) Line 867: cmd = [ Line 868: basedefs.EXEC_SSH_KEYGEN, Line 869: "-lf", pubtemp Line 870: ] Not important, it is ok as is. Line 871: finger, rc = utils.execCmd(cmdList=cmd, failOnError=True) Line 872: msg = output_messages.INFO_CA_SSH_FINGERPRINT%(finger.split()[1]) Line 873: controller.MESSAGES.append(msg) Line 874: Line 881: Line 882: except: Line 883: logging.error(traceback.format_exc()) Line 884: raise Exception(output_messages.ERR_EXP_CREATE_CA) Line 885: finally: Ah ok, I didn't notice. But I think you defined it in a different function, _editWebConf instead of _createCA. Line 886: if pubtemp != None: Line 887: os.remove(pubtemp) Line 888: Line 889: def _changeCaPermissions(pkiDir): -- To view, visit http://gerrit.ovirt.org/4853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I328baded92b2e7c5169bc87e7c19680f598389b9 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
