Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 2:
This is what I had in mind... feel free to revert.
When [if] we store the certificates in database i
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6676
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Support undoing diskless previews
..
Patch Set 3: (3 inline comments)
File
backend/manager/modules/b
Maor Lipchuk has posted comments on this change.
Change subject: core: Disable storage autorecovery (#845294)
..
Patch Set 1:
started to review it, need some more time for review and see if this temporary
fix is what we want m
Allon Mureinik has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/57
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
core: fixed NPE during removal of floating disk (#845046)
https://bugzilla.redhat.com/show_b
Maor Lipchuk has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6861
To u
Allon Mureinik has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6861
To u
Maor Lipchuk has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscr
Allon Mureinik has posted comments on this change.
Change subject: core: MigrateVmCommand cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6828
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/571
Maor Lipchuk has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 3: (1 inline comment)
File
backend/ma
Maor Lipchuk has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 8: (1 inline comment)
Looks good, minor comment
.
Allon Mureinik has posted comments on this change.
Change subject: core: MigrateVmCommand cleanup
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/mai
Allon Mureinik has posted comments on this change.
Change subject: core: replace StringHelper calls in InstallerMessages
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Disable storage autorecovery (#845294)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6865
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Improve AutoRecoveryManagerTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6864
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has uploaded a new change for review.
Change subject: core: Improve AutoRecoveryManagerTest
..
core: Improve AutoRecoveryManagerTest
Before this patch, the test ran the OnTime() method and checked that no
exceptio
Allon Mureinik has uploaded a new change for review.
Change subject: core: Disable storage autorecovery (#845294)
..
core: Disable storage autorecovery (#845294)
https://bugzilla.redhat.com/845294
If a storage domain becomes un
Allon Mureinik has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/571
Allon Mureinik has posted comments on this change.
Change subject: core:[wip]Use engine_test as a default DB for dao tests.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Auto-recovery of host should not start before 5m have
passed since host has been set to non-operational.
..
Patch Set 1:
generally like the idea, agree w
Liron Aravot has posted comments on this change.
Change subject: core: fixed NPE during removal of floating disk (#845046)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6861
To unsubscribe, visit http://ger
Ori Liel has posted comments on this change.
Change subject: codegen: implement http header support
..
Patch Set 1:
+1
--
To view, visit http://gerrit.ovirt.org/6860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Ori Liel has posted comments on this change.
Change subject: codegen: implement http header support
..
Patch Set 1:
looks good, +1
--
To view, visit http://gerrit.ovirt.org/6860
To unsubscribe, visit http://gerrit.ovirt.org/se
Omer Frenkel has posted comments on this change.
Change subject: core:[wip]Use engine_test as a default DB for dao tests.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Michael Pasternak has posted comments on this change.
Change subject: sdk: do not send empty headers
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6862
To unsubscribe, visit http
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: do not send empty headers
..
sdk: do not send empty headers
Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209
Signed-off-by: Michael Pastern
Michael Pasternak has posted comments on this change.
Change subject: codegen: implement http header support
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6860
To unsubscribe, vi
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: implement http header support
..
codegen: implement http header support
Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad
Signed-off-by:
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: refactor url params documentation
..
sdk: refactor url params documentation
Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96
Signed-off-by:
Michael Pasternak has posted comments on this change.
Change subject: sdk: refactor url params documentation
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6849
To unsubscribe, vi
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: rebase to latest api
..
sdk: rebase to latest api
- removed disk.allow_snapshot param documentation
- to network.update() added [@param network
Michael Pasternak has posted comments on this change.
Change subject: sdk: rebase to latest api
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6848
To unsubscribe, visit http://ge
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: do not send empty headers
..
sdk: do not send empty headers
Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209
Signed-off-by: Michael Pasternak
---
Ori Liel has posted comments on this change.
Change subject: sdk: refactor url params documentation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6849
To unsubscribe,
Liron Aravot has uploaded a new change for review.
Change subject: core: fixed NPE during removal of floating disk
..
core: fixed NPE during removal of floating disk
when trying to remove a floating disk NPE was encountered
beac
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: change location of engine-manage-domains.log
..
tools: change location of engine-manage-domains.log
move engine-manage-domains.log to /var/log/o
Yair Zaslavsky has posted comments on this change.
Change subject: tools: change location of engine-manage-domains.log
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: tools: change location of engine-manage-domains.log
..
Patch Set 2: Verified; No score
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: tools: change location of engine-manage-domains.log
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: tools: change location of engine-manage-domains.log
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: core: Auto-recovery of host should not start before 5m have
passed since host has been set to non-operational.
..
Patch Set 1: (1 inline comment)
.
Michael Pasternak has uploaded a new change for review.
Change subject: codegen: implement http header support
..
codegen: implement http header support
Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad
Signed-off-by: Michael
Alon Bar-Lev has posted comments on this change.
Change subject: core: Add servlets for CA and SSH keys
..
Patch Set 1:
OK. At last I am able to understand enough to comment this.
I believe that if a public resource is needed,
Moti Asayag has posted comments on this change.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
..
Patch Set 3: (5 inline comments)
File
backe
Michael Kublin has posted comments on this change.
Change subject: core: Auto-recovery of host should not start before 5m have
passed since host has been set to non-operational.
..
Patch Set 1: (2 inline comments)
Answer to Li
Michael Kublin has submitted this change and it was merged.
Change subject: core: Engine sets hosts to NonOperational based on cached
information (#844291)
..
core: Engine sets hosts to NonOperational based on cached informatio
Michael Kublin has posted comments on this change.
Change subject: core: Engine sets hosts to NonOperational based on cached
information (#844291)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6858
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: Engine sets hosts to NonOperational based on cached
information (#844291)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovir
Michael Kublin has uploaded a new change for review.
Change subject: core: Engine sets hosts to NonOperational based on cached
information (#844291)
..
core: Engine sets hosts to NonOperational based on cached information (#8442
Maor Lipchuk has uploaded a new change for review.
Change subject: core:[wip]Use engine_test as a default DB for dao tests.
..
core:[wip]Use engine_test as a default DB for dao tests.
Change the configuration pgsql file for dao
Livnat Peer has posted comments on this change.
Change subject: core: Auto-recovery of host should not start before 5m have
passed since host has been set to non-operational.
..
Patch Set 1: I would prefer that you didn't submi
Omer Frenkel has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 5: (4 inline comments)
File
backend/manager/modules/bll/src/main/java
Moti Asayag has posted comments on this change.
Change subject: engine: Don't log MTU difference (#838300)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6854
To unsubscribe, visit http://g
Yaniv Bronhaim has posted comments on this change.
Change subject: tools: change location of engine-manage-domains.log
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6855
To unsubscribe, visit http://gerrit.
Moti Asayag has posted comments on this change.
Change subject: engine: Add audit log of unsync networks (#838300)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6853
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: tools: change location of engine-manage-domains.log
..
tools: change location of engine-manage-domains.log
move engine-manage-domains.log to /var/log/ovirt-eng
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 2:
Remove enforcing TLS/SSL on the node registration application.
--
To view, visit http://g
Yaniv Dary has posted comments on this change.
Change subject: history: removed unused column from dwh views.
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6
Allon Mureinik has posted comments on this change.
Change subject: history: removed unused column from dwh views.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6069
To
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169)
..
engine: Use DiskDAO instead DiskImageDAO (#844169)
https://bugzilla.redhat.com/844169
The followin
Maor Lipchuk has posted comments on this change.
Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169)
..
Patch Set 4: Verified; Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.o
Shahar Havivi has posted comments on this change.
Change subject: api: user can set port mirroring without network id
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6547
To unsubscribe, visit http://gerrit.o
Moti Asayag has posted comments on this change.
Change subject: engine: Add audit log message for unsync networks (#838300)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6852
To unsubscrib
Omer Frenkel has posted comments on this change.
Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6768
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: engine: Use DiskDAO instead DiskImageDAO (#844169)
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/676
Maor Lipchuk has posted comments on this change.
Change subject: engine: Use DiskDAO instead DiskImageDAO ($844169)
..
Patch Set 2: (2 inline comments)
File
backend/manager/
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add audit log message for unsync networks (#838300)
..
engine: Add audit log message for unsync networks (#838300)
https://bugzilla.redhat.com/838300
A
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add audit log of unsync networks (#838300)
..
engine: Add audit log of unsync networks (#838300)
https://bugzilla.redhat.com/838300
When getVdsCaps is
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Don't log MTU difference (#838300)
..
engine: Don't log MTU difference (#838300)
https://bugzilla.redhat.com/838300
Since the unsynced networks are now
Kanagaraj M has posted comments on this change.
Change subject: restapi: making gluster enums lower case in request/response
..
Patch Set 4: (1 inline comment)
File
backend/
Selvasundaram has posted comments on this change.
Change subject: engine: Move Gluster host
..
Patch Set 4: (5 inline comments)
File
backend/manager/modules/bll/src/main/jav
Kanagaraj M has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 2: Verified
Rebase and Verified.
Removed the AccessControlList validations from BackedGlu
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Main events tab takes too long to fetch data
..
webadmin: Main events tab takes too long to fetch data
The same issue as already fixed for subtabs in:
Ori Liel has posted comments on this change.
Change subject: restapi: making gluster enums lower case in request/response
..
Patch Set 4: (1 inline comment)
looks good, I had one comment
...
Ofer Schreiber has posted comments on this change.
Change subject: packaging: redirect to TLS/SSL using application server
..
Patch Set 1: No score; Looks good to me, but someone else must approve
My mistake, I didn't see the c
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: refactor url params documentation
..
sdk: refactor url params documentation
Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96
Signed-off-by: Michael
Ori Liel has posted comments on this change.
Change subject: restapi: removing access protocols and acl in create volume
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6410
To unsubscribe,
Ori Liel has posted comments on this change.
Change subject: sdk: rebase to latest api
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6848
To unsubscribe, visit http://
Mike Kolesnik has submitted this change and it was merged.
Change subject: webadmin: not vm networks appear in vnic edit dialog
..
webadmin: not vm networks appear in vnic edit dialog
https://bugzilla.redhat.com/842249
It is p
Mike Kolesnik has posted comments on this change.
Change subject: webadmin: not vm networks appear in vnic edit dialog
..
Patch Set 2: Looks good to me, approved
Already acked by derez
--
To view, visit http://gerrit.ovirt.org
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: parameters in error mesaages
..
core: parameters in error mesaages
https://bugzilla.redhat.com/840795
https://bugzilla.redhat.com/842295
Error me
Liron Aravot has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 7: (1 inline comment)
File
backend/manager/m
Alona Kaplan has posted comments on this change.
Change subject: webadmin: not vm networks appear in vnic edit dialog
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6820
To unsubscribe, visit http://gerrit.o
Alona Kaplan has posted comments on this change.
Change subject: core: parameters in error mesaages
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mike Kolesnik has posted comments on this change.
Change subject: core: parameters in error mesaages
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6817
To unsubscribe, visit http://gerrit.
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Added Enable / Disable CIFS option feature
..
engine: Added Enable / Disable CIFS option feature
- Added the new cifs configuration constant 'tru
Omer Frenkel has posted comments on this change.
Change subject: engine: Added Enable / Disable CIFS option feature
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6397
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 6: (1 inline comment)
File
backend/manager
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Added Enable / Disable CIFS option feature
..
Patch Set 4: Verified
Rebased with master.
--
To view, visit http://gerrit.ovirt.org/6397
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
..
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: rebase to latest api
..
sdk: rebase to latest api
- removed disk.allow_snapshot param documentation
- to network.update() added [@param network.name: s
Omer Frenkel has posted comments on this change.
Change subject: engine: Added Enable / Disable CIFS option feature
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6397
To unsubscribe, visit
96 matches
Mail list logo
