Ori Liel has posted comments on this change. Change subject: restapi: making gluster enums lower case in request/response ......................................................................
Patch Set 4: (1 inline comment) looks good, I had one comment .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java Line 51: brick.setState(fromBrick.getStatus().name().toLowerCase()); here you are still using string matching. Write a mapper for the status and use it here. -- To view, visit http://gerrit.ovirt.org/6093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aeec51d82ad650b9e1364295e6794e0b0861618 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
