Kanagaraj M has posted comments on this change. Change subject: restapi: making gluster enums lower case in request/response ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java Line 51: brick.setState(fromBrick.getStatus().name().toLowerCase()); The status is passed while sending the brick details to the client and not from the client back(one way). The enum is present only in the engine not in rest. Do I need to have a corresponding enum in rest? -- To view, visit http://gerrit.ovirt.org/6093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aeec51d82ad650b9e1364295e6794e0b0861618 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
