Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Don't use network_cluster delegate access
..
restapi: Don't use network_cluster delegate access
Don't use the delegating accessors from Network
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Don't use network_cluster delegate access
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6513
To unsubscribe, visit http://gerrit.ov
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Change network_cluster status to enum type
..
core: Change network_cluster status to enum type
Status should be enum type and not an int, so chang
Mike Kolesnik has posted comments on this change.
Change subject: core: Change network_cluster status to enum type
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no change since ack by masayag
--
To view, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Group cluster related fields in mapper
..
restapi: Group cluster related fields in mapper
These fields are related to cluster-network attachmen
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Group cluster related fields in mapper
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6511
To unsubscribe, visit http://gerrit.ovirt
Ori Liel has posted comments on this change.
Change subject: restapi: Group cluster related fields in mapper
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6511
To unsubscribe, visit http:/
Ori Liel has posted comments on this change.
Change subject: restapi: Don't use network_cluster delegate access
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6513
To unsubscribe, visit htt
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1853/
Build Number: 1853
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,395
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1599/
Build Number: 1599
Build Status: Fixed
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
Ori Liel has posted comments on this change.
Change subject: restapi: preserve /from/ query param in sake if backward
compatibility
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerri
Tomas Jelinek has posted comments on this change.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
..
Patch Set 3:
changed according to comments
--
To view, visit http://gerrit.ovirt.org/6459
To uns
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1598/
Build Number: 1598
Build Status: Failure
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Mike Kolesnik has abandoned this change.
Change subject: webadmin: Add required to clone of network
..
Patch Set 1: Abandoned
obsolete
--
To view, visit http://gerrit.ovirt.org/6450
To unsubscribe, visit http://gerrit.ovirt.or
Mike Kolesnik has abandoned this change.
Change subject: webadmin: Don't rely on network_cluster existing
..
Patch Set 3: Abandoned
obsolete
--
To view, visit http://gerrit.ovirt.org/6292
To unsubscribe, visit http://gerrit.ov
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1852/
Build Number: 1852
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,394
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1851/
Build Number: 1851
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,393
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1850/
Build Number: 1850
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,392
Ayal Baron has posted comments on this change.
Change subject: core: added information to ConnectStorageVDScommand logs
(#835546)
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
I agree with All
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1849/
Build Number: 1849
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,391
Ayal Baron has posted comments on this change.
Change subject: webadmin: separate storage & cluster quota
..
Patch Set 8: (8 inline comments)
File
frontend/webadmin/modules/
Daniel Erez has uploaded a new change for review.
Change subject: core: Added VDS to StorageHandlingCommandBase jobProperties
..
core: Added VDS to StorageHandlingCommandBase jobProperties
Added 'VdcObjectType.VDS' to 'jobProper
Eli Mesika has posted comments on this change.
Change subject: core:pre upgrade scripts will not run ...(#842119)
..
Patch Set 1: (1 inline comment)
File backend/manager/dbsc
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: configure local storage - validation mark
..
webadmin: configure local storage - validation mark
https://bugzilla.redhat.com/838572
Configure Local Sto
Moti Asayag has posted comments on this change.
Change subject: core: update vm quota when action happens outside
..
Patch Set 1: (2 inline comments)
Adding Omer as a reviewer as well.
.
Ayal Baron has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed unnecessary null value check
..
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
..
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1848/
Build Number: 1848
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,390
Doron Fediuck has posted comments on this change.
Change subject: core: fix quota tests
..
Patch Set 1: Looks good to me, approved
Looks like Y?air's comment also fixed.
Please verify &^ push.
--
To view, visit http://gerrit.o
Ayal Baron has posted comments on this change.
Change subject: core: remove StringHelper from
AddExistingNFSStorageDomainCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.o
Ayal Baron has posted comments on this change.
Change subject: core: remove StringHelper from AddStorageServerConnectionCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core: Support diskless snapshots
..
Patch Set 6: (4 inline comments)
grammar and spelling and typing errors only, nothing substantial
.
Yair Zaslavsky has posted comments on this change.
Change subject: core:pre upgrade scripts will not run ...(#842119)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment.
Looks good
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Don't rely on network_cluster existing
..
webadmin: Don't rely on network_cluster existing
Network contains network_cluster.
Setting of cluster related
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix quota tests
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Since this is DAO - I will give +2.
Please verify that DAO test is not brok
Ayal Baron has posted comments on this change.
Change subject: core: Allow remove snapshot w/o disks (#825809)
..
Patch Set 14: I would prefer that you didn't submit this
(3 inline comments)
...
Yair Zaslavsky has posted comments on this change.
Change subject: core: Prepare RemoveSnapshotCommand for testing
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6118
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1847/
Build Number: 1847
Build Status: Still Failing
Triggered By: Started by user Eyal Edri
-
Changes Since Last Success:
--
Ayal Baron has posted comments on this change.
Change subject: core: Prepare RemoveSnapshotCommand for testing
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6118
To u
Ayal Baron has posted comments on this change.
Change subject: core: Remove disk from snapshots (#828192)
..
Patch Set 20: (1 inline comment)
File
backend/manager/modules/bl
Ayal Baron has posted comments on this change.
Change subject: core: RemoveImageCommand: clean up logging
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6510
To unsubsc
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1843/
Build Number: 1843
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,386
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix infinite hourglass in quota
..
webadmin: fix infinite hourglass in quota
Change-Id: Ie86fc63229f4b36494c4882a1c939bd404eebdaa
Signed-off-b
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fix infinite hourglass in quota
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6522
To unsubsc
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: mark MoveOrCopyTemplateCommand as deprecated
..
core: mark MoveOrCopyTemplateCommand as deprecated
This command isn't in use.
Change-Id: Ic76ebe4
Gilad Chaplik has posted comments on this change.
Change subject: core: mark MoveOrCopyTemplateCommand as deprecated
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6521
T
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fix quota tests
..
core: fix quota tests
the quota dao test expects one more quota, because of deafult quota,
the starting quota count is 0 instead of 1,
Doron Fediuck has posted comments on this change.
Change subject: webadmin: fix infinite hourglass in quota
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6522
To unsubscribe, visit http://
Doron Fediuck has posted comments on this change.
Change subject: core: mark MoveOrCopyTemplateCommand as deprecated
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6521
To unsubscribe, visi
Doron Fediuck has posted comments on this change.
Change subject: core: update vm quota when action happens outside
..
Patch Set 1: (2 inline comments)
Please see inline.
Fi
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1846/
Build Number: 1846
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,389
Allon Mureinik has uploaded a new change for review.
Change subject: core: Add enforcer plugin to validate JDK version
..
core: Add enforcer plugin to validate JDK version
Added validation for the JDK version used to build oVirt
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1845/
Build Number: 1845
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,388
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fix infinite hourglass in quota
..
webadmin: fix infinite hourglass in quota
Change-Id: Ie86fc63229f4b36494c4882a1c939bd404eebdaa
Signed-off-by: Gilad
Gilad Chaplik has uploaded a new change for review.
Change subject: core: mark MoveOrCopyTemplateCommand as deprecated
..
core: mark MoveOrCopyTemplateCommand as deprecated
This command isn't in use.
Change-Id: Ic76ebe45d981229
Gilad Chaplik has uploaded a new change for review.
Change subject: core: update vm quota when action happens outside
..
core: update vm quota when action happens outside
Currently there is no way to monitor vm's quota when it's
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1838/
Build Number: 1838
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,387
-
Changes Since La
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Change error message to be more clear
..
core: Change error message to be more clear
Changed the message for VDS_REGISTER_UNIQUE_ID_AMBIGUOUS to
Yair Zaslavsky has posted comments on this change.
Change subject: core: Change error message to be more clear
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6057
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: core: refactoring quota
..
Patch Set 9: (3 inline comments)
File
backend/manager/modules/bll/src/main/java/
Alex Lourie has posted comments on this change.
Change subject: packaging: Added service name parameter to checking Jboss status
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Tested in interactive py
Eli Mesika has posted comments on this change.
Change subject: core: Change error message to be more clear
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6057
To unsubscribe, visit http://g
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Added service name parameter to checking Jboss status
..
packaging: Added service name parameter to checking Jboss status
Change-Id: I72c33b3c334775686
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6073
To un
Maor Lipchuk has posted comments on this change.
Change subject: core: BaseImagesCommand: remove commented out line
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6399
To unsubscr
Maor Lipchuk has posted comments on this change.
Change subject: core: Support diskless snapshots
..
Patch Set 6: (2 inline comments)
File
backend/manager/modules/bll/src/ma
Ayal Baron has posted comments on this change.
Change subject: core: refactoring quota
..
Patch Set 9: (4 inline comments)
Partial review
File
backend/manager/modules/bll/s
Maor Lipchuk has posted comments on this change.
Change subject: core: export/import of diskless VM/VM with no snappable
disks(#838937)
..
Patch Set 4: (5 inline comments)
F
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: separate storage & cluster quota
..
Patch Set 8: (17 inline comments)
File
frontend/webadmin/modu
Ayal Baron has posted comments on this change.
Change subject: webadmin: quota fix-ups in webadmin
..
Patch Set 9: (1 inline comment)
File
frontend/webadmin/modules/uicommon
Ori Liel has posted comments on this change.
Change subject: restapi: Don't use network_cluster delegate access
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6513
To unsubscribe, visit htt
Ori Liel has posted comments on this change.
Change subject: restapi: Group cluster related fields in mapper
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6511
To unsubscribe, visit http:/
Ayal Baron has posted comments on this change.
Change subject: webadmin: separate storage & cluster quota
..
Patch Set 8: (17 inline comments)
File
frontend/webadmin/modules
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Group cluster related fields in mapper
..
Patch Set 1: (1 inline comment)
File
backend/manager/mod
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Cleanup BackendApiResourceTest
..
restapi: Cleanup BackendApiResourceTest
Removed unused @RunWith statements, method parameters, and private
methods
Ori Liel has posted comments on this change.
Change subject: restapi: Cleanup BackendApiResourceTest
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6280
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: restapi: Cleanup BackendApiResourceTest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6280
To unsubscribe, visit http://gerrit.ovirt.org/se
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1840/
Build Number: 1840
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,383
-
Chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1790/
Build Number: 1790
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,382
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1789/
Build Number: 1789
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 2,381
-
Changes Sin
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6073
To un
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/60
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
core: RegisterVdsQuery - removal of '_' character from members names
Change-Id:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
core: RegisterVdsQuery -removed CanDoAction()
removed unneeded CanDoAction() method, the method containe
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5631
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: core: call vm down event on host reboot
..
Patch Set 1: Looks good to me, approved
pending doc
--
To view, visit http://gerrit.ovirt.org/6375
To unsubscribe, visit
Ori Liel has uploaded a new change for review.
Change subject: restapi: Add User With Rules Inline
..
restapi: Add User With Rules Inline
Change-Id: I6e4dfb19e95770ec0dd900709ee9728faa7805c9
Signed-off-by: Ori Liel
---
M
backe
Maor Lipchuk has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Yaniv Dary has posted comments on this change.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6515
To unsub
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
packaging: fixed logs location to /var/log/ovirt-engine
Change-Id: If072883b69027d8af316282cec44
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5631
To
Yaniv Dary has posted comments on this change.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
Patch Set 1: Looks good to me, approved
Will refactor all the code this week. will stay like this for now
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - removal of '_' character from members
names
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Alex Lourie has posted comments on this change.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Minor comment: it is better to us
Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery - change logger to be final field
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Yaniv Dary has posted comments on this change.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: fixed logs location to /var/log/ovirt-engine
..
packaging: fixed logs location to /var/log/ovirt-engine
Change-Id: If072883b69027d8af316282cec442a9d5719
Ayal Baron has posted comments on this change.
Change subject: core: RemoveImageCommand: standardize comparisons
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6509
To
Moti Asayag has posted comments on this change.
Change subject: core: Change network_cluster status to enum type
..
Patch Set 1: Looks good to me, approved
Saw on the fixtures the init value is Operational (1) for the networks.
1 - 100 of 252 matches
Mail list logo
