Ayal Baron has posted comments on this change. Change subject: core: RegisterVdsQuery -removed unnecessary null value check ......................................................................
Patch Set 7: Looks good to me, but someone else must approve (2 inline comments) .................................................... Commit Message Line 10: only when to 'otp' is not null, so there is no reason for remove the 'to' Line 11: checking if its not null again in the method body. s/its/it's/ -- To view, visit http://gerrit.ovirt.org/6067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53542e8a06d12b9b9fc586f1331538400d357bca Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
