Ayal Baron has posted comments on this change. Change subject: core: Remove disk from snapshots (#828192) ......................................................................
Patch Set 20: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java Line 101: final DiskImage diskImage = getDiskImage(); by the way, instead of all of this, why not call synchronizeDisksFromSnapshot in snapshotManager and pass it the disks without the deleted disk? (i.e. keep only the logic that gets all the snapshots, per snapshot get the disks, remove the tobedeleted disk and pass that to synchronize... ? -- To view, visit http://gerrit.ovirt.org/6025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97dedb9b8e8cd4dd0cae6c7b01d4b5678ba0a2d0 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
