Maor Lipchuk has posted comments on this change. Change subject: core: Support diskless snapshots ......................................................................
Patch Set 6: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java Line 85: VmHandler.unlockVm(getVm().getDynamicData(), getCompensationContext()); No need to use unlock if no disks exists, please re factor the command line so it will be used only for async tasks. Line 163: tryBackToVmConfigurationSnapshot(); Could be race here, please use the free lock after tryBackToVmConfigurationSnapshot -- To view, visit http://gerrit.ovirt.org/6387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
