Yair Zaslavsky has posted comments on this change.
Change subject: core: Deadlock on reconstruct master flow (#795105)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5482
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: core: Option with empty name and value ...
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5490
To unsubscribe, visit http:
Sharad Mishra has posted comments on this change.
Change subject: core: Unable to add bond through SetupNetworks (#828351)
..
Patch Set 1: Looks good to me, but someone else must approve
The patch looks good. But few questions
Sharad Mishra has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 5: (1 inline comment)
File
backend/ma
Moti Asayag has uploaded a new change for review.
Change subject: core: Unable to add bond through SetupNetworks (#828351)
..
core: Unable to add bond through SetupNetworks (#828351)
https://bugzilla.redhat.com/828351
Creating
Sharad Mishra has posted comments on this change.
Change subject: core: Option with empty name and value ...
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5490
To unsu
Juan Hernandez has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 7:
Rebased and added the ENGINE_PROPERTIES variable as suggested by Alex Lourie in
patch
Sharad Mishra has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/5148
T
Haim Ateya has posted comments on this change.
Change subject: core: Deadlock on reconstruct master flow (#795105)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5482
To unsubscribe, visit http://gerrit.ovir
Asaf Shakarchi has uploaded a new change for review.
Change subject: core: New query 'GetAllVms' to get all vms with filtering
support (#783087)
..
core: New query 'GetAllVms' to get all vms with filtering support (#783087)
htt
Gilad Chaplik has uploaded a new change for review.
Change subject: uesrportal: enable edit console iff vm is up
..
uesrportal: enable edit console iff vm is up
currently, in user portal (basic view) we can edit a VM's console,
Michael Kublin has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5517
To unsubscribe, vis
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Edit storage - incorrect number of LUN paths
..
webadmin: Edit storage - incorrect number of LUN paths
When editing iSCSI/FCP storage domain,
LU
Daniel Erez has posted comments on this change.
Change subject: webadmin: Edit storage - incorrect number of LUN paths
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5562
Daniel Erez has posted comments on this change.
Change subject: webadmin: Edit storage - incorrect number of LUN paths
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5562
To unsub
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Edit storage - incorrect number of LUN paths
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5562
To unsubscribe,
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: button cursor style (hand)
..
userportal: button cursor style (hand)
Dialogs the ok/cancel button cursor style changed to hand cursor
Chang
Gilad Chaplik has posted comments on this change.
Change subject: userportal: button cursor style (hand)
..
Patch Set 3: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/5536
To unsubscri
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: remove 'Oops!' from error popup
..
webadmin: remove 'Oops!' from error popup
Change-Id: I3cec8e225aac97ee6560ec71172984b0b1d9f3ac
Signed-off-b
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: remove 'Oops!' from error popup
..
Patch Set 2: Verified; Looks good to me, approved
rebased.
--
To view, visit http://gerrit.ovirt.org/5535
To unsubs
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Edit storage - incorrect number of LUN paths
..
webadmin: Edit storage - incorrect number of LUN paths
When editing iSCSI/FCP storage domain,
LUNs' path
Rami Vaknin has abandoned this change.
Change subject: engine & webadmin: 'IMPORTEXPORT' and 'Import/Export' ->
'EXPORT' and 'Export'
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/5438
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: Added images check builder to ImagesHandler
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5561
Allon Mureinik has posted comments on this change.
Change subject: core: Deadlock on reconstruct master flow (#795105)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
minor comment
.
Martina Kollarova has posted comments on this change.
Change subject: Project init containting some basic tests.
..
Patch Set 1: (11 inline comments)
File tests/common.py
Lin
Tal Nisan has uploaded a new change for review.
Change subject: core: Added images check builder to ImagesHandler
..
core: Added images check builder to ImagesHandler
The current method for images checking ImagesHandler.PerformI
Allon Mureinik has posted comments on this change.
Change subject: core: Added template & pool cleanups to force remove SD
(#818091)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: engine: changed the IsVmTemlateWithSameNameExist to user
..
Patch Set 1: Looks good to me, but someone else must approve
Basically looks good, please edit the c
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Tomas Jelinek has uploaded a new change for review.
Change subject: engine: changed the IsVmTemlateWithSameNameExist to user
..
engine: changed the IsVmTemlateWithSameNameExist to user
Since the IsVmTemlateWithSameNameExist is c
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix getFriendlyVersion
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5489
To unsubscribe, visit http://gerrit.ovir
Alex Lourie has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 5:
Hi Juan
Could you please add i.e. "ENGINE_PROPERTIES" flag to
/etc/sysconfig/ovirt-engin
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: fix network name column title (#820499)
..
webadmin: fix network name column title (#820499)
https://bugzilla.redhat.com/820499
in Hosts=>Network
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: save network params in SetupNetwork (#823881)
..
webadmin: save network params in SetupNetwork (#823881)
https://bugzilla.redhat.com/823881
Setup
Tal Nisan has posted comments on this change.
Change subject: webadmin: fix network name column title (#820499)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5540
To unsubscribe, visit http://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: webadmin: fix network name column title (#820499)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5540
To unsubscribe, visit htt
Tal Nisan has posted comments on this change.
Change subject: webadmin: save network params in SetupNetwork (#823881)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5545
To unsubs
Tal Nisan has posted comments on this change.
Change subject: webadmin: save network's parameters in SetupNetwork
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/m
Tal Nisan has posted comments on this change.
Change subject: webadmin: save network's parameters in SetupNetwork
..
Patch Set 2: (1 inline comment)
Commit Message
Line 9: ht
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Don't include log4j.xml in utils.jar
..
core: Don't include log4j.xml in utils.jar
The POM that we used didn't exclude the log4j.xml from the jar
Yair Zaslavsky has posted comments on this change.
Change subject: core: Don't include log4j.xml in utils.jar
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5538
To unsubscribe, v
Eli Mesika has posted comments on this change.
Change subject: core: Option with empty name and value ...
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll
Yair Zaslavsky has posted comments on this change.
Change subject: core: Don't include log4j.xml in utils.jar
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5538
To unsubscribe, visit http:
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: No red warning when export template that already
exists.
..
Patch Set 5:
addressed comments
--
To view, visit http://gerrit.ovirt.org/5228
To unsubsc
Alona Kaplan has posted comments on this change.
Change subject: webadmin: save network's parameters in SetupNetwork
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5545
To unsubscribe, visit http://gerrit.ov
Alona Kaplan has posted comments on this change.
Change subject: webadmin: fix network name column title
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/5540
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alona Kaplan has posted comments on this change.
Change subject: webadmin: fix network name column title
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5540
T
Eli Mesika has submitted this change and it was merged.
Change subject: core:when a vm is rerun because of failure(#818117)
..
core:when a vm is rerun because of failure(#818117)
https://bugzilla.redhat.com/show_bug.cgi?id=8181
Eli Mesika has posted comments on this change.
Change subject: core:when a vm is rerun because of failure(#818117)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5477
To unsubscri
Tal Nisan has posted comments on this change.
Change subject: webamin: save network's parametrets in SetupNetwork
..
Patch Set 1: (4 inline comments)
Commit Message
Line 7: w
Eli Mesika has posted comments on this change.
Change subject: core:when a vm is rerun because of failure(#818117)
..
Patch Set 3: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/5477
To u
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Refactored network.java to Network.java
..
engine: Refactored network.java to Network.java
'network' does not follow java class naming conventio
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored network.java to Network.java
..
Patch Set 4: Verified; Looks good to me, approved
Rebased
--
To view, visit http://gerrit.ovirt.org/5168
To u
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored network.java to Network.java
..
Patch Set 3: Verified; Looks good to me, approved
Rebased & fixed conflicts, removed unnecessary comment & fix
Eli Mesika has posted comments on this change.
Change subject: core: creating pool when there is not enough space
..
Patch Set 3: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/3830
To un
Eli Mesika has submitted this change and it was merged.
Change subject: core: creating pool when there is not enough space
..
core: creating pool when there is not enough space
Adding a new configuration variable : VmPoolMaxSub
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactored network.java to NetworkEntity.java
..
Patch Set 2: Looks good to me, approved
(4 inline comments)
I have fixed commit message, will rebase, f
Tal Nisan has posted comments on this change.
Change subject: webadmin: fix network name column title
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5540
To unsubscribe, visit http://gerrit
Eli Mesika has abandoned this change.
Change subject: core:[DO NOT SUBMIT] Failed to make templ(#832106)
..
Patch Set 1: Abandoned
Juan patch for that already applied, besides that , this patch caused a
different regression
-
Alona Kaplan has uploaded a new change for review.
Change subject: webamin: save network's parametrets in SetupNetwork
..
webamin: save network's parametrets in SetupNetwork
SetupNetworks- When editig a network through the
Setup
Juan Hernandez has posted comments on this change.
Change subject: core: Close tags in OVF template writer (#832106)
..
Patch Set 3:
> why didn't you remove it from the OvfWriter.Dispose() the dispose is closing
> the document
Gilad Chaplik has abandoned this change.
Change subject: userportal: always enable edit console
..
Patch Set 1: Abandoned
not relevant, actually the logic here is correct, need to keep the same logic
in the userportal (not jus
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fixed disk name in add disk event (819288)
..
core: Fixed disk name in add disk event (819288)
https://bugzilla.redhat.com/819288
Disk name in add di
Tal Nisan has posted comments on this change.
Change subject: core: Fixed disk name in add disk event (819288)
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt.o
Daniel Erez has posted comments on this change.
Change subject: webadmin: remove 'Oops!' from error popup
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5535
To unsubscribe, visit http://ge
Daniel Erez has posted comments on this change.
Change subject: userportal: button cursor style (hand)
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
File
fr
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1279/
Build Number: 1279
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,821
-
Changes Since
Michael Kublin has posted comments on this change.
Change subject: core: Fixed disk name in add disk event (819288)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5530
To unsubscr
Juan Hernandez has posted comments on this change.
Change subject: packaging: Moving Jboss configuration functions to separate
module
..
Patch Set 6: Looks good to me, but someone else must approve
Bye the way, is "ovirt_port8
Tomas Jelinek has posted comments on this change.
Change subject: userportal: always enable edit console
..
Patch Set 1: (1 inline comment)
please see comment
File
frontend
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1390/
Build Number: 1390
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,820
-
Change
Juan Hernandez has posted comments on this change.
Change subject: core: Don't include log4j.xml in utils.jar
..
Patch Set 2: Verified
Rebased and verified that I can build new RPMs, install them, run engine-setup,
add an IPA
Alex Lourie has posted comments on this change.
Change subject: packaging: Moving Jboss configuration functions to separate
module
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit htt
Justin Clift has abandoned this change.
Change subject: engine: Typo fix "Recieved" -> "Received".
..
Patch Set 2: Abandoned
Created a new patch set for this (accidentally instead of updating this one).
--
To view, visit http:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: No red warning when export template that already
exists.
..
Patch Set 4:
in the commit msg, the header is duplicated
--
To view, visit http://gerrit.
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1278/
Build Number: 1278
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,820
-
Chang
Tomas Jelinek has posted comments on this change.
Change subject: userportal: button cursor style (hand)
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5536
T
Shahar Havivi has posted comments on this change.
Change subject: core: Close tags in OVF template writer (#832106)
..
Patch Set 3:
why didn't you remove it from the OvfWriter.Dispose()
the dispose is closing the document tag a
Justin Clift has uploaded a new change for review.
Change subject: engine: Typo fix "Recieved" -> "Received".
..
engine: Typo fix "Recieved" -> "Received".
Change-Id: Ica96fc14cfa5d2ff90046a70abf9ec58b47beeb8
Signed-off-by: Just
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: make /from/ parameter at /events to be described as
matrix param
..
restapi: make /from/ parameter at /events to be described as matrix par
Michael Pasternak has posted comments on this change.
Change subject: restapi: make /from/ parameter at /events to be described as
matrix param
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerr
Ori Liel has posted comments on this change.
Change subject: restapi: make /from/ parameter at /events to be described as
matrix param
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ge
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: fix network name column title
..
webadmin: fix network name column title
in Hosts=>Network Interfaces table change the network
name column's title form
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing unit test
..
core: Fixing unit test
The following patch will fix mistakenly broken unit test
Change-Id: I034fd60378d11b869619de5de6fe2bb1
Michael Kublin has posted comments on this change.
Change subject: core: Fixing unit test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5539
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Me
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing unit test
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5539
To unsubscribe, visit http://gerrit.o
Michael Kublin has uploaded a new change for review.
Change subject: core: Fixing unit test
..
core: Fixing unit test
The following patch will fix mistakenly broken unit test
Change-Id: I034fd60378d11b869619de5de6fe2bb16d558752
Juan Hernandez has uploaded a new change for review.
Change subject: core: Don't include log4j.xml in utils.jar
..
core: Don't include log4j.xml in utils.jar
The POM that we used didn't exclude the log4j.xml from the jar
file. T
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Console popup dialog fixes
..
Patch Set 4: Verified; Looks good to me, approved
rebased & verified
--
To view, visit http://gerrit.ovirt.org/5372
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: Console popup dialog fixes
..
userportal: Console popup dialog fixes
Previously, the ConsolePopup was implemented independently
of the stand
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Console popup dialog fixes
..
Patch Set 4:
rebased & verified
--
To view, visit http://gerrit.ovirt.org/5372
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: engine: Typo fix "Recieved" -> "Received".
..
Patch Set 2:
Please reference Itamar comment from first patch.
--
To view, visit http://gerrit.ovirt.org/5533
To un
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: Extended view/Basic view visibility fixes
..
userportal: Extended view/Basic view visibility fixes
There where two problems with determining
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Extended view/Basic view visibility fixes
..
Patch Set 5: Verified; Looks good to me, approved
rebased & reviewed
--
To view, visit http://gerrit.ov
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: Exception when no items in basic view
..
userportal: Exception when no items in basic view
If there are no VMs or Pools, the UP's basic view
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Exception when no items in basic view
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5470
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: change default gateway title
..
webadmin: change default gateway title
In edit management network form- from host->interface->
edit management
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: change default gateway title
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5518
To unsubscrib
Gilad Chaplik has uploaded a new change for review.
Change subject: userportal: always enable edit console
..
userportal: always enable edit console
Currently edit console in Extended mode is disabled when the vm isn't up:
alter
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: remove 'Oops!' from error popup
..
webadmin: remove 'Oops!' from error popup
Change-Id: I3cec8e225aac97ee6560ec71172984b0b1d9f3ac
Signed-off-by: Gilad
1 - 100 of 205 matches
Mail list logo
